JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
63 lines
2.1 KiB
Python
63 lines
2.1 KiB
Python
from __future__ import annotations
|
|
|
|
from uuid import uuid4
|
|
|
|
from geoalchemy2.shape import from_shape
|
|
from shapely.geometry import MultiPolygon, Polygon
|
|
|
|
from app.models import Area
|
|
from app.services.area_service import AreaService
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
def test_area_serializer_exposes_geojson_geometry_for_map_overlay() -> None:
|
|
project_id = uuid4()
|
|
area = Area(
|
|
id=uuid4(),
|
|
project_id=project_id,
|
|
name="Map AOI",
|
|
original_crs="EPSG:4326",
|
|
area_m2=100.0,
|
|
geometry=from_shape(
|
|
MultiPolygon(
|
|
[
|
|
Polygon(
|
|
[
|
|
(4.35, 51.28),
|
|
(4.36, 51.28),
|
|
(4.36, 51.29),
|
|
(4.35, 51.29),
|
|
(4.35, 51.28),
|
|
],
|
|
),
|
|
],
|
|
),
|
|
srid=4326,
|
|
),
|
|
)
|
|
|
|
payload = AreaService.serialize_area(area)
|
|
|
|
assert payload["id"] == area.id
|
|
assert payload["project_id"] == project_id
|
|
assert payload["geometry"]["type"] == "MultiPolygon"
|
|
assert payload["geometry"]["coordinates"][0][0][0] == (4.35, 51.28)
|
|
|
|
|
|
def test_frontend_wires_selected_area_map_overlay_contract() -> None:
|
|
root = __import__("pathlib").Path(__file__).resolve().parents[2]
|
|
app = read_feature("shell")
|
|
geomap = (root / "frontend" / "src" / "components" / "GeoMap.tsx").read_text(encoding="utf-8")
|
|
map_workspace = read_feature("map_workspace")
|
|
area_panel = (root / "frontend" / "src" / "components" / "project" / "AreaPanel.tsx").read_text(encoding="utf-8")
|
|
|
|
assert "selectedMapAreaId" in app
|
|
assert "areaFeatureCollection" in app
|
|
assert "areaFeatureCollection={areaFeatureCollection}" in app
|
|
assert "areaData={areaFeatureCollection}" in map_workspace
|
|
assert "Werkgebied" in map_workspace
|
|
assert "area-fill" in geomap
|
|
assert "area-line" in geomap
|
|
assert "onSelectMapArea" in area_panel
|
|
assert "Toon op kaart" in area_panel
|