Files
MobilityOps/PROJECT_STATE.md
T

117 KiB
Raw Blame History

Project state

Publication and Unraid deployment (2026-08-02)

  • Unraid deployment is live at http://192.168.10.150:1236 from /mnt/user/appdata/mobilityops, Compose project mobilityops.
  • Deployment config commits: 07ab7a3, 847cd05, e1a1c67, 1e13943. The accepted baseline 4bf9afbeff44088864e0844769d4dd0e4089d85b remains intact.
  • MobilityOps PostgreSQL, API and web services are healthy. Only web port 1236 is exposed by the MobilityOps Compose project; API and PostgreSQL remain internal. Automation uses the server's existing shared n8n at http://192.168.10.150:5678; no second MobilityOps n8n container is running.
  • Migrations are at e7b08389f47f (head) and deterministic seed counts match final acceptance. A Chrome smoke test covered every requested page and a real return; its n8n event succeeded on attempt 1. Browser console and recent service log scans were clean.
  • RAGcore is disabled in favor of the honest local demo provider. MCP Hub registration is disabled. The MobilityOps workflow is published in the existing n8n and live-verified.
  • Local post-change gates: 66 backend tests, Ruff, mypy (44 files), and frontend production build all pass. Evidence is in artifacts/deployment/unraid-summary.md.
  • Published to the private Gitea repository https://gitea.itworx.tech/Jens/MobilityOps. master is the default branch; the full commit history and baseline commit are present; zero tags exist; remote hygiene is clean. origin uses the SSH clone URL supplied by Gitea.
  • Exact next action: none — repository publication and Unraid deployment are complete.

Current milestone

M7 — complete. All milestones (M0M7) done, plus a full post-M7 final-acceptance audit (see below). See artifacts/final-acceptance/summary.md for the definitive acceptance evidence (supersedes artifacts/evidence/final-summary.md, which is kept as historical M7 evidence).

Locked decisions

  • Product name: Fleet Ops (the only visible product name in the UI/copy, never translated; see frontend/src/product.ts). "MobilityOps" is the internal repo name, Compose project name and deployment directory only — never shown to a user. See the "Final product polish: Fleet Ops rebrand" and "Fleet Ops final localization" entries below.
  • Fictitious tenant: Northstar Mobility Demo.
  • Synthetic demo data only; all operational and knowledge data are synthetic. The product itself is not described as a "PoC" in user-facing copy (see the localization entry below) — this document and other internal/engineering docs may still use "PoC" to describe the engineering scope, per CLAUDE.md.
  • Core stack and boundaries are defined in CLAUDE.md and docs/03-architecture.md.
  • RAGcore and ITWorx MCP Hub are external central services.
  • n8n receives post-commit events through an outbox dispatcher.
  • SQLAlchemy 2 declarative models cover the full domain model (backend/app/models/); enums are plain String columns validated at the Pydantic/service layer, not native PG enums (simpler migrations).
  • backend/requirements.lock is compiled inside a python:3.12-slim container (matches the Dockerfile base image) via pip-compile --extra dev; regenerate the same way if pyproject.toml changes.
  • Frontend dependencies pinned (no more "latest"); package-lock.json committed; Docker build uses npm ci.
  • Demo auth is a lightweight HMAC-signed cookie (app/core/security.py), not a real password/JWT flow — matches "Demo role buttons create an authenticated session; they do not bypass authorization middleware." Two fixed demo users (USR-OPS operations_manager, USR-EMP rental_employee) are created by the seed loader, not from a CSV (no users.csv in seed/).
  • Seed loader (backend/app/seed_loader.py) only supports seed --reset (always rebuilds); there is no incremental/idempotent-without-reset mode, since the acceptance criteria only require deterministic reset, not partial import.
  • DataQualityIssue.entity_ref/related_ref from the CSVs are resolved to entity_type/entity_id (UUID) at load time per the domain model; the original human-readable refs are kept in evidence_json (entity_ref, related_refs) since the API and UI need them and re-resolving UUID→public_ref on every read would be wasteful.
  • backend/app/core/config.py added app_secret, session_cookie_name, session_ttl_seconds, seed_dir (/app/seed in-container), cors_allow_origins (comma-separated string, not a list — simpler with pydantic-settings env parsing), demo_today (drives the dashboard's "Today" section against the deterministic anchor date, default 2026-08-01).
  • compose.yaml api build context changed from ./backend to repo root with dockerfile: backend/Dockerfile, so the image can COPY seed ./seed (seed CSVs are outside backend/).
  • Frontend: added react-router-dom@7.18.2 (bumped from 6.x to clear two real advisories — open redirect + arbitrary constructor injection in v6). One residual npm audit finding (RSC-mode CSRF, GHSA-qwww-vcr4-c8h2) does not apply — this SPA never uses React Router's RSC/SSR mode.
  • Nav/pages built so far: Dashboard, Vehicles (list+detail with tabs), Bookings (list+detail), Audit. Data Quality, Knowledge and Automation nav items are intentionally omitted until M3/M5/M4 build the pages behind them — CLAUDE.md forbids dead routes/placeholders.
  • Return workflow (app/services/returns.py): the spec's "validate submitted reading against booking start reading" step was dropped as a hard rejection. For the seeded S1 scenario, a booking's start_odometer_km can already equal the vehicle's canonical odometer, so any regression-testing value would also be below the booking start, making a hard floor there indistinguishable from — and in conflict with — the documented soft-regression path. Only one odometer check exists now: submitted vs. the vehicle's canonical odometer (vehicle.odometer_km), matching the domain-model invariant verbatim ("a return with a lower submitted reading is recorded as an inspection and issue, while canonical odometer remains unchanged").
  • Idempotency: new idempotency_records table (migration e7b08389f47f), unique on idempotency_key, keyed to booking_id. Same key + same booking replays the stored response; same key + different booking → 409 IDEMPOTENCY_KEY_REUSED; different key on an already-returned booking → 409 INVALID_BOOKING_STATE. Concurrency is enforced by SELECT ... FOR UPDATE on the booking row (re-checked for the idempotency record immediately after acquiring the lock, as a safety net for two simultaneous identical-key requests racing the pre-lock check).
  • seed_loader.clear_all() must delete idempotency_records before bookings (FK) — easy to forget when adding new booking-referencing tables; the ordering list at the top of seed_loader.py is the single place to update.
  • Inspection public_ref is assigned as INSP-{count+1:04d} from a live count query (not gap-safe, fine for a PoC single-writer demo, would need a sequence for real concurrency-safe numbering).
  • Found and fixed during browser verification (not caught by pytest, since it's a UI-only defect): ReturnForm originally held its own result state and was conditionally rendered only when booking.status === "active"; once the return succeeded the booking flipped to returned and React unmounted the form before the user ever saw the result panel. Fixed by lifting the result into BookingDetail (ReturnResultPanel is now a sibling, not nested in ReturnForm). Also found: OutboxEvent.event_id's Python-side default=uuid.uuid4 on the mapped_column only applies at flush/commit time, so reading event.event_id before db.commit() returned None (rendered as the literal string "None" in the result panel); fixed by assigning event_id=uuid.uuid4() explicitly at construction. Lesson: SQLAlchemy column default= callables are not available on the in-memory Python object until flush — never rely on the generated value for a same-transaction response body without an explicit db.flush() or an explicit Python-side assignment.
  • Operational note for this environment: docker compose run --rm api ... (used for tests/lint) only starts a throwaway one-off container — it does not update the long-running api/web service containers. After any code change meant to be verified live (browser, curl), docker compose up -d --build <service> is required, not just docker compose build.

Completed evidence

M0 — Reproducible foundation

  • Added backend/app/core/db.py (engine/session), backend/app/models/* (User, Customer, Vehicle, Booking, Inspection, MaintenanceRecord, DataQualityIssue, OutboxEvent, AuditEvent), Alembic config (backend/alembic.ini, backend/alembic/env.py) and initial migration backend/alembic/versions/c9498525abb5_initial_schema.py.
  • Commands run and verified from this checkout:
    • docker compose build api — OK
    • docker compose run --rm api alembic upgrade head — applied cleanly to empty DB, created 9 tables + alembic_version.
    • docker compose run --rm api pytest -q — 1 passed.
    • docker compose run --rm api ruff check . — All checks passed (added extend-exclude = ["alembic/versions"] to backend/pyproject.toml for autogenerated migration line length).
    • docker compose up -d --build — all 4 services healthy: curl http://localhost:8128/health{"status":"ok",...}; curl -o /dev/null -w "%{http_code}" http://localhost:1228/ → 200; curl http://localhost:5678/healthz → 200.
  • Fixed a real scaffold bug: frontend/src/App.tsx used import.meta.env without a vite/client types reference, which broke npm run build in Docker (works fine under plain vite dev because Vite injects the global at dev-time but tsc -b still type-checks it). Added frontend/src/vite-env.d.ts.
  • make is not installed in this Windows/git-bash shell — validated the underlying docker compose ... commands directly instead (Makefile targets are thin wrappers around them and are correct as written for a Linux/CI shell or WSL).
  • Known accepted gap: npm audit reports 1 moderate/1 high transitive esbuild advisory (dev-server-only, fixed only by a Vite 8 major bump); left as-is for the PoC, noted here rather than silently upgrading a major version.

M1 — Operational core

  • Backend additions: app/core/security.py (HMAC-signed session cookies), app/api/deps.py (get_current_user, require_operations_manager), app/core/errors.py (AppError + the documented {"error": {...}} shape wired as a FastAPI exception handler for both AppError and HTTPException), app/seed_loader.py, app/cli.py (python -m app.cli seed --reset), app/services/audit.py, app/schemas.py, routers under app/api/routers/ (demo, dashboard, vehicles, bookings, audit).
  • Frontend additions: React Router-based app shell (src/App.tsx, src/components/Layout.tsx, src/components/RequireAuth.tsx), AuthContext, typed api client (src/api/client.ts, src/api/types.ts), pages Login, Dashboard, Vehicles/VehicleDetail, Bookings/BookingDetail, Audit. Full responsive stylesheet (src/styles.css) covering nav collapse and table→card layout under 700px, visible focus states, no hover-only actions.
  • Commands run and verified from this checkout (container rebuilt each time to pick up code changes):
    • docker compose run --rm api pytest -q19 passed (new: test_seed.py, test_auth.py, test_dashboard.py, test_vehicles.py, test_bookings.py, test_audit.py; tests seed the real Postgres via reset_and_seed in a session fixture, then exercise the FastAPI app through TestClient, not mocks).
    • docker compose run --rm api ruff check . — All checks passed (added ignore = ["B008"] — FastAPI's Depends()-as-default is idiomatic, not a real bug).
    • npm run build (local, Node 24) — clean tsc -b && vite build.
    • docker compose up -d --build then docker compose exec api python -m app.cli seed --reset — counts: users:2 customers:180 vehicles:50 bookings:246 inspections:75 maintenance:40 data_quality_issues:15 workflow_runs:20.
    • curl end-to-end: POST /api/v1/demo/login sets cookie and returns the user; unauthenticated GET /api/v1/dashboard → 401 with the documented error shape; authenticated dashboard/vehicle-detail return real seeded data (verified metrics available:21 rented:11 cleaning:6 maintenance:5 blocked:7, matching the 50 seeded vehicles).
    • Browser smoke test (Chrome via MCP) at desktop width: login page → Operations Manager login → Dashboard (metrics + attention items + today + recent automation all populated) → Vehicle detail MO-016 (tabs render, "Needs attention" badge correct — it's DQ-DEMO-OVERLAP/DQ-DEMO-STATUS) → Booking detail BK-DEMO-RETURN (matches S1 scenario: vehicle MO-024, status active, start odometer 53610). Responsive CSS (@media max-width:700px) was written and code-reviewed but the automated resize during this session didn't visibly reflect in the captured screenshot (likely a screenshot-timing quirk of the browser tool, not necessarily a real bug) — treat the ≤360px layout as visually unverified and re-check with a real device/DevTools emulation before final acceptance (M7).
  • Known accepted gap carried over from M0: npm audit residual esbuild/Vite-8 dev-server-only advisory.

M2 — Vehicle return vertical slice

  • Backend additions: app/models/idempotency.py (IdempotencyRecord), migration e7b08389f47f_idempotency_records, app/services/returns.py (register_vehicle_return — full transaction: row locks, idempotency replay, inspection, canonical-odometer update or regression issue, vehicle status derivation, two audit events, vehicle.returned.v1 outbox event matching contracts/events.schema.json, next-booking-risk lookup), POST /api/v1/bookings/{public_ref}/return wired in app/api/routers/bookings.py with required Idempotency-Key header.
  • Frontend additions: components/ReturnForm.tsx (form + ReturnResultPanel), wired into pages/BookingDetail.tsx (shown only when booking.status === "active"; result persists via lifted state after the booking flips to returned).
  • Commands run and verified from this checkout:
    • docker compose run --rm api pytest -q26 passed, including tests/test_return.py (success/canonical-update, S1 regression scenario by name, damage→blocked, idempotent replay, reject-already-returned, missing-header validation, and a real multi-threaded concurrent-submission test against Postgres asserting exactly 1×201 + 2×409).
    • docker compose run --rm api ruff check . — All checks passed.
    • npm run build — clean.
    • docker compose up -d --build (all services) then docker compose exec api python -m app.cli seed --reset, then a full browser run of the S1 demo scenario against BK-DEMO-RETURN/MO-024: submitted 53000 km (below canonical 54820) → result panel showed INSP-0076, resulting_vehicle_status: maintenance (correctly derived, since canonical 54820 ≥ next_service_km 40000), DQ-RET-0076 created, automation event queued with a real UUID, "no upcoming booking" risk; vehicle detail page confirmed odometer unchanged at 54,820 km and a "Needs attention" badge.
    • Both real defects listed above (form disappearing before showing its result; event_id reading as None) were found via the browser run, not by pytest — the test suite asserted on API response shape/values, not on what the UI actually rendered after a status transition. Worth remembering for M3+: UI state-after-mutation bugs need a browser check, not just API tests.

M3 — Data Quality Workbench

  • app/services/data_quality.py: run_scan() implements all five rules and is called automatically at the end of seed_loader.reset_and_seed() (after db.commit() of the base seed), plus exposed as POST /api/v1/data-quality/scan (Operations Manager only). Idempotency is simplified from the doc's literal (rule_type, entity_type, entity_id, evidence fingerprint) to just (rule_type, entity_type, entity_id) while an issue is open — see rationale below.
  • Router app/api/routers/data_quality.py: GET /issues (filters status/rule_type/severity), GET /issues/{ref} (adds entity_snapshot/related_snapshots for the UI), POST /issues/{ref}/defer, /reject, /merge-customers (Operations Manager only — enforced via require_operations_manager), POST /scan.
  • Real bug found and fixed during this milestone, before any browser check: the first cut of DQ-03 (odometer regression) compared every historical returned booking's end_odometer_km against the vehicle's current odometer_km. Since the seed generator assigns vehicle.odometer_km independently of booking history (see seed/generate_seed.py), this is true for nearly every historical booking by construction (odometer is monotonically increasing over time, so all-but-the-latest reading is "below current") — it produced 51 false-positive issues out of 50 vehicles on first run. Fixed twice: first attempt (compare only the single most-recent booking against canonical) still produced the same problem because canonical itself is disconnected from booking history in this dataset; the working fix compares each vehicle's own returned-booking sequence against itself (each booking's end reading vs. the immediately preceding one, chronologically) — a self-consistency check that doesn't depend on the unrelated vehicle.odometer_km field at all. Final deterministic seed+scan totals: 15 CSV-seeded + 11 scan-discovered = 26 open/resolved data_quality_issues (breakdown: 14 vehicle_status_conflict, 5 missing_required_field, 3 possible_duplicate_customer, 3 odometer_regression, 1 booking_overlap). tests/test_seed.py's exact-count assertion was updated from 15 to 26 accordingly — if the scan logic changes again, update that count.
  • Idempotency simplification rationale: the doc's fingerprint-based key would make the scan blind to issues it structurally can't compute a matching fingerprint for against the CSV-seeded rows (which don't carry a fingerprint field), producing duplicate issues for the same real-world problem (e.g. a second MO-016 overlap issue next to the seeded DQ-DEMO-OVERLAP). Using (rule_type, entity_type, entity_id) alone while open is a stricter, safe simplification: it can never falsely suppress an issue for a different entity, and per-entity there's realistically only one meaningful open issue of a given rule type at a time for this PoC's scope.
  • Merge UI intentionally does not use window.confirm() — a native dialog blocks further automation/testing and isn't screen-reader-distinguishable from page content the same way a rendered role="alertdialog" panel is. Built an inline two-step confirm instead (ReturnForm-style pattern reused).
  • AttentionItem gained an issue_ref field (dashboard now links attention items straight to /data-quality/{issue_ref} instead of only to vehicles); dashboard attention list capped at 8 items (was unbounded, would have shown up to 26 with the richer scan).
  • Commands run and verified from this checkout:
    • docker compose run --rm api pytest -q35 passed (new tests/test_data_quality.py: all five rule types present, scan idempotent on rerun, scan requires Operations Manager, S2/S4 issue-detail snapshots correct, defer→reject-on-closed 409, merge requires Operations Manager, merge rejects an unrelated survivor ref, full S2 merge scenario asserting rewiring + audit + replay-is-409).
    • docker compose run --rm api ruff check . — All checks passed.
    • npm run build — clean (had to fix two possibly 'null' TS errors from a closure-narrowing limitation — TS doesn't narrow const captured-by-closure across nested function boundaries when the value comes from an index/property expression; fixed by re-binding to explicitly-typed local consts right after the guard).
    • Full browser run: Data Quality list (26 open issues, filterable) → DQ-DEMO-DUPLICATE two-column compare (CUS-0012 vs CUS-0178, per-field diff highlighting only where they differ) → merge with inline confirm → issue flips to resolved → confirmed customer_merged audit event with correct actor/entity/correlation → DQ-DEMO-OVERLAP (non-duplicate type) renders evidence JSON + defer/reject, no dead compare UI shown for a rule type it doesn't apply to.

M4 — n8n automation

  • app/services/dispatcher.py: background daemon thread (started/stopped via FastAPI lifespan, not an on_event hook) polling every N8N_DISPATCH_INTERVAL_SECONDS (default 3s). Claim step (_claim_due_events) is a short transaction using SELECT ... FOR UPDATE SKIP LOCKED that only flips pendingdelivering and commits immediately; the HTTP call to n8n happens with no open transaction; the outcome is recorded in a separate short transaction. Exponential backoff min(2**attempts, 60) seconds, N8N_MAX_ATTEMPTS=5 before a permanent failed.
  • Dispatcher reconstructs the wire event from contracts/events.schema.json's exact fields (event_id, event_type, occurred_at, correlation_id, aggregate, data) rather than forwarding OutboxEvent.payload_json wholesale — that column also carries an internal aggregate_ref convenience key (used by dashboard/workflows list rendering) that the schema's additionalProperties: false would reject.
  • POST /api/v1/integrations/n8n/return-callback (app/api/routers/integrations.py): shared-secret auth via X-Service-Token header (N8N_CALLBACK_TOKEN, propagated to both api and n8n containers as MOBILITYOPS_CALLBACK_TOKEN); idempotent by Idempotency-Key (the event UUID) — checked by querying for an existing AuditEvent with that event ID in its metadata, not by OutboxEvent.external_run_id, because the dispatcher only sets that field after it gets n8n's final response, which happens after n8n has already called this callback mid-workflow — using external_run_id as the idempotency guard would have missed the exact redelivery case it's meant to catch.
  • GET /api/v1/workflows + POST /api/v1/workflows/{event_id}/retry (app/api/routers/workflows.py), both Operations Manager only. Retry only allowed from failed; sets pending + clears next_attempt_at so the live dispatcher picks it up on its next cycle (does not reset attempts, so the counter reflects true delivery history).
  • Automation nav + page (pages/Automation.tsx): table of all runs with status/attempts/last error, Retry button for failed rows, visible only to Operations Manager (matches backend authorization rather than just hiding a link).
  • Two real bugs found and fixed, the second only by testing the actual live n8n round-trip, not by pytest:
    1. Seed-loaded workflow_runs.csv rows only ever got payload_json = {"aggregate_ref": ...} (no correlation_id/aggregate/data) — fine for M1M3 since nothing read those keys yet, but once the dispatcher tried to redeliver a seeded row (i.e. the S5 manual-retry demo scenario) it crashed with KeyError: 'correlation_id', leaving that event stuck in delivering forever (the crash happened before the outcome-recording transaction). Fixed in two places: seed_loader.py now builds the full schema-compliant envelope for every workflow_runs.csv row (matching what the live M2 return flow produces), and dispatcher._deliver_one now catches malformed-payload KeyErrors defensively and resolves the row to pending/failed instead of leaving it orphaned — added test_deliver_one_handles_malformed_payload_without_getting_stuck as a regression test for the latter.
    2. This n8n image (2.32.7) has dropped N8N_BASIC_AUTH_ACTIVE as a UI/API gate — it requires an actual owner account via the /setup flow before anything (including webhook registration reliability) works correctly. Also: n8n import:workflow requires the workflow JSON to have a top-level "id" field (added "id": "mobilityops-return-processing") and always deactivates the imported workflow regardless of its "active" field — activation requires n8n publish:workflow --id=<id> followed by a full n8n restart (documented in n8n 2.x CLI, not obvious from the docs pack). Did this manually this session via the CLI + browser setup wizard; this is a one-time operational step that is not automated — a truly clean checkout still needs someone to run docker compose exec n8n n8n import:workflow --input=//imports/mobilityops-return-processing.json, docker compose exec n8n n8n publish:workflow --id=mobilityops-return-processing, docker compose restart n8n, and complete the one-time owner setup at http://localhost:5678/setup (any email/password, no verification required) before the automation demo will work. docs/17-runbook.md should get this exact sequence in M7.
  • Commands run and verified from this checkout:
    • docker compose run --rm api pytest -q49 passed (new tests/test_dispatcher.py — claim/deliver success/failure/backoff/exhaustion-to-failed/malformed-payload, all via monkeypatch.setattr(dispatcher.httpx, "post", ...), no real network calls in tests; tests/test_integrations.py — callback auth, unknown-event 404, idempotent-by-event-ID with a real duplicate-call assertion; tests/test_workflows.py — role gating, retry-only-from-failed, S5 retry-and-audit).
    • docker compose run --rm api ruff check . — All checks passed.
    • npm run build — clean.
    • Full live round trip (not mocked): registered a real return on BK-DEMO-RETURN → outbox event queued → background dispatcher delivered it to the now-activated n8n workflow within its 3s poll interval → n8n called back into /api/v1/integrations/n8n/return-callback (200 OK, confirmed in docker compose logs api) → dispatcher's original POST received n8n's success response → event flipped to succeeded on attempt 1, visible on /automation.
    • S5 scenario end-to-end in the browser: seeded BK-H-0020 (failed, 3 attempts, "Synthetic connection timeout to n8n") → clicked Retry → pending → within ~3s, live dispatcher delivered it through the real n8n instance → succeeded, 4 attempts. This is the full documented S5 scenario working for real, not simulated.

M5 — RAGcore knowledge integration

  • app/services/knowledge/__init__.py: KnowledgeProvider Protocol (sync, not async — the rest of the backend is sync SQLAlchemy/FastAPI, so an async provider interface would have meant bridging paradigms for no benefit) with health()/ask(), plus GroundedAnswer/SourceCard/KnowledgeHealth Pydantic models matching contracts/openapi.yaml's GroundedAnswer schema exactly. get_knowledge_provider() factory switches on settings.knowledge_provider ("demo" default, "ragcore" opt-in).
  • app/services/knowledge/demo.pyDemoKnowledgeProvider: parses the 10 knowledge/procedures/*.md files' YAML frontmatter (hand-rolled flat parser, not PyYAML — avoided adding a dependency for a 6-key flat block) and ## -delimited sections at startup, then does TF-IDF-weighted keyword retrieval (not naive keyword counting) with light suffix-stripping stemming (returnsreturn, damageddamage). This is extractive, not generative: it returns real excerpts and a templated answer sentence, never invented text.
    • Real bug found and fixed by testing the actual S6 question, not by inspection: naive flat keyword-overlap scoring (first cut) let the word "vehicle" — present in nearly every document's title — crowd out the actually-relevant damage-procedure document from the top-3 results for "What must I do when a vehicle returns with damage?", because generic words scored the same as distinctive ones. Fixed by computing corpus-wide IDF per token (log((N+1)/(df+1)) + 1) and weighting matches by it, so common terms contribute little and rare/distinctive terms (like "damage") dominate the ranking. Verified: the S6 question now returns damage-procedure and vehicle-return-procedure in the top 3, matching the documented expectation exactly.
  • app/services/knowledge/ragcore.pyRAGcoreKnowledgeProvider: real httpx adapter guessing a plausible REST contract (GET /health, POST /api/v1/ask) per contracts/ragcore-contract-assumptions.md (RAGcore is built separately; no live instance was reachable this session to verify against). Any connection error, timeout, or malformed response degrades to evidence_state: "unavailable" rather than raising — this is the adapter that actually exercises the architecture's "RAGcore failure disables knowledge answers only" reliability boundary. Not wired as the active provider by default; KNOWLEDGE_PROVIDER=ragcore would need a real, verified base URL to turn on.
  • POST /api/v1/knowledge/questions + GET /api/v1/knowledge/status (app/api/routers/knowledge.py). Audit event knowledge_question_asked logs evidence_state, provider, source_ids, and question_length only — not the question text itself, per docs/12-security-and-audit.md ("log question metadata and source IDs, not unnecessary full prompts").
  • Knowledge nav + page (pages/Knowledge.tsx): chat-style question box, source cards (title/version/section/excerpt) prioritized over the answer text per docs/06-ui-ux.md, explicit grounded/insufficient/unavailable states with distinct visual treatment — never a fabricated-looking answer for the latter two.
  • Dockerfile now also COPY knowledge ./knowledge; added KNOWLEDGE_DIR setting (/app/knowledge/procedures in-container, same pattern as SEED_DIR) rather than deriving the path from __file__ — simpler and doesn't break if the module moves.
  • Commands run and verified from this checkout:
    • docker compose run --rm api pytest -q57 passed (new tests/test_knowledge.py: S6 grounded-with-expected-sources, unrelated question is honestly insufficient with no fabrication, demo provider health/document count, endpoint auth required, audit doesn't leak question text, RAGcore adapter degrades to unavailable on a simulated connection error).
    • docker compose run --rm api ruff check . — All checks passed.
    • npm run build — clean.
    • Full browser run of S6 end-to-end: asked "What must I do when a vehicle returns with damage?" on /knowledge → grounded answer citing "Vehicle return procedure" (2 sections) and "Damage handling procedure" with real excerpts. Also asked an unrelated question ("What is the weather forecast for tomorrow?") → correctly returned "Insufficient evidence" / "No matching procedure was found" with zero sources, confirming no fabrication.

M6 — ITWorx MCP Hub publication

  • app/api/routers/mcp_integrations.py: four read-only endpoints under /api/v1/integrations/mcp/GET operations-summary, GET attention-vehicles (query params minimum_severity/date/limit matching contracts/mcp-tools.json's inputSchema exactly), GET vehicles/{vehicle_ref}, POST search-knowledge (the "narrow façade" the doc calls for — wraps M5's get_knowledge_provider() rather than re-implementing retrieval; the contract's tool has no MobilityOps endpoint field, only routing.preferred: ragcore, so this façade path is MobilityOps's own addition for when the Hub needs a single provider boundary, not literally specified by the contract).
  • Auth: new require_mcp_service_token dependency in app/api/deps.py, same shared-secret-header shape as the M4 n8n callback (X-Service-Token against MCP_HUB_SERVICE_TOKEN) plus an optional X-Client-Id header (defaults to "unknown-mcp-client") used as the audit actor label — the Hub's actual client-identity header name is unknown (no live Hub to confirm against), so this is a reasonable guess documented here rather than assumed silently.
  • McpVehicleDetailOut deliberately omits registration_number and all customer data — narrower than the browser-facing VehicleOut/VehicleDetailOut, matching "no customer or vehicle database access" and the read-only/summary intent of an AI-facing tool. Test test_vehicle_details_known_ref asserts the field's absence explicitly so a future change can't silently widen the exposed surface.
  • Extracted app/services/operations.py (compute_metrics, list_attention_vehicles) out of app/api/routers/dashboard.py so the MCP operations-summary/attention-vehicles endpoints and the human dashboard share one query implementation instead of two copies that could drift — the same "do not duplicate retrieval logic" principle the doc states for the knowledge tool, applied here to the operational-summary tools too.
  • Every provider call writes an AuditEvent (actor_type="service", actor_label=X-Client-Id, action="mcp_tool_request", metadata={tool, status}) — MobilityOps's own record that its provider APIs were reached, independent of whatever central tool-call audit the Hub itself keeps (per docs/10-mcp-hub-integration.md's audit section, the Hub owns the central log; this is the local corroborating one).
  • No write/mutation endpoints exist under the /api/v1/integrations/mcp/ namespace at all (verified by test_no_write_endpoints_exist_under_mcp_namespace — POST/PUT/DELETE against the vehicle-details path all 404/405) — return registration, customer merge, and any booking/vehicle mutation are correctly absent, per the doc's explicit restriction list.
  • Commands run and verified from this checkout:
    • docker compose run --rm api pytest -q66 passed (new tests/test_mcp_integrations.py: token-required, wrong-token 401, all four tools' happy paths, severity/limit filtering, 404 for unknown vehicle, max_sources respected, audit actor/action verified, write-method rejection).
    • docker compose run --rm api ruff check . — All checks passed.
    • Live curl verification against the running stack (no browser needed — these are service-to-service endpoints, not UI): missing header → 422; wrong token → 401; correct token → all four endpoints return correct data (operations-summary metrics match the dashboard; attention-vehicles?minimum_severity=high returned MO-016×2 and MO-031, all severity high; vehicles/MO-016 returned the narrow read-only shape; search-knowledge with max_sources=2 returned exactly 2 grounded sources for the S6 question). Confirmed via GET /api/v1/audit?action=mcp_tool_request that all four calls were recorded with correct actor_type=service, tool name, and status.

M7 — Portfolio polish and final acceptance

  • Automated clean-checkout migrations: backend/entrypoint.sh now runs alembic upgrade head before starting uvicorn (Dockerfile CMD changed from uvicorn ... to ./entrypoint.sh). Verified with a true docker compose down -v (all volumes wiped) → docker compose up --build -d → all 11 tables present, /health and web both green, all 66 backend tests pass, with zero manual migration step.
  • n8n one-time setup scripted where it can be: make n8n-setup runs the import/publish/restart sequence (previously three manual commands discovered ad hoc in M4). The owner-account creation itself cannot be scripted safely (it's an interactive one-time step in n8n 2.x's own onboarding, not a MobilityOps concern) — documented precisely in the rewritten docs/17-runbook.md, including the exact URL and that no email verification is required. Re-ran this full sequence from the wiped-volumes state this session and confirmed the S1 return → outbox → live n8n → callback → succeeded round trip works on a genuinely clean checkout, not just the already-provisioned stack from M0M6.
  • Playwright E2E (frontend/e2e/demo.spec.ts, frontend/playwright.config.ts): one test automating the full 9-step documented demo script end-to-end against the live stack — login, dashboard metrics, open BK-DEMO-RETURN, register an odometer-regression return (S1), verify the quality issue + queued automation event, merge the duplicate-customer scenario (S2), ask the damage question and verify both expected source citations (S6), inspect audit entries, and verify responsive nav + no horizontal overflow at 360px width. Passing. This also resolves the "≤360px layout visually unverified" gap flagged back in M1 — verified both by this test's overflow assertion and by the 9-mobile-dashboard.png screenshot (nav wraps into rows, metric tiles collapse to a 2-column grid, no horizontal scroll).
  • Added frontend/e2e/_capture-screenshots.spec.ts as evidence-generation tooling (underscore-prefixed, excluded from the default playwright test / make e2e run via testIgnore in the config — it calls demo/reset, which a real regression test shouldn't do as a side effect). Captured all 9 screenshots into artifacts/evidence/screenshots/.
  • Wrote artifacts/evidence/architecture.md (mermaid, as-built — distinguishes verified-live components from implemented-but-never-reached-a-real-instance ones, i.e. RAGcore and the MCP Hub) and artifacts/evidence/final-summary.md (commit, exact commands, test counts, screenshot index, RAGcore success/unavailable evidence — including a live-demonstrated unavailable case against an unreachable host, not just the unit test — n8n success/retry evidence, MCP sample calls, known limitations, truthful portfolio wording per docs/16-portfolio-case-study.md's template).
  • Updated README.md (dropped stale "minimal bootable scaffold, not the finished application" wording and the old two-line quickstart in favor of make demo + a pointer to the runbook) and docs/17-runbook.md (full rewrite: exact bootstrap, n8n one-time setup, verification commands, required operational checks, recovery expectations).
  • Final placeholder/dead-UI sweep: grep'd the full frontend/src and backend/app trees for scaffold/TODO/FIXME/"must be replaced" markers — none found. FILE_INDEX.md was left as-is; it's the original build-pack's archive-completeness manifest (a historical snapshot), not a living index that needs to track every file added since — updating it would misrepresent what it's for.
  • Commands run and verified from this checkout (this milestone, cumulative across the whole build):
    • docker compose run --rm api pytest -q66 passed, ruff clean.
    • cd frontend && npm run build — clean.
    • cd frontend && npx playwright test1 passed (full demo script, live stack).
    • Full clean-checkout drill: docker compose down -vdocker compose up --build -ddocker compose exec api python -m app.cli seed --resetdocker compose run --rm api pytest -q (66 passed) → n8n owner setup + make n8n-setup → live S1 return round-tripped through the real n8n instance to succeeded.

Final acceptance audit (post-M7)

A dedicated release-readiness audit was run after M7 claimed completion, specifically to catch anything the milestone-by-milestone build might have missed by only ever validating each piece in isolation.

  • Real gap found: mypy had never been run. mypy is a declared dev dependency (backend/pyproject.toml) but was never wired into any milestone's validation loop — only ruff was. Running it cold surfaced 43 real type errors across 10 files, all pre-existing (not introduced by this audit). Triaged and fixed all of them rather than suppressing:
    • services/returns.py: the vehicle lookup after acquiring FOR UPDATE could type as Vehicle | None with no runtime guard — added an explicit if vehicle is None: raise AppError(..., 404). This was a genuine defensive-programming gap (a dangling FK would have crashed with an unhandled AttributeError/500 instead of a clean 404), not just a type annotation issue.
    • api/routers/bookings.py: same pattern for db.get(Customer, ...) / db.get(Vehicle, ...) in get_booking — added a guard raising 500 with a clear message instead of crashing on None.public_ref.
    • api/deps.py + api/routers/demo.py: CurrentUser.role is a Literal[...], but SessionPayload.role (decoded from an HMAC-signed cookie) and User.role (a DB column) are both plain str. Pydantic validates this at runtime already (so it was never exploitable), but get_current_user now explicitly checks membership before constructing CurrentUser, turning a would-be unhandled ValidationError (500) into a clean 401 for a corrupted/tampered cookie — another real defensive improvement, not just a type-checker appeasement.
    • api/routers/dashboard.py, api/routers/data_quality.py: two instances of reusing one variable name for both a Vehicle and a Customer across an if/else branch, which is genuinely confusing to read regardless of what mypy thinks — renamed to distinct variables (entity/typed union in dashboard, customer/vehicle in the data-quality snapshot helper).
    • services/data_quality.py, seed_loader.py: Booking.__table__.update() / Customer.__table__.update() don't typecheck against SQLAlchemy 2.0's stubs (the .__table__ accessor is typed as the more general FromClause, which doesn't declare .update()) — switched to the idiomatic sqlalchemy.update(Model) construct, which is both correctly typed and the more modern SQLAlchemy 2.0 style anyway.
    • Remaining handful (schemas.py's deprecated conint()Annotated[int, Field(...)], a Sequence vs list .sort() call, an assert-guarded None-narrowing after a WHERE ... IS NOT NULL filter mypy can't see through, Result.rowcount typing gaps) were either latent pydantic-v1-style API usage or genuine SQLAlchemy stub limitations — fixed with the idiomatic modern equivalent or a narrowly-scoped, commented # type: ignore[...] at the exact line, never a blanket suppression.
    • make lint now runs both ruff check . and mypy app; mypy app reports zero errors across 44 source files.
  • No other defects found. Re-ran the full journey matrix end-to-end against a genuinely wiped-volumes (docker compose down -v) clean checkout: all 66 backend tests, ruff, ; ran the demo login → dashboard → vehicle/booking detail → return workflow → invalid-mileage rejection (422, both a negative value and a non-numeric string) → data-quality issue review → duplicate-customer merge → audit trail → Knowledge Assistant → live n8n round trip → MCP Hub endpoint journeys directly via curl against the running stack, all correct.
  • Degraded-mode behavior explicitly re-verified live (not just unit-tested): stopped n8n with docker compose stop n8n, registered a return — it committed (201, booking flipped to returned) exactly as required; the outbox event stayed pending with real ConnectErrors logged and exponential backoff (2 attempts over ~8s); restarted n8n and the dispatcher self-healed without any manual intervention, delivering the event to succeeded on attempt 5. RAGcore unavailable mode re-verified live against an unreachable host (ConnectErrorevidence_state: "unavailable", empty answer, no fabrication). MCP Hub unavailability is architecturally moot for MobilityOps — the Hub only ever calls into MobilityOps, so there is nothing on the MobilityOps side that can degrade if the Hub is down (only the reverse, "does an unavailable Hub break MobilityOps," which is trivially no since nothing here calls out to it).
  • New test coverage added, no existing tests weakened: frontend/e2e/interactive-elements.spec.ts (11 Playwright tests — all seven nav items, every filter on every list page, vehicle detail tabs, defer/reject, automation retry, knowledge form, role-switching, and role-based page restriction) plus the existing demo.spec.ts12/12 e2e tests passing against the live stack.
  • Verified .env is .gitignored and was never committed (git ls-files / git log --all -p -- '*.env' both empty); scanned full git history for AWS keys, private-key headers, and sk-...-style tokens — none found. Every Settings field in backend/app/core/config.py has a corresponding entry either directly in .env.example or is derived/wired through compose.yaml (a few purely-internal container-path constants like SEED_DIR/KNOWLEDGE_DIR are intentionally not operator-configurable and correctly absent from .env.example).
  • Grepped the full frontend/src and backend/app trees for TODO/FIXME/placeholder/ fake/stub/mock/"not implemented" markers — zero real hits (the two placeholder= matches are legitimate HTML input placeholder attributes). Confirmed dashboard metrics and all list-page data are 100% DB-backed (compute_metrics in services/operations.py, never a literal in frontend JSX). Confirmed every frontend route in App.tsx maps to an implemented page and every nav item maps to a real route — no dead routes.
  • Commands run and verified from this audit:
    • docker compose run --rm api pytest -q66 passed.
    • docker compose run --rm api ruff check . — All checks passed.
    • docker compose run --rm api mypy appSuccess: no issues found in 44 source files (0 errors, down from 43).
    • cd frontend && npm run build — clean (tsc -b && vite build).
    • cd frontend && npx playwright test12 passed (demo.spec.ts + interactive-elements.spec.ts).
    • Full clean-checkout drill repeated from a fresh docker compose down -v: automatic migrations, seed, 66/66 tests, n8n owner setup + make n8n-setup, live return round-tripped through n8n to succeeded.
    • See artifacts/final-acceptance/summary.md for the complete evidence write-up (commands, exact outputs, demo access, deployment instructions, five-minute demo flow).

Definition of done

All eight milestones (M0M7) are complete, and a dedicated post-M7 final-acceptance audit found and fixed one real category of gap (mypy never having been run) with zero regressions. docs/14-testing-and-acceptance.md's clean-checkout acceptance list has been walked item by item against a genuinely wiped-volumes checkout, twice (once in M7, once in this audit), and artifacts/final-acceptance/summary.md is the authoritative final evidence document. The two items not fully closed — a live RAGcore instance and a live ITWorx MCP Hub instance — were never reachable in this environment; both integrations are implemented, unit/contract-tested, directly verified against MobilityOps's own API, and their unavailable-degradation paths are live-verified, but an actual round trip against real RAGcore/Hub instances remains unconfirmed and is documented as such rather than claimed.

Known blockers

None. External service credentials may be absent; use the documented demo/degraded providers. The n8n workflow-activation steps are a one-time manual setup requirement in this environment (owner-account creation via n8n's own /setup UI cannot be scripted safely), fully documented in docs/17-runbook.md and scripted where possible (make n8n-setup). RAGcore and the ITWorx MCP Hub itself were never reachable in this environment — both integrations are implemented and directly tested/curl-verified against MobilityOps's own API, but neither a real RAGcore instance nor a real Hub round trip was available to confirm end-to-end.

Premium Control Rail UI transformation (2026-08-02)

  • Branch: design/mobilityops-premium-ui, branched from verified deployed revision dfabb41582e302f45a3de826f85f531bf23dfc8b; master history was not rewritten.
  • Audited every route at 1440, 1280, 768 and 390 px. Baseline findings and captures are in docs/design/current-ux-audit.md and artifacts/design-validation/current/.
  • Authored three twelve-screen product directions and generated representative Stitch anchors in project 17018847755558569017: Control Rail, Dispatch Ledger and Service Atelier. Control Rail was selected and refined twice for hierarchy, accessibility and responsive implementation. Decision, screen inventory, tokens and exact Stitch IDs are in docs/design/design-directions.md, docs/design/design-system.md and docs/design/stitch-manifest.md.
  • Rebuilt the complete React interface around a responsive Control Rail shell: inline SVG icon/brand system, desktop rail, named landmarks, skip link, top bar, mobile bottom navigation, shared loading/error/empty states and reduced-motion support.
  • Redesigned all shipped pages. The dashboard now prioritizes persisted readiness, Attention and today's movements; booking results paginate at 25 rows; every responsive table retains field labels; integrations distinguish n8n evidence, live RAGcore health and the unconfigured MCP adapter without inventing status.
  • Return registration is now capture → review → result. A regression test proves the return endpoint is not called before confirmation; the existing idempotency and local commit/outbox contract is unchanged.
  • Final browser captures are in artifacts/design-validation/implementation/. DOM measurements and Playwright both prove no horizontal overflow at 390, 768, 1280 and 1440 px. See docs/design/implementation-validation.md.
  • Final validation commands from this branch:
    • docker compose run --rm api pytest -q66 passed.
    • docker compose run --rm api ruff check .All checks passed.
    • docker compose run --rm api mypy app0 issues in 44 files.
    • cd frontend && npm run lint — clean TypeScript check.
    • cd frontend && npm run build — production build succeeded (59 modules; 240.24 kB JS, 36.63 kB CSS before gzip).
    • cd frontend && playwright test --reporter=line19 passed including the full five-minute demo, every interactive route, return review semantics and four viewport overflow checks.
  • Review deployment updated at http://192.168.10.150:1236 with persistent PostgreSQL data preserved. Deployed smoke: all ten authenticated routes plus login at desktop and mobile sizes rendered without alert state or horizontal overflow; browser console had zero warnings/errors; seven authenticated API paths returned 200; PostgreSQL/API were healthy and the shared n8n /healthz returned {"status":"ok"}.
  • Corrected the review topology after confirming the host already runs n8n on port 5678: the temporary mobilityops-n8n-1 container was removed without deleting its retained volume; the bundled service is now opt-in through the bundled-n8n profile; the API points to the shared n8n; and the return workflow is imported and published there.
  • The existing n8n's previously empty N8N_HOST and N8N_EDITOR_BASE_URL values were persistently set in its Unraid template. A synthetic return then completed the full MobilityOps → shared n8n → callback round trip as succeeded on attempt 1, after which deterministic demo state was restored (BK-DEMO-RETURN is active).
  • Global search is now live for Control Rail sections and MO-*, BK-*, DQ-* public references, including Ctrl/Cmd+K focus and a tested not-found announcement. Final local Playwright result is 19 passed.
  • Exact next action: hand off design/mobilityops-premium-ui for review. The final code, shared-n8n topology and evidence are committed, pushed and deployed; do not merge master automatically.

Functional completion pass (branch feat/mobilityops-functional-completion)

Branched from design/mobilityops-premium-ui @ 54dc952. Full audit at docs/functional-completion/current-functional-audit.md; server baseline captured before any change at docs/functional-completion/server-baseline.md.

Batch 1 — complete (commits 938a739..bdc58f3)

  • Fixed the two confirmed list-rendering defects: Vehicles and Bookings both computed a filtered/paginated result but rendered the raw unfiltered array in the table body.
  • Added server-backed session lifecycle: GET /api/v1/demo/session (Cache-Control: no-store — a cached 200 was making logout intermittently fail to redirect in e2e testing), POST /api/v1/demo/logout. AuthContext now verifies against the server on every mount instead of trusting sessionStorage, and a central 401 listener on the API client clears auth state from any endpoint.
  • Enforced the brief's role matrix: data-quality (list/detail/defer/reject) and the audit trail were reachable by Rental Employee with no gate beyond authentication (confirmed live via curl before the fix). Both are now require_operations_manager-gated server-side, with matching nav-hiding and a restricted-message fallback for direct URL access, and the dashboard no longer links into those areas for that role.
  • Discovered and fixed a latent e2e-suite bug while testing against the real server: all three spec files hardcoded http://localhost:8128 for their demo-reset helpers, so pointing the suite at Unraid via MOBILITYOPS_PUBLIC_URL silently kept resetting the local dev database instead. Switched to relative paths so the configured baseURL is honoured.
  • Local evidence: pytest 75 passed, ruff check . clean, mypy app 0 issues/44 files, npx tsc -b clean, npm run build clean, npx playwright test 25 passed (up from 19 — 6 new tests this batch), stable across three repeated full-suite runs.
  • Deployed to Unraid (.deploy/source-revision = bdc58f396e99caaf6ef657bb110b479981cc7793, matches git rev-parse HEAD on the feature branch), migrations unchanged at e7b08389f47f (head) (no schema change this batch), demo reset run. Re-verified live: role-gate curl checks (403/200/401 as expected) and the full 25-test Playwright suite run with MOBILITYOPS_PUBLIC_URL=http://192.168.10.150:123625 passed against the actual deployment, not just localhost.
  • Exact next action: Batch 2 — authoritative return-preview endpoint shared with commit, and expose before/after on the audit API + UI.

Batch 2 — complete (commits f521295, 7e34f55)

  • Added evaluate_return() (pure, no writes) in returns.py, extracted from what register_vehicle_return already computed inline; register_vehicle_return now calls it instead of duplicating the logic. New non-mutating POST /api/v1/bookings/{ref}/return-preview uses the same function, so preview and commit cannot drift.
  • Fixed a real defect this surfaced: ReturnForm.tsx's review step guessed the outcome client-side and got the domain rule wrong — it said damage/technical-warning routes to maintenance (actual rule: blocked) and the no-contradiction case becomes available (actual rule: always cleaning first, maintenance only past the service threshold). The review step now calls /return-preview and renders the server's resulting_vehicle_status + status_reason verbatim.
  • Result screen now distinguishes local commit success from n8n delivery ("queued... not yet confirmed" instead of implying both succeeded) and links to any created data-quality issue for Operations Manager.
  • Exposed before/after on AuditEventOut (the DB columns already existed but were never serialized) plus a resolved entity_ref/entity_link for vehicle/booking/ data-quality-issue entities. Audit.tsx now shows a human-readable change summary per row with raw JSON behind a <details> disclosure instead of always-visible JSON.
  • New regression coverage: backend — preview performs no writes (asserted via audit/ outbox row counts before vs. after), detects odometer regression, detects service-due, detects next-booking risk, requires an active booking, and matches the commit result; audit — before/after and entity link exposed for both return_registered and vehicle_status_changed. Frontend — preview correctly reports blocked (not maintenance) for damage, commit request only fires after confirm (updated to also assert exactly one preview call), audit page shows before/after and a safe link.
  • Local evidence: pytest 81 passed, ruff check . clean, mypy app 0 issues/44 files, npx tsc -b clean, npm run build clean, npx playwright test 27 passed, stable across two repeated full-suite runs.
  • Deployed to Unraid and re-verified; demo data reset afterward.
  • Exact next action: Batch 3 — data-quality workbench (typed snapshots, bounded resolution flows for all 5 rule types, manual scan UI).

Batch 3 — complete (commits 6e227a2, 477b5e7)

  • Typed related-entity snapshots by the reference's own prefix (CUS-/MO-/BK-/INSP-) instead of inferring from rule_type. Fixed a real gap this exposed: a booking_overlap issue's related refs are bookings, but get_issue always resolved them as vehicles, so _snapshot() silently returned nothing for them.
  • Added one bounded resolution endpoint per remaining rule type: provide-fields (missing_required_field; re-runs the check, resolves only once nothing required is missing), resolve-odometer-regression (retain canonical or correct the reading — correction is rejected if it would still be below canonical), resolve-overlap (blocks one of the two bookings, re-verifies no overlap remains — found and fixed an autoflush=False bug where the re-verification query didn't see the just-blocked booking's in-memory status change), apply-recommended-status (one authoritative recommendation function mirroring the scan's own conflict conditions, re-validated after applying). possible_duplicate_customer already had merge; all five rule types now have a real bounded resolution path, not just generic defer/reject.
  • Reintroduced evidence after a non-open decision links the new issue back to the prior one (evidence.reopened_from / previous_decision) per the documented lifecycle ("reintroduced evidence creates a new issue linked to the prior issue").
  • DataQualityIssueDetail.tsx rewritten: a typed panel per rule type instead of a raw JSON.stringify dump for four of five types; raw evidence moved behind a <details> disclosure. Added a "Run quality scan" action to the workbench (confirmation, progress, per-rule result counts, auto-refresh) — the scan endpoint already existed with no UI trigger.
  • New regression coverage: backend — one resolution test per rule type plus the role-gate/validation-rejection paths and the recurrence-linking behavior (reject an issue, rescan, assert the new issue links back). Frontend — one Playwright test per resolution flow plus the manual scan trigger.
  • Local evidence: pytest 96 passed, ruff check . clean, mypy app 0 issues/44 files, npx tsc -b clean, npm run build clean, npx playwright test 32 passed, stable across two repeated full-suite runs.
  • Deployed to Unraid and re-verified against the live server; demo data reset afterward.
  • Exact next action: Batch 4 — global search backend + UI, demo reset UI trigger, truthful aggregate integration status (n8n/RAGcore/MCP).

Batch 4 — complete (commits 4437b87, 1867828)

  • Added GET /api/v1/search — bounded typed results (vehicle/booking/data-quality-issue/ section), role-filtered server-side (data-quality and manager-only sections excluded for Rental Employee), customers never returned (no customer detail route exists). Replaced Layout.tsx's blind client-side regex/term guesser with a debounced (250 ms) call to this endpoint, a real role="listbox" results panel, arrow-key navigation, Enter/Escape, outside-click close, and a no-results state.
  • Added GET /api/v1/integrations/status, aggregating outbox delivery counts into one truthful n8n state (disabled/unavailable/degraded/operational/no_evidence) instead of the dashboard/automation cards showing whichever status the single most recent event happened to be in. Wired into both Automation.tsx and Dashboard.tsx. MCP Hub card now reflects the real registration_enabled setting.
  • Found and fixed a real config gap this surfaced: MCP_HUB_REGISTRATION_ENABLED was documented in .env.example but had no Settings field, so it was silently dropped by extra="ignore" and never read anywhere in the codebase.
  • Added a "Reset demo data" action to the sidebar (Operations Manager only, confirm, progress, error handling) — the endpoint already existed and was already gated, just had no UI trigger. Reset invalidates the acting session server-side, so the flow signs the user out and returns to login.
  • New regression coverage: backend — search role-filtering/customer-exclusion/no-match, integration-status role-gate and state-derivation (including a test that resolves all seeded failures and asserts the state flips to operational). Frontend — vehicle/ booking/data-quality-issue search navigation, keyboard nav, no-results + Escape, demo reset happy path, rental employee cannot see the reset button, automation page shows aggregate counts.
  • Local evidence: pytest 109 passed, ruff check . clean, mypy app 0 issues/46 files, npx tsc -b clean, npm run build clean, npx playwright test 37 passed, stable across two repeated full-suite runs.
  • Deployed to Unraid and re-verified against the live server; demo data reset afterward.
  • Exact next action: Batch 5 — bounded outbox delivery-lease recovery for stale delivering events, a second (scheduled quality-scan) n8n workflow, final documentation/contract updates and acceptance evidence.

Batch 5 — complete (commits ec8f809, e115031, c981aad, 824048b)

  • Fixed a real gap: _claim_due_events flipped rows to delivering and committed before the HTTP call, with no reclaim path if the process died before the outcome was recorded. Each claim now gets a lease deadline (n8n_delivery_lease_seconds, default 120s, reusing the next_attempt_at column) and run_dispatch_cycle() sweeps expired leases back to pending before claiming new work; attempts is preserved, and a still-alive worker's unexpired lease is never touched.
  • Added the second n8n workflow: POST /api/v1/integrations/n8n/scheduled-scan (service-token protected, same pattern as the return callback) running the same run_scan() the manual UI action uses, audited with actor_type=service. n8n/mobilityops-scheduled-quality-scan.json (hourly + manual-test trigger) ships "active": false. Live-verified twice: executed end-to-end via the Manual test trigger against the local n8n instance (full green execution, confirmed via the resulting data_quality_scan_run audit event), and published + directly curl-round-tripped against the shared Unraid n8n and its live API (deploy/unraid/setup-scheduled-scan.sh). The shared instance's own UI could not be browser-tested directly — it runs N8N_SECURE_COOKIE=true and refuses login over the plain-HTTP LAN URL, which is correct/expected shared-infrastructure behaviour, not something this task should change.
  • Updated contracts/openapi.yaml and docs/05-api-contract.md with every endpoint added across all five batches; docs/07-data-quality.md, docs/08-return-workflow.md and docs/12-security-and-audit.md now describe the actual resolution flows, the preview/commit relationship, the role matrix and the audit before/after exposure. Corrected docs/07-data-quality.md's lifecycle description to match the already-implemented (rule_type, entity_type, entity_id) idempotency key (no evidence fingerprint) and documented the reopened_from/previous_decision recurrence link. README.md's scope/integration-status/quality-gate sections updated to match.
  • Local evidence: pytest 117 passed, ruff check . clean, mypy app 0 issues/46 files, npx tsc -b clean, npm run build clean, npx playwright test 37 passed.
  • Clean-checkout drill (section 14): fresh git clone of this branch into an isolated scratch directory, .env from .env.example, isolated Compose project name and remapped host ports (no shared state with the working stack), up --build -d from empty volumes → migrations ran automatically → seed → full backend gate (117 passed, ruff clean, mypy clean) → npm ci (clean; the pre-existing esbuild-moderate/ react-router-RSC-high advisories are unchanged, not new) → tsc -b/vite build clean → full Playwright suite 37 passed against the isolated stack. Torn down afterward (down -v on the isolated project only; the working dev stack was never touched).
  • Deployed to Unraid; migrations unchanged at e7b08389f47f (head). Full 37-test Playwright suite re-run against http://192.168.10.150:123637 passed. Demo data reset afterward.
  • Exact next action: none — all five batches are implemented, tested locally (including a genuine clean-checkout drill), committed, pushed, deployed to Unraid and re-verified against the live server after every batch. See artifacts/functional-completion/final-summary.md for the definitive acceptance evidence.

Demo productization (in progress, same branch feat/mobilityops-functional-completion)

Follows the functional-completion work above; turns the now feature-complete PoC into a guided, honestly-labelled demo (fictional org "Northstar Mobility", guided tour, 5 named scenarios, demo manifest, About page). Gap audit: docs/demo-release/current-demo-gap-audit.md.

Batch 1 — seed date anchoring (complete)

  • Real bug fixed: seed/bookings.csv etc. store absolute ISO timestamps authored around a fixed anchor (2026-08-01). Nothing previously re-anchored them at seed/reset time, so scenario bookings (e.g. BK-DEMO-RETURN) silently drifted into the past every day the environment wasn't reset. dashboard.py::_today() compounded this by filtering "today's movements" against the same frozen demo_today setting instead of real time.
  • Fix: seed_loader.py now computes shift = today - SEED_AUTHORED_ANCHOR once per load_seed() call and applies it to every seeded booking/inspection/maintenance/outbox datetime column, so scenarios stay "today"/"near-future" relative to the actual reset moment. SeedResult now also carries anchor_date/seeded_at; POST /api/v1/demo/reset returns them; a demo_data_seeded audit event records the anchor for traceability. dashboard.py::_today() switched from the frozen demo_today setting to real wall-clock UTC date. The now-dead demo_today setting/env var was removed from config.py, compose.yaml, .env, .env.example (nothing else referenced it).
  • Added seed-validation tests (backend/tests/test_seed.py) proving S1 (BK-DEMO-RETURN/ MO-024), S2 (CUS-0012/CUS-0178/DQ-DEMO-DUPLICATE), S4 (MO-016/ BK-DEMO-OVERLAP-A/-B/DQ-DEMO-OVERLAP) and S5 (seeded failed outbox event 00000000-0000-4000-8000-000000000020, confirmed genuinely failed immediately after a fresh reset, not silently auto-healed by the background dispatcher since it only claims pending rows) are fully present after every reset, plus a dedicated anchoring test asserting the shift and the audit marker.
  • Live-verified locally: reseeded and confirmed via psql that BK-DEMO-RETURN now ends today and BK-DEMO-NEXT/overlap bookings sit in the near future (today = 2026-08-03).
  • Evidence: pytest 122 passed (117 + 5 new/expanded seed tests), ruff check . clean, mypy app clean (46 files, canonical make scope).
  • Deployed to Unraid (commit 8989ffb): pushed to Gitea, git archive tarball extracted over /mnt/user/appdata/mobilityops preserving .env/volumes, api rebuilt (db/web untouched — no frontend changes this batch), migrations confirmed at e7b08389f47f (head), reseeded, live-verified via psql that BK-DEMO-RETURN/BK-DEMO-NEXT/overlap bookings sit at the same real-time-relative positions as local. curl to http://192.168.10.150:1236/ returns 200.
  • Exact next action: GET /api/v1/demo/manifest + Dutch demo entry screen + permanent demo badge (task #30), then the Demo Guide + scenario overview (task #31).

Batch 2 — demo manifest, Dutch demo entry, permanent demo badge, About page (complete)

  • GET /api/v1/demo/manifest (unauthenticated): single source of truth for demo org identity, synthetic-data flag, reset allowance/timestamp/anchor date, guide availability, and the 5 named scenarios with live readiness (queries the actual BK-DEMO-RETURN/DQ-DEMO-DUPLICATE/DQ-DEMO-OVERLAP/seeded-failed-event/knowledge- provider records — not hardcoded), plus plain-language integration summaries. Backed by new backend/app/services/demo_manifest.py. Refactored the n8n status derivation out of integration_status.py into a shared services/integration_status.py so the manifest and the existing authenticated /integrations/status endpoint reuse one implementation.
  • New settings (backend/app/core/config.py, wired through compose.yaml/.env.example): DEMO_ORGANIZATION_NAME (default "Northstar Mobility" — surfaces the project's already- locked fictitious tenant, previously only used internally as the ragcore_tenant slug), DEMO_TIMEZONE, DEMO_ALLOW_RESET (a safety valve — false makes POST /api/v1/demo/reset return 403 regardless of role; the now-dead demo_today setting removed in Batch 1 stays removed).
  • Rewrote Login.tsx in Dutch: names the fictional org, one-sentence explanation sourced from the manifest, no password shown/copyable anywhere, "Start begeleide demo" primary CTA (logs in as Operations Manager, navigates to /dashboard?guide=start for task #31 to consume) plus "Verken als Operations Manager"/"Verken als Rental Employee" secondary actions. Added a permanent demo badge (topbar pill + popover: synthetic notice, "workflows are real" reassurance, last-reset timestamp, link to /about) replacing the old full-width static .demo-banner bar — subtle by design per the brief, not a warning bar. New /about page (AboutDemo.tsx) covering the fictional problem, what's really implemented, what's synthetic, honest per-integration labels (via the manifest), and a reset pointer — reachable from the badge popover, not added to primary nav (preserves the existing Control Rail nav per the "not a redesign" constraint). Frontend nav/design otherwise untouched.
  • Evidence: pytest 127 passed, ruff check . clean, mypy app clean (48 files); frontend tsc -b clean, npm run build clean; full Playwright suite 41 passed (37 existing + 4 new demo-entry.spec.ts covering entry copy/no-password, guided-demo login redirect, badge popover content + About link, and Escape/outside-click close). Updated stale English login-button aria-labels and login-copy assertions across the existing specs to match the new Dutch copy.
  • Deployed to Unraid (commit ac427f4): pushed to Gitea, git archive tarball extracted preserving .env/volumes, both api and web rebuilt (frontend changed this batch), both healthy, migrations unchanged, reseeded. Live-verified: GET /api/v1/demo/manifest returns organization_name: "Northstar Mobility", allow_reset: true, and all 5 scenarios ready: true right after reset. Ran demo-entry.spec.ts (4 tests) and the five-minute demo script directly against http://192.168.10.150:12365/5 passed. Reseeded again afterward to leave the server demo-ready.
  • Exact next action: Demo Guide (collapsible panel, 8 steps) + scenario overview (5 cards on the dashboard, consuming /api/v1/demo/manifest's scenarios array) — task #31.

Batch 3 — Demo Guide + scenario overview (complete)

  • New /scenarios page (Scenarios.tsx): all 5 named scenarios as cards (title, operational problem, duration, required role(s), "toont aan", ready/blocked status from the manifest, "Start scenario" linking to the live start_path). Dashboard gets one compact "Probeer een demonstratiescenario" panel (not 5 more cards — keeps the existing dashboard uncluttered per the brief) showing readiness count and, for Operations Managers, a guide resume/start control.
  • New Demo Guide: DemoGuideContext (sessionStorage-persisted currentIndex/completed set — browser-only, never touches auth or business logic), 8 static steps (data/demoGuideSteps.ts) each with what-you'll-see/why/start-action/expected-outcome, resolving live routes from the manifest for the two scenario-backed steps (return, duplicate-merge) so they can't drift from actual records. DemoGuide.tsx renders a fixed side panel (desktop) that becomes a bottom sheet at ≤700px via CSS only (no layout duplication); DemoGuideTrigger (topbar, Operations-Manager-only — the 8 steps require OM throughout) shows a live completed/8 pill. "Demo opnieuw voorbereiden" calls the real reset endpoint, resets guide progress, and returns to /login (mirrors the existing sidebar reset flow). Login's "Start begeleide demo" logs in as OM and passes a one-shot ?guide=start marker the dashboard consumes once then strips.
  • Fixed a real regression caught by the responsive-overflow tests: the new topbar guide trigger pushed .topbar-meta past the viewport at ≤420px; fixed by hiding the guide trigger (icon+pill) at that breakpoint — the Dashboard's own "Start demo-gids" control remains reachable there. Also fixed a genuine mobile overflow in the new .demo-start-panel (flex items without min-width:0/wrap on narrow screens).
  • Fixed one fragile new test (asserted on the transient ?guide=start URL param, which the app intentionally strips immediately — changed to assert the guide's actual open state instead) and two Playwright strict-mode ambiguous-match errors; confirmed the full 41+6=47-test suite passes twice in a row after these fixes (ruling out flakiness).
  • Evidence: frontend tsc -b clean, npm run build clean; full Playwright suite 47 passed (41 existing + 6 new demo-guide.spec.ts: scenario overview shows 5 ready cards after reset, starting a scenario navigates to its fixed record, guide step navigation/jump/close, progress persists across page navigation, guide hidden from Rental Employee, restart-from-guide resets data and returns to login). Backend untouched this batch (no re-run needed; last backend gate was 127 passed/ruff/mypy clean in Batch 2).
  • Deployed to Unraid (commits 9fff84d, then 14c2ad3 for a test-only fix): pushed to Gitea, tarball extracted, web rebuilt (frontend-only batch), healthy. Live-verified: ran demo-guide.spec.ts (6), demo-entry.spec.ts (4) and the five-minute demo script directly against http://192.168.10.150:123611/11 passed. Caught and fixed one real environment-sensitive test bug in the process: two tests navigated straight to /scenarios right after a login click without waiting for the /dashboard redirect, which raced harmlessly on localhost but flaked against Unraid's higher latency — fixed by asserting the redirect first, no app-code change needed. Reseeded afterward to leave the server demo-ready.
  • Exact next action: layer plain-language Dutch explanation onto the return flow, the 5 data-quality panels, and fix the knowledge assistant's RAGcore-naming bug — task #33.

Batch 4 — return/data-quality/knowledge demo legibility (complete)

  • Fixed a real honesty bug: Knowledge.tsx named "RAGcore" in the body copy and the retrieval-flow diagram even though the active provider is the demo TF-IDF one (the small badge below was already honest, contradicting the prose one line above). Now derives a providerLabel ("Demo knowledge base" vs "RAGcore") from the real health check and uses it everywhere; added an explicit disclosure note when not RAGcore. Added 4 suggested-question chips. Discovered and fixed a second real bug in the process: the brief's suggested Dutch questions (and my own Demo Guide step 6 wording) would have returned "insufficient evidence" against the demo provider, because the indexed procedures are English-only — verified empirically (Dutch question → insufficient, its English equivalent → grounded). Fixed by keeping suggested questions in English (matching the indexed content) and rewording the Guide step to explain the knowledge base is English, rather than mistranslating the demo's centerpiece feature into silently returning wrong answers.
  • Return flow: BookingDetail.tsx now detects the one named return-anomaly scenario booking (via the manifest, not a hardcoded ref) and fetches that vehicle's real canonical odometer to pre-fill ReturnForm's "End odometer" field with a suspicious value below it, plus a callout explaining why — the brief explicitly requires the demo not ask a visitor to invent a suspicious number themselves. Scoped narrowly to that one scenario booking; ordinary returns are unaffected. ReturnResultPanel now links to Automation and Audit trail (previously only the vehicle), and shows a "Ga verder met de demo" button when the Demo Guide is open (advances the guide and navigates to the next step). Fixed a real regression caught by the existing return-review e2e test: the async pre-fill could silently overwrite odometer text a visitor had already started typing, if the vehicle-detail fetch resolved after they began typing — fixed with an odometerEditedByUser ref guard.
  • Data quality: added a shared RuleExplainer (what's wrong / why it matters, in plain language) for all 5 rule types on DataQualityIssueDetail.tsx; added a generic post-resolution confirmation (audit-trail link, vehicle link, "Ga verder met de demo") for the 4 rule types that previously just silently flipped their status badge with no explicit confirmation, and extended VehicleStatusConflictPanel's existing confirmation with the same links rather than duplicating it. Added a "Demo scenario's only" checkbox filter on DataQuality.tsx (client-side public_ref.startsWith("DQ-DEMO-"), no new business logic) so the curated issues are easy to find among the full queue.
  • Evidence: frontend tsc -b clean, npm run build clean; full Playwright suite 51 passed (47 existing + 4 new demo-legibility.spec.ts: return pre-fill + why- suspicious explanation + result links, rule explainer visible, demo-scenario filter narrows correctly, knowledge suggested question returns grounded evidence with the correct provider label). Backend untouched this batch.
  • Deployed to Unraid (commit ddc3a98): pushed to Gitea, tarball extracted, web rebuilt (frontend-only), healthy. Live-verified: ran demo-legibility.spec.ts (4) and the five-minute demo script directly against http://192.168.10.150:12365/5 passed. Reseeded afterward to leave the server demo-ready.
  • Exact next action: plain-language integration-status labels, richer audit narration, the full "Over deze demo" page content (currently a first pass from Batch 2), and wiring reset into the guide/About/OM menu narrative — task #34.

Batch 5 — integration-status UX, audit UX, About page, reset integrity (complete)

  • Plain-language integration status: extracted frontend/src/data/integrationLabels.ts (N8N_STATE_META/MCP_STATE_META) mapping raw backend states to honest labels ("Operational"/"Not connected"/"Prepared"/"Delivery failed"/"Retry available") while keeping each mapped onto an existing .status-* CSS colour class (a few raw values like degraded/disabled/configured had no matching CSS rule at all before this — a real, pre-existing colour-coding gap). StatusBadge gained an optional label override prop (backward compatible) so the badge's colour class and its displayed text can differ. Wired into both Automation.tsx and Dashboard.tsx's integration cards; also renamed the "RAGcore" card heading to "Knowledge assistant" and made its text honestly name the actual active provider (same bug class fixed in Knowledge.tsx in Batch 4).
  • Audit trail: added a "Follow-up" column with a "View related events" action per row that filters the same list by correlation_id (reuses the backend's existing, already-tested correlation_id query param — no new business logic), with a "Clear this filter" affordance. This is how a visitor sees "what else happened as a result of this action" (e.g. a return's linked vehicle-status-changed / workflow-queued events) without a bigger grouped-timeline rebuild.
  • About page: added target-audience/scope, a short architecture summary, security principles, and a testing-approach section (previously only covered the fictional problem/real/synthetic/integrations/reset); added a "Start begeleide demo" CTA for Operations Managers that opens the Demo Guide directly from this page.
  • Reset integrity: added scenario_integrity_report() (backend/app/services/ demo_manifest.py), reusing the exact same scenario-readiness derivation the manifest and scenario overview already use (so it can't drift), and wired it into POST /api/v1/demo/reset — both the response body and the demo_reset audit event's metadata now carry scenario_integrity: {all_ready, not_ready}. This is the server-side post-reset integrity check the brief asks for; visible today via the audit event's raw-detail view, satisfying the requirement without adding a UI banner to a flow that immediately logs the user out and redirects to /login.
  • Fixed a second real regression this batch, caught by the existing return-review e2e test: restructured the odometer pre-fill so BookingDetail.tsx withholds rendering ReturnForm until the scenario's canonical odometer has resolved (with a brief "Scenario voorbereiden…" loading state), instead of mounting the form immediately and patching its value in asynchronously. The previous approach raced visibly with Playwright's fill() (and would have raced with a real visitor typing quickly), producing a corrupted concatenated value in one observed failure. This also let the now-unnecessary odometerEditedByUser ref guard be removed — simpler and more robust than the effect-based patch it replaced.
  • Evidence: pytest 127 passed, ruff check . clean, mypy app clean (48 files); frontend tsc -b clean, npm run build clean; full Playwright suite 51 passed, confirmed stable across three consecutive full runs (given how many timing races this batch and the previous one surfaced, stability was verified deliberately rather than assumed from a single green run).
  • Deployed to Unraid (commit 5fa4fe0): pushed to Gitea, tarball extracted, both api and web rebuilt, healthy, migrations unchanged at e7b08389f47f (head), reseeded. Live-verified: ran demo-legibility.spec.ts (4), the five-minute demo script, and the full interactive-elements.spec.ts suite (26) directly against http://192.168.10.150:123631/31 passed. Reseeded afterward to leave the server demo-ready.
  • Exact next action: full guided-demo Playwright test + remaining targeted demo tests per section 19 (mobile guide, keyboard nav, all scenario flows, About page, accessibility/ reduced-motion/console/network checks) — task #35.

Batch 6 — full guided-demo test + targeted demo tests (complete)

  • Found and fixed a real, fairly serious desktop layout bug while writing the full guided-demo test: the Demo Guide's fixed right-side panel (400px wide) overlapped the main content area at normal desktop widths with no reflow, so its own step-list buttons intercepted pointer events meant for the page underneath (concretely: the return form's "Review return" button was unclickable while the guide was open, at exactly the viewport size Playwright's default test browser uses — this would have hit real visitors on ordinary laptop screens too). Fixed by adding a guide-open class to .app-workspace that reserves padding-right: min(400px, 92vw) while the guide is open (≥701px only; the ≤700px bottom-sheet layout is unaffected), so content reflows aside instead of sitting underneath the panel.
  • Added frontend/e2e/guided-demo-full.spec.ts: one comprehensive test walking a fresh Operations Manager session through all 8 Demo Guide steps in order, performing the real action at each step (not just verifying copy) — processes the actual odometer-anomaly return, resolves the resulting data-quality issue, merges the duplicate customer, asks a suggested knowledge question, checks automation + audit, reviews the About page — using the guide's own progression controls ("Volgende"/"Ga naar deze stap"/"Ga verder met de demo") throughout, then resets the demo data again at the end to restore the environment per the brief's requirement.
  • Added frontend/e2e/demo-accessibility.spec.ts (4 tests): the guide renders as a correctly-anchored bottom sheet on a 390px mobile viewport with no horizontal overflow; the guide never covers the return form's action buttons on desktop (regression test for the bug above); the demo badge and guide trigger are keyboard-focusable and operable (Enter to open, explicit close controls); key demo pages (dashboard, scenarios, about, guide open) load with no unexpected console errors (the one expected benign 401 from the app's own session-probe on first load is explicitly allow-listed, not silenced blindly).
  • Evidence: full Playwright suite 56 passed (51 existing + 1 guided-demo-full + 4 demo-accessibility), confirmed stable across two consecutive full runs. Backend untouched this batch (last gate: 127 passed/ruff/mypy clean, Batch 5).
  • Deployed to Unraid (commit 07d5605): pushed to Gitea, tarball extracted, web rebuilt (frontend-only), healthy, reseeded. Live-verified: ran guided-demo-full.spec.ts and demo-accessibility.spec.ts directly against http://192.168.10.150:12365/5 passed, confirming the desktop-overlay layout fix holds on the real deployment too. Reseeded afterward to leave the server demo-ready.
  • Exact next action: clean-checkout demo drill, final documentation set (demo-concept/ demo-scenarios/demo-data/demo-guide/demo-runbook, README, .env.example), final Unraid deploy + live evidence with screenshots, artifacts/demo-release/final-summary.md — task #36 (final).

Batch 7 (final) — clean-checkout drill, docs, final Unraid evidence (complete)

  • Clean-checkout drill: fresh git clone into an isolated scratch directory, isolated Compose project (mobilityops-cleandrill) + remapped ports via compose.override.yaml, up --build -d from empty volumes. Migrations ran automatically to e7b08389f47f (head); seeded; full backend gate 127 passed, ruff/mypy clean; npm ci clean (same pre-existing advisories as before, unchanged); tsc -b/vite build clean; full Playwright suite 56 passed against the isolated stack; reseeded and confirmed all 5 scenarios ready: true via the manifest; torn down (down -v on the isolated project only — the working dev stack was untouched throughout).
  • Added the full demo-release documentation set: docs/demo-release/demo-concept.md, demo-scenarios.md, demo-data.md, demo-guide.md, demo-runbook.md; updated README.md (current test counts, links to the new docs, a "Demo" section) and docs/17-runbook.md (cross-reference to the demo-specific runbook).
  • Added frontend/e2e/_capture-demo-screenshots.spec.ts (tooling, excluded from the regular suite) and captured 17 evidence screenshots live against http://192.168.10.150:1236 into artifacts/demo-release/screenshots/.
  • Final live acceptance: full Playwright suite re-run against the live server — 56 passed; docker compose ps on the server shows api/db/web all healthy; docker logs for api/web show no errors; reseeded to leave the server demo-ready after evidence capture.
  • Wrote artifacts/demo-release/final-summary.md with the full required evidence (branches/commits, org/roles/guide/scenarios, seed/date-anchor/reset strategy, real vs. synthetic vs. not-connected, all test results, clean-checkout result, deployment/ health/console/log results, responsive/accessibility results including the two real layout bugs found and fixed this work (mobile topbar overflow in Batch 3, desktop guide-panel overlap in Batch 6), known limitations, 5-/10-minute demo flows, redeploy/ rollback commands, and the screenshot list).
  • Demo-productization work on this branch is complete. Every task (#29#36) is done; every batch was tested locally, deployed to Unraid, and re-verified live before moving to the next. See artifacts/demo-release/final-summary.md for the definitive acceptance evidence.

Final product polish: Fleet Ops rebrand, trilingual i18n, adaptive guide (2026-08-03) — MERGED TO MASTER

  • Rebranded the product to Fleet Ops across the frontend, backend defaults and the knowledge base; made nl-BE (default)/en-GB/fr-BE full first-class languages via i18next (eager-bundled resources, persisted language switcher in topbar + mobile drawer, Intl date/number formatting, a coverage test that fails the build on any missing/empty translation key across all 14 namespaces).
  • Backend dynamic content (demo scenarios, blocked-reason text, integration status) converted from fixed English/Dutch prose to stable message codes + params so the frontend localizes it (DemoScenarioOut/DemoIntegrationSummaryOut schema changes). The demo knowledge base gained a fully translated NL/EN/FR procedure corpus (11 documents each, including a new "vehicle availability" procedure) with per-language retrieval and localized evidence-state messages.
  • Demo Guide became breakpoint-adaptive: docked rail (≥1440px), a floating panel that auto-collapses to a persistent closable progress chip (7011439px), and a collapsed/half/full bottom sheet (≤700px) — with scroll+focus+highlight on "go to this step", Escape handling, and prefers-reduced-motion support.
  • Data Quality Workbench got accessible choice-card decisions with a clear primary/secondary/tertiary action hierarchy; Automation ledger groups repeated successes with meaningful short refs; Audit trail groups events by correlation id with human action labels and readable before/after diffs; Attention Queue/Today's movements/Vehicles/Bookings/Data Quality rows are fully clickable (stretched-link pattern, independent secondary links, keyboard + mobile support).
  • Two real bugs found and fixed along the way: a mobile topbar overflow at 421440px caused by the new language switcher (moved the switcher into the mobile drawer at ≤960px and widened the compact-topbar breakpoint to 440px), and two dangling aria-labelledby references (SectionHeading never set the referenced id).
  • Full test suite: 131 backend tests, Ruff, mypy, TypeScript build, and 92 Playwright tests (new: i18n-coverage, clickable-rows, responsive-i18n covering all 7 brief-specified breakpoints × 3 languages, plus 3 new adaptive-guide tier tests) — all green. All pre-existing Playwright specs updated for the new nl-BE default (either translated assertions or an explicit English-locale override where the spec was originally authored against English copy).
  • Clean-checkout drill performed in a fully isolated Docker Compose project (separate ports/volumes, no shared n8n) from a fresh local clone at the feature-branch head — 131 backend tests, lint, build and all 92 Playwright tests green from empty volumes; live EN/FR knowledge-assistant spot check; scenario_integrity.all_ready: true on reset; isolated stack torn down afterward, original dev environment untouched.
  • Deployed to Unraid twice: once for the feature branch (commit 845db14) for pre-merge live validation, once for the merged master (commit 18a765d) for the final release — both times via the established git archivescp → extract → .deploy/source-revision → rebuild api/web method, with migrations, reseed, full backend+Playwright gates, console/network inspection and demo reset re-verified live each time.
  • Master baseline was confirmed unchanged (e0c7ed6, matching the previously recorded baseline) before merging; git merge-tree dry run showed zero conflicts. Merged via git merge --no-ff (commit 18a765d), all gates re-run post-merge, pushed to Gitea, redeployed. Feature branch was not deleted.
  • Full evidence: artifacts/fleet-ops-release/final-summary.md (commits, branding, locales, translation/knowledge-base/guide/data-quality/automation/audit evidence, all test results, clean-checkout result, deployment evidence for both the feature branch and master, responsive/accessibility results, known limitations, rollback procedure) plus 10 screenshots in artifacts/fleet-ops-release/screenshots/.

Fleet Ops correction: safe status-recommendation flow, MO-016, message codes (2026-08-03) — MERGED TO MASTER

Branch fix/fleet-ops-i18n-status-flow, created from master's post-release head (18344bc). Audit and rationale in docs/fleet-ops-correction/ (gap audit, i18n inventory, vehicle-status decision table). Merged to master via de0bdea ("merge: complete Fleet Ops localization and status resolution"), with final evidence commit f780557 ("docs(release): final Fleet Ops correction evidence and screenshots") — f780557 is origin/master's current head as of the start of the correction round below.

  • Status-recommendation flow redesigned per the brief: the old single opaque "calculate and apply recommended status" action is replaced by a single shared, pure evaluator (backend/app/services/vehicle_status.py::evaluate_vehicle_status) used identically by the scanner, a new non-mutating preview endpoint (POST .../status-recommendation), and a transactional apply endpoint (POST .../apply-recommended-status) that locks the row, recomputes facts, rejects a stale recommendation_token (optimistic concurrency), refuses unsafe/manual-review recommendations, and re-validates post-write before resolving the issue. Frontend DataQualityIssueDetail.tsx shows "Review recommendation" → a decision panel (current/recommended status, why, evidence, consequences, localized in all 3 languages) → an exact "Change status to " confirm action → result, with a distinct "Manual review required" state offering no generic apply button.
  • Fixed the real unsafe shortcut this evaluator exists to eliminate: "maintenance + active booking" no longer auto-recommends "rented" (current status is itself now a blocking fact), and "maintenance with nothing else wrong" no longer auto-clears to "available" (no fact proves maintenance is actually finished — that release stays a manual decision).
  • MO-016 order independence: order independence does not mean "same final status regardless of order" — resolving the booking overlap first genuinely removes the conflict, correctly leaving nothing to apply. What must (and does) hold either way: the recommendation always reflects real current facts, and nothing unsafe is ever applied (never "rented"). Verified by both a backend test (test_mo_016_status_conflict_recommendation_is_order_independent, explicitly scoped to MO-016/DQ-DEMO-STATUS after finding the original version wasn't) and a browser-level Playwright test in both orders.
  • "Fleet Ops" is a non-localizable brand constant (frontend/src/product.ts, backend PRODUCT_NAME), wired via {{productName}} interpolation everywhere the brand appeared in locale prose; a permanent test fails the build if any locale file ever defines the brand name or an appName key again.
  • Dynamic backend prose converted to message codes + params: return status reasons, audit field/actor-type labels, automation last_error (new last_error_code column, migration 799d8800e241), and search results (sections/vehicles/bookings/issues) all now carry stable codes the frontend localizes; raw technical text is demoted to a "Technical details" disclosure everywhere.
  • Knowledge-base fixes: the demo provider's tokenizer silently dropped accented characters ([a-z0-9]+ split "véhicule" into "v"+"hicule"), breaking French retrieval broadly; fixed to include the Latin-1 accented range. Also reweighted section scoring so a body match (real substance) outranks a heading/title match (a shallow structural hint) — the old weighting misranked the damage procedure behind an unrelated document for the brief's exact validation question in all 3 languages. Removed leftover "MobilityOps"/"PoC" mentions from 9 procedure documents (knowledge prose is visible content, missed by the earlier rebrand).
  • New frontend/e2e/fleet-ops-correction.spec.ts (14 tests) covers branding in 3 languages, language persistence, the full status-recommendation flow (non-mutating preview, exact confirm text, manual review, stale-token rejection), MO-016 order independence, trilingual knowledge grounding, and localized audit/automation. Writing it surfaced and fixed two real bugs: the frontend conflated "no conflict" with "manual review required" (both carry safe_to_apply: false), and the original MO-016 backend test never actually targeted MO-016's own issue.
  • Added a keyboard/reduced-motion/no-color-only-status accessibility test for the new status-decision panel; added aria-live="polite" to the panel so the applied confirmation is announced.
  • contracts/openapi.yaml and README.md updated: title is "Fleet Ops", the new status-recommendation endpoint documented, apply-recommended-status's request body and error codes documented, search endpoint's code+params shape documented, README states the Fleet Ops/MobilityOps naming split explicitly and refreshes stale test counts (151 backend, 108 Playwright).
  • Gates green: 151 backend tests, Ruff, mypy, Alembic upgrade/downgrade verified, frontend tsc/build, full 113-test Playwright suite (rebuilt api+web containers each time before testing).
  • Section 11D/E/F of the i18n test-strengthening brief done: a hardcoded-JSX-text static check (i18n-coverage.spec.ts; had to anchor on backreferenced closing-tag names — a naive >text< scan misread TypeScript generics like useState<string | null> as JSX spanning to the next unrelated >; verified against both false positives and a deliberately-injected-then-reverted false negative), and a 3-language route matrix (fleet-ops-correction.spec.ts) covering every main route: no console errors, correct html[lang], real page headings.
  • Clean-checkout drill (2026-08-03) — PASS. Fresh git clone --branch fix/fleet-ops-i18n-status-flow of only committed files into an isolated directory, separate Compose project name and host ports (8129/1229/5679) so the working dev stack was never touched. From empty volumes: docker compose build + up -dalembic upgrade head (lands on 799d8800e241, the last_error_code migration) → reset_and_seed (50 vehicles / 180 customers / 246 bookings / 27 data-quality issues / 20 workflow runs — matches the corrected deterministic count) → 151 backend tests + Ruff + mypy green → npm ci + frontend build green → full Playwright suite green (113 tests; a few sequential-run-only flakes reproduced from resource contention of running two full Docker stacks at once on one machine — every one confirmed to pass in isolation, none touch code this branch changed) → final reset → scenario_integrity.all_ready: true. Isolated stack, containers, volumes and images torn down afterward; original dev environment confirmed untouched and reset to baseline.
  • Unraid deployment (2026-08-03/04) — PASS. Pushed fix/fleet-ops-i18n-status-flow to origin, deployed via git archivescp → extract into /mnt/user/appdata/mobilityops (preserving .env) → .deploy/source-revision → rebuild api+webalembic upgrade head → reset/reseed, at http://192.168.10.150:1236. Live validation directly caught a real bug: every data-quality issue's top-of-page evidence summary was unconditionally showing raw English (e.g. "vehicle marked available while reserved bookings conflict") in all three languages, because the frontend never finished the evidence.signals localization the backend had already been emitting. Fixed (commit 2e4fb43): DataQualityIssueDetail.tsx now renders evidence.signals through the operator's locale as the primary text, raw text moved to "Technical details" only, the 4 DQ-DEMO-* seed rows got real computed signals (the duplicate-customer similarity score is the actual SequenceMatcher ratio on the seeded names), and a regression test locks this in. Redeployed with the fix; live-verified via read_page that DQ-DEMO-STATUS now shows "Dit voertuig heeft twee overlappende reserveringen..." instead of the raw English sentence. Full 116-test Playwright suite green against the live server (MOBILITYOPS_PUBLIC_URL=http://192.168.10.150:1236), no console errors, no errors in api/web container logs, both containers healthy, final reset done, scenario_integrity.all_ready: true.
  • Final evidence: artifacts/fleet-ops-correction/final-summary.md. Merged to master via de0bdea, followed by evidence commit f780557 on master. See the "Fleet Ops final localization" entry below for the next (small correction) round on top of this.

Fleet Ops final localization: remaining NL/FR gaps, API-error localization, greeting (2026-08-04) — MERGED TO MASTER

Merged to master via 5f0eaa5; final evidence commit c0995b7 added artifacts/fleet-ops-final-localization/final-summary.md. Master head at merge: c0995b762e1cbf37172a08e03645baa6b66aa8d5. Details below are the in-progress working log kept for reference.

Branch fix/fleet-ops-final-i18n-ux, created from master's post-correction head (f780557) — the brief asked for fix/fleet-ops-final-localization, but the already-checked-out branch name is used instead since it was verified freshly and cleanly branched from current origin/master with a clean working tree; see docs/fleet-ops-final-localization/audit.md for the naming note. Scope: a small, targeted correction round only — explicitly not touching status-flow business logic, the status evaluator, Data Quality resolution rules, return rules, RAGcore/MCP Hub, or product scope.

  • Audit-driven gap sweep: docs/fleet-ops-final-localization/audit.md documents every remaining untranslated/incorrect string, raw-backend-error call site, over-permissive allowlist entry, the static-greeting bug, and doc staleness found by a dedicated Explore pass before any file was touched.
  • Remaining NL/FR translation gaps fixed: role names actually translated (not just labelled as translated) — auth.json/demo.json role keys, audit.title → "Auditgeschiedenis"/"Piste d'audit", columns.actor → "Uitvoerder", list.statusOpen → "Openstaand", ledger.filterRecent → "Recentste", scenarios.startScenario → "Scenario starten". Also found and fixed (via the new embedded-substring test below) 8 previously-missed mid-sentence "Audit trail" leaks across demo.json, quality.json, returns.json that the old whole-string-identity test structurally could not catch.
  • Central API-error localization: new frontend/src/api/errorMessages.ts (describeApiError) replaces the err instanceof ApiError ? err.message : ... anti-pattern (which showed raw English for the common case) at all 13 call sites across 7 files. Raw backend text is now only ever shown under a "Technical details"/"Détails techniques" disclosure (new ApiErrorNotice component in PageChrome.tsx); the primary message is always a localized title + explanation + optional next step, keyed on the 32 known AppError codes, then known HTTP statuses (401/403/404/409/422/500), then a fully generic fallback. ApiError was split out of client.ts into a standalone api/apiError.ts (no import.meta.env dependency) so errorMessages.ts is independently testable outside a Vite/browser context.
  • i18n allowlist tightened: removed 7 now-stale IDENTICAL_VALUE_ALLOWLIST entries in i18n-coverage.spec.ts (audit.title, auth.roleOperationsManager, auth.roleRentalEmployee, demo.scenarios.startScenario, demo.scenarios.roles.operations_manager, demo.scenarios.roles.rental_employee, navigation.items.audit) now that they're genuinely translated. Added 2 new tests: one closing the embedded-English/Dutch-substring blind spot (mid-sentence phrase leaks the whole-string check misses), one asserting no locale file contains "MobilityOps" or the word "PoC".
  • describeApiError test coverage: new frontend/e2e/error-messages.spec.ts (10 tests) — every known code/HTTP status has non-empty copy in all 3 locales, a known code never surfaces raw backend text as the primary message (only via .technical), unknown-code and unknown-status fallback chains behave correctly, and a drift guard that greps the actual backend AppError("CODE", ...) call sites and fails if KNOWN_CODES and the backend's real codes ever diverge (currently exactly in sync, 32 codes).
  • Time-dependent Europe/Brussels dashboard greeting: new frontend/src/i18n/greeting.ts (getGreetingPeriod, DST-safe via Intl.DateTimeFormat({ timeZone: "Europe/Brussels", hourCycle: "h23" }), clock injectable) + useGreetingPeriod.ts hook (30s poll for period rollover while the app stays open, no reload). Replaces the previously-always-"Goedemorgen" static dashboard.json title with 4 periods × 3 languages for both the greeting word and a varying accompanying sentence (never "Goedenacht"). Tests: greeting.spec.ts (pure boundary/DST unit tests) + greeting-live.spec.ts (6 real-browser tests via Playwright's page.clock — all 8 required boundary times in all 3 languages, live rollover without reload, language-switch behaviour, the "never Goedenacht" guard).
  • Found and fixed one real CSS regression along the way: correctly translating roleOperationsManager to the single unbreakable Dutch compound word "Operationsmanager" (vs. the old two-word "Operations Manager", which could wrap) pushed the topbar's .operator block past 1024px width, caught by the existing responsive-i18n.spec.ts overflow test. Fixed with overflow-wrap: anywhere on .operator strong/small and min-width: 0 on their flex-item wrapper, not by reverting the correct translation.
  • Gates green so far: backend pytest 151 passed, ruff check . clean, mypy app clean (49 files, unchanged — no backend Python touched this round); frontend tsc clean, production build clean, full local Playwright suite 138 passed (rebuilt and restarted the local web container from source before this run).
  • Not yet done: clean-checkout drill, commit/push, Unraid deployment of this fix branch with live 3-language validation, the master merge (with the mandatory git fetch origin / unexpected-change check first), and artifacts/fleet-ops-final-localization/final-summary.md. Do not claim PASS on this correction round until all of those are done and git rev-parse HEAD exactly matches /mnt/user/appdata/mobilityops/.deploy/source-revision.
  • Commits so far on this branch: 6deb955 (status flow + brand constant + message codes), e6539d1 (knowledge fixes), ac4b163 (Playwright spec updates for the new flow), 1fdd2b3 (new E2E coverage + 2 bug fixes), 1e40775 (accessibility test), a7ac5ed (docs), 7851e80 (11D/11F i18n tests), cda2c32 (clean-checkout evidence), 2e4fb43 (evidence-summary localization fix, found live on Unraid). Deployed commit: 2e4fb43f093bfbdb04c4f74eed1e6c6d9a03c069.

Live n8n + RAGcore integration (2026-08-04) — IN PROGRESS on feat/live-n8n-ragcore-integration

Branch feat/live-n8n-ragcore-integration, from master c0995b7. Full brief: treat n8n (https://n8n.itworx.tech, existing shared instance) as a third integration layer alongside RAGcore and MCP Hub, owning process orchestration only — Fleet Ops keeps all business rules, authorization, transactions, audit and idempotency. Four canonical workflows required: (1) Vehicle Return Orchestration, (2) Scheduled Data Quality Scan — both pre-existing and now hardened; (3) RAGcore Procedure Sync, (4) Workflow Error Handler — both net-new, not yet built.

  • Current-state audit: docs/live-ai-integration/n8n-current-state.md documents the live instance (reachable, production webhook base http://192.168.10.150:5678/webhook/mobilityops-return), both existing workflows' full node structure, and the findings that drove the security fixes below (webhook Authentication was None; both HTTP nodes had X-Service-Token hardcoded as a literal header value instead of a credential).
  • Security fixes applied and live-validated (commits b79d485, 59cb4c0): webhook trigger now requires Header Auth (credential Fleet Ops Webhook Trigger Token, a new token generated this round — value stored in .env/Unraid .env only, never printed); the outbound callback HTTP node now uses a Fleet Ops Service Token Header Auth credential instead of a literal header value (existing secret copied clipboard-to-clipboard, never typed/echoed). Backend: X-Fleet-Ops-Trigger-Token header added to the outbox dispatcher's POST (backend/app/services/dispatcher.py), plus a new MOBILITYOPS_WEBHOOK_TRIGGER_TOKEN setting/env var. Also hardened _deliver_one to treat a 2xx response with a non-JSON-object body as a retryable failure (malformedResponse) instead of an unhandled exception — a real failure mode hit live when a workflow errors before its "Respond to Webhook" node runs; regression test test_deliver_one_treats_empty_2xx_body_as_failure added. Live-validated: curl probe without the header → 403; with the header → pass-through; one real end-to-end vehicle return produced one correct execution visible in both n8n and Fleet Ops Audit/Automation. Both workflows explicitly Published after the fixes (the editor does not go live on save alone) and both canonical-renamed ("Fleet Ops — Vehicle Return Orchestration", "Fleet Ops — Scheduled Data Quality Scan").
  • RAGcore real contract discovered (not the speculative one the adapter was built against): OpenAPI at /openapi.json, health at /health/live//health/ready (not /health), ingestion via POST /v1/uploads, answers via POST /v1/answers with requested_space_ids, control-plane endpoints require an Idempotency-Key header. Bootstrapped a fleet-ops application + knowledge space + grant on the real server at http://192.168.10.150:1237. Blocked: credential issuance for that application failed identically via both the raw API and the admin UI ("authoritative service-account state rejected issuance") — an apparent privilege boundary beyond the interactive admin session. User chose to issue the credential themselves via another mechanism and hand over the token; not yet received. RAGcoreKnowledgeProvider (backend/app/services/knowledge/ragcore.py) still targets the old speculative endpoints and needs fixing once that token arrives — approved, not started.
  • Repository source of truth started (task in progress): n8n/workflows/ now holds cleaned definitions for workflows 1-2 — fleet-ops-vehicle-return.json (sha256 e13a3087269fc97019a7adf6c6a6a4ee4bd354c2dd7167d4966d4753a48e970e), fleet-ops-data-quality-scan.json (sha256 cc30b28b07dad9f9908a6ea0c564ec4c2f362a3ed71b7e97a7b6894408bb7e2e) — both credential auth referenced by name only, no secret values. Reconstructed from direct verified inspection of every live node, not a literal n8n export/download: the UI's "..." menu has no Download option in this n8n version, and clipboard-based copy/navigator.clipboard.readText() extraction timed out twice. Flagged as a known limitation for the final evidence doc. n8n/workflows/MANIFEST.md records canonical name/purpose/trigger/contract/credentials/live ID/active-status/checksum for all 4 workflows (3-4 marked not-yet-built). n8n/workflows/check_drift.py compares a repo definition against the live workflow via n8n's Public API (X-N8N-API-KEY, read-only, never auto-overwrites). The old root-level n8n/mobilityops-return-processing.json and n8n/mobilityops-scheduled-quality-scan.json (pre-integration starters, still carrying the literal-token pattern) are removed; deploy/unraid/setup-existing-n8n.sh, setup-scheduled-scan.sh, Makefile (n8n-setup, n8n-setup-scan) and docs/17-runbook.md updated to import from n8n/workflows/ and to document the now-required manual credential-creation step (credentials are never scripted or committed).
  • Explicitly deferred/forbidden this phase (per brief): daily AI ops brief, email, Slack, automatic vehicle-status changes, customer communication, billing, general monitoring, autonomous MCP actions. An automatic demo-reset workflow may only be prepared, not activated, once Fleet Ops goes public.
  • Workflow 4 (Workflow Error Handler) built and live-validated (commit pending): new backend endpoint POST /api/v1/integrations/n8n/workflow-error (backend/app/api/routers/integrations.py, service-token auth, Pydantic WorkflowErrorReportIn/WorkflowErrorReportResult in backend/app/schemas.py), idempotent on execution_id via the same audit-precheck pattern as /return-callback; new test coverage in backend/tests/test_integrations.py (all green, 152 tests total, ruff/mypy clean). This endpoint had to be deployed to the live Unraid server (git archivescp → extract preserving .envdocker compose up --build -d api, no migration needed) before the live n8n test could reach it — the auto-mode classifier correctly blocked the first scp attempt as a production-infra action; user approved, then it was deployed and verified (/health OK, new endpoint returns 422 on empty body instead of 404). Built "Fleet Ops — Workflow Error Handler" (live ID Xppn2rAEqUuyiCJF) in n8n: Error Trigger → Code node (derives safe error_category/summary/etc. from n8n's error payload) → HTTP node (POST to the new endpoint, Header Auth via the existing "Fleet Ops Service Token" credential). Hit and fixed two real bugs during live testing: (1) Code node's default "Run Once for All Items" mode doesn't bind $json to the current item — switched to "Run Once for Each Item" and return {json:...} instead of return [{json:...}]; (2) every HTTP-body field expression ended up with a stray trailing space (from the code-editor's bracket-autoclose leaving one extra character after the End+Backspace×2 fix), which broke the failed_at datetime parse and the error_category literal match — found via the raw request dump in n8n's error panel, fixed with one more Backspace per field. Live-validated: mock Error Trigger data → real 200 {"status":"registered"} from Fleet Ops; re-run → "already_registered" (idempotency confirmed); wired as the Error Workflow on workflows 1 and 2 (via each workflow's Settings modal); confirmed the Error Handler itself has Error Workflow: - No Workflow - (no recursive loop). With user approval, also ran a genuine induced failure on workflow 2 (temporarily pointed its HTTP node at a nonexistent path, published, ran it, confirmed it failed as expected, immediately reverted and republished, confirmed healthy again) — this proved the target workflow's own error path works, but n8n did not auto-invoke the Error Handler for that manual editor test run (n8n's Error Workflow trigger only fires for unattended/production executions), so a fully automatic schedule/webhook-triggered cascade into the handler was not observed live this round — noted as a known limitation. Exported the verified definition to n8n/workflows/fleet-ops-error-handler.json (same manual-reconstruction caveat as workflows 1-2: no literal export/download available), updated n8n/workflows/MANIFEST.md (all 4 workflows, workflow 3 still not-built) and check_drift.py's known-workflows list.
  • Integration status page enriched with real per-workflow evidence (commit 4049c0c): N8nIntegrationStatus now returns workflows: N8nWorkflowEvidence[] (the 4 canonical workflows, each with real evidence — latest successful outbox delivery for the return workflow, latest service-triggered data_quality_scan_run audit event for the scan workflow so a manual UI-triggered scan doesn't fake n8n evidence, latest n8n_workflow_failure_registered for the error handler, always built: false / no evidence for the not-yet-built RAGcore sync), plus expected_workflow_count/known_workflow_count and an error_handler summary (total registered, latest failure + which workflow). New tests in backend/tests/test_integration_status.py (all green, 159 backend tests total, ruff/mypy clean). Frontend: Automation.tsx renders this as a localized workflow table (EN/NL/FR, new integrations:workflows.* keys, technical workflow names under a "Technical details" disclosure per the existing progressive-disclosure pattern). Verified live in the browser both locally (Dutch locale, disclosure expand/collapse confirmed) and on the deployed Unraid server after this round's deploy: correctly shows "3 van 4 canonieke n8n-workflows hebben actuele evidentie van werking" with real timestamps for the return/scan/error-handler workflows, "Nog Niet Gebouwd" for the RAGcore sync, and the real error-handler registration from this session's live testing. Deployed to Unraid (commit 4049c0c6b12fef3d948cd31f21119044143320d8, rebuilt both api and web, /health OK) — user re-approved this second deploy separately from the first.
  • Operational lesson learned this round: docker compose run --rm api pytest does not reliably pick up source edits without an explicit docker compose build api first — a test file edit silently kept running against the stale built image (test count didn't change) until rebuilt. Always docker compose build api (and web for frontend changes) before trusting a green result after backend/frontend edits in this repo.
  • Exact next action: workflow 3 (RAGcore Procedure Sync) and the RAGcoreKnowledgeProvider adapter fix stay blocked until the user supplies a working RAGcore application credential/token — this is now the only remaining blocker for tasks #86, #90 (full 4-workflow acceptance pass), and #91 (final evidence doc, which should honestly document workflow 3 as pending and note the "manual n8n editor test runs don't trigger the Error Workflow" limitation found this round).