NuklearRabbitandClaude Sonnet 5
6deb95524d
- Add a single shared, pure vehicle-status evaluator (app/services/vehicle_status.py)
used identically by the data-quality scanner, a new non-mutating status-recommendation
preview endpoint, and a transactional apply endpoint with optimistic-concurrency token
revalidation -- eliminates the old opaque "calculate and apply" action and the unsafe
"maintenance + active booking -> auto rented" shortcut. Frontend
DataQualityIssueDetail.tsx now shows a review/decide/confirm panel with localized
why/evidence/consequence text in nl-BE/en-GB/fr-BE, with an exact "Change status to
<status>" confirm action per the brief.
- Fix MO-016 issue-order dependency: resolving the booking-overlap issue before vs.
after the status-conflict issue now converges on the same final vehicle status,
proven by test_mo_016_status_conflict_recommendation_is_order_independent.
- Make "Fleet Ops" a non-localizable brand constant (frontend/src/product.ts,
backend PRODUCT_NAME) via {{productName}} interpolation everywhere the brand name
appeared in locale prose; add a permanent test guarding against a translation file
ever defining the brand name or an "appName" key again.
- Convert dynamic backend prose to stable message codes + params: return status
reasons, audit field/actor-type labels, automation last_error, and search
section/vehicle/booking/issue results all now carry codes the frontend localizes,
with raw technical text demoted to a "Technical details" disclosure.
- docs/fleet-ops-correction/: gap audit, i18n inventory, and the vehicle-status
decision table documenting the evaluator's rules and safe-status principles.
148 backend tests + Ruff + mypy green; Alembic migration verified upgrade/downgrade;
frontend tsc/build and the i18n-coverage Playwright suite green.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
95 lines
2.5 KiB
Python
95 lines
2.5 KiB
Python
import uuid
|
|
from contextlib import asynccontextmanager
|
|
|
|
from fastapi import FastAPI, HTTPException, Request
|
|
from fastapi.middleware.cors import CORSMiddleware
|
|
from fastapi.responses import JSONResponse
|
|
|
|
from app.api.routers import (
|
|
audit,
|
|
bookings,
|
|
dashboard,
|
|
data_quality,
|
|
demo,
|
|
integration_status,
|
|
integrations,
|
|
knowledge,
|
|
mcp_integrations,
|
|
search,
|
|
vehicles,
|
|
workflows,
|
|
)
|
|
from app.core.config import PRODUCT_NAME, get_settings
|
|
from app.core.errors import AppError, error_body
|
|
from app.services.dispatcher import start_background_dispatcher, stop_background_dispatcher
|
|
|
|
settings = get_settings()
|
|
|
|
|
|
@asynccontextmanager
|
|
async def lifespan(_app: FastAPI):
|
|
start_background_dispatcher()
|
|
yield
|
|
stop_background_dispatcher()
|
|
|
|
|
|
app = FastAPI(title=f"{PRODUCT_NAME} API", version="0.1.0", lifespan=lifespan)
|
|
|
|
app.add_middleware(
|
|
CORSMiddleware,
|
|
allow_origins=[o.strip() for o in settings.cors_allow_origins.split(",")],
|
|
allow_credentials=True,
|
|
allow_methods=["*"],
|
|
allow_headers=["*"],
|
|
)
|
|
|
|
|
|
@app.exception_handler(AppError)
|
|
def handle_app_error(_request: Request, exc: AppError) -> JSONResponse:
|
|
return JSONResponse(
|
|
status_code=exc.status_code,
|
|
content=error_body(exc.code, exc.message, exc.correlation_id, exc.details),
|
|
)
|
|
|
|
|
|
@app.exception_handler(HTTPException)
|
|
def handle_http_exception(_request: Request, exc: HTTPException) -> JSONResponse:
|
|
return JSONResponse(
|
|
status_code=exc.status_code,
|
|
content=error_body(
|
|
code=str(exc.status_code),
|
|
message=str(exc.detail),
|
|
correlation_id=str(uuid.uuid4()),
|
|
details={},
|
|
),
|
|
)
|
|
|
|
|
|
@app.get("/health")
|
|
def health() -> dict[str, str]:
|
|
return {"status": "ok", "service": "mobilityops-api"}
|
|
|
|
|
|
@app.get("/api/v1/system/status")
|
|
def system_status() -> dict[str, object]:
|
|
return {
|
|
"service": "mobilityops-api",
|
|
"environment": settings.mobilityops_env,
|
|
"demo_mode": settings.mobilityops_demo_mode,
|
|
"knowledge_provider": settings.knowledge_provider,
|
|
}
|
|
|
|
|
|
app.include_router(demo.router)
|
|
app.include_router(dashboard.router)
|
|
app.include_router(vehicles.router)
|
|
app.include_router(bookings.router)
|
|
app.include_router(audit.router)
|
|
app.include_router(data_quality.router)
|
|
app.include_router(workflows.router)
|
|
app.include_router(integrations.router)
|
|
app.include_router(knowledge.router)
|
|
app.include_router(mcp_integrations.router)
|
|
app.include_router(search.router)
|
|
app.include_router(integration_status.router)
|