JensandClaude Opus 5
39c12822bc
MapWorkspace.tsx opened with ~590 lines of theme catalogue, dataset matching and label formatting above a 3.200-line component. None of it is React, all of it is independently testable, and both render paths read from it, so it belongs beside the pure helpers that already live in mapWorkspaceUtils. The contract tests that read MapWorkspace.tsx would have gone red for a move that changes no behaviour at all — 24 of them. That is the brittleness the frontend_contract helper exists to remove, so it gains read_map_workspace(): the workspace is one feature spread over several modules, and a contract belongs to the feature rather than to whichever file currently holds it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
51 lines
2.0 KiB
Python
51 lines
2.0 KiB
Python
from __future__ import annotations
|
|
|
|
import json
|
|
from pathlib import Path
|
|
from tests.frontend_contract import read_map_workspace
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_rc9_ux_audit_is_wired_into_frontend_and_readiness() -> None:
|
|
package = json.loads((ROOT / "frontend" / "package.json").read_text(encoding="utf-8"))
|
|
readiness = (ROOT / "scripts" / "run_readiness_check.sh").read_text(encoding="utf-8")
|
|
wrapper = ROOT / "scripts" / "run_rc9_ux_audit.sh"
|
|
|
|
assert package["scripts"]["test:e2e:ux"] == "node e2e/uxAudit.mjs"
|
|
assert '"${NODE_BIN}" --check frontend/e2e/uxAudit.mjs' in readiness
|
|
assert "bash -n scripts/run_rc9_ux_audit.sh" in readiness
|
|
assert wrapper.is_file()
|
|
|
|
|
|
def test_rc9_loading_and_accessibility_states_are_explicit() -> None:
|
|
app = (ROOT / "frontend" / "src" / "App.tsx").read_text(encoding="utf-8")
|
|
map_workspace = read_map_workspace()
|
|
geo_map = (ROOT / "frontend" / "src" / "components" / "GeoMap.tsx").read_text(
|
|
encoding="utf-8"
|
|
)
|
|
|
|
assert "workspaceDataLoading" in app
|
|
assert 'role="status" aria-live="polite"' in app
|
|
assert "Databronnen worden gecontroleerd" in map_workspace
|
|
# Copy changes; the requirement is that source availability is stated.
|
|
assert "availabilityLabel" in map_workspace
|
|
assert "aria-busy={workspaceLoading}" in map_workspace
|
|
assert "handleAnalysisModeKeyDown" in map_workspace
|
|
assert 'aria-label="Interactieve kaart.' in geo_map
|
|
|
|
|
|
def test_rc9_performance_budgets_are_documented_and_visible() -> None:
|
|
budget = (
|
|
ROOT / "frontend" / "src" / "lib" / "performanceBudget.ts"
|
|
).read_text(encoding="utf-8")
|
|
docs = (ROOT / "docs" / "UX_PERFORMANCE_BUDGETS.md").read_text(encoding="utf-8")
|
|
map_workspace = read_map_workspace()
|
|
|
|
assert "COVERAGE_RESPONSE_BUDGET_MS = 4_000" in budget
|
|
assert "MAP_ANALYSIS_BUDGET_MS = 15_000" in budget
|
|
assert "4 seconds" in docs
|
|
assert "15 seconds" in docs
|
|
assert "overschrijdt het releasebudget" in map_workspace
|