JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
74 lines
3.3 KiB
Python
74 lines
3.3 KiB
Python
from pathlib import Path
|
|
from tests.frontend_contract import assert_calls, assert_mentions, assert_wired, read_map_workspace, read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def read(path: str) -> str:
|
|
return (ROOT / path).read_text(encoding="utf-8")
|
|
|
|
|
|
def test_flanders_workspace_exposes_governed_thematic_products_on_demand() -> None:
|
|
workspace = read_map_workspace()
|
|
product_hook = read_feature("map_workspace")
|
|
selection_hook = read_feature("map_workspace")
|
|
api = read_feature("datasets")
|
|
|
|
assert "activeScopeProject?.name === FLANDERS_WORKSPACE_PROJECT_NAME" in workspace
|
|
assert "new Map<DataThemeId, OnDemandMapProduct>" in workspace
|
|
assert_wired(workspace, "space_occupation")
|
|
assert "setActiveThemeId(fallbackTheme.id)" in workspace
|
|
assert "return `referentiejaar ${observationYear}`" in workspace
|
|
assert "kind: 'thematic_raster'" in workspace
|
|
assert "productKey: onDemandProduct.productKey" in workspace
|
|
assert "datasetsApi.listThematicRasterProducts" in product_hook
|
|
assert "datasetsApi.acquireThematicRaster" in selection_hook
|
|
assert "datasetsApi.selectThematicRaster" in selection_hook
|
|
assert "datasetsApi.get(selectedProjectId, acquisitionJob.output_dataset_id)" in selection_hook
|
|
assert "/datasets/thematic-raster/acquire" in api
|
|
|
|
|
|
def test_selection_reads_and_bounded_acquires_all_relevant_themes() -> None:
|
|
workspace = read_map_workspace()
|
|
app = read_feature("shell")
|
|
selection_hook = read_feature("map_workspace")
|
|
|
|
# Selection reads the active theme; the loop form is incidental.
|
|
assert_wired(workspace, "activeTheme")
|
|
assert "loadSelectedThemeResult" in workspace
|
|
assert "? onDemandProductsForZones(resolvedZones)" in workspace
|
|
assert ".filter((product) => product.theme === activeThemeId)" not in workspace
|
|
assert "await loadThemeInsights(bbox, availableThemes, areaId)" in workspace
|
|
assert "!regionalPartitionedThemeActive && !onDemandThemeActive" in workspace
|
|
assert "onRefreshProjectData" in workspace
|
|
assert "selectedProjectId ? loadProjectData(selectedProjectId)" in app
|
|
assert "successful.some((item) => item.acquisition)" in selection_hook
|
|
assert "await onDatasetsChanged()" in selection_hook
|
|
assert "settleWithConcurrency(" in selection_hook
|
|
assert "queries," in selection_hook
|
|
assert "3," in selection_hook
|
|
|
|
|
|
def test_regional_on_demand_sources_require_a_bounded_drawn_selection() -> None:
|
|
workspace = read_map_workspace()
|
|
|
|
assert "regionalOnDemandThemeActive" in workspace
|
|
# Both regional source kinds need a bounded selection before acquiring.
|
|
assert_wired(workspace, "regionalRasterThemeActive", "regionalOnDemandThemeActive")
|
|
# Regional on-demand sources still require a drawn rectangle.
|
|
assert "Teken" in workspace and "rechthoek" in workspace
|
|
assert "begrensde" in workspace or "begrensd" in workspace
|
|
|
|
|
|
def test_frontend_does_not_contact_external_map_services_directly() -> None:
|
|
frontend_sources = "\n".join(
|
|
path.read_text(encoding="utf-8")
|
|
for path in (ROOT / "frontend/src").rglob("*")
|
|
if path.suffix in {".ts", ".tsx"}
|
|
)
|
|
|
|
assert "mercatornet.be" not in frontend_sources.casefold()
|
|
assert "geo.api.vlaanderen.be" not in frontend_sources.casefold()
|
|
assert "GetCoverage" not in frontend_sources
|