JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
57 lines
2.3 KiB
Python
57 lines
2.3 KiB
Python
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_map_workspace_exposes_structured_surfaces() -> None:
|
|
map_workspace = read_feature("map_workspace")
|
|
|
|
assert 'className="map-workspace-shell"' in map_workspace
|
|
assert 'className="map-context-summary"' in map_workspace
|
|
assert 'aria-label="Status van de kaartlagen"' in map_workspace
|
|
assert 'className="map-control-surface"' in map_workspace
|
|
assert 'aria-label="Bediening van de kaartwerkruimte"' in map_workspace
|
|
assert 'className="map-frame-surface"' in map_workspace
|
|
assert 'className="map-inspection-surface"' in map_workspace
|
|
|
|
|
|
def test_map_workspace_summary_uses_current_layer_and_selection_state() -> None:
|
|
map_workspace = read_feature("map_workspace")
|
|
|
|
assert "const selectedMapArea = areas.find" in map_workspace
|
|
assert "selectedMapArea?.name ?? 'Geen gebied geselecteerd'" in map_workspace
|
|
assert "mapLayerLabel" in map_workspace
|
|
assert "mapLayerSourceLabel" in map_workspace
|
|
assert "mapFeatureCount" in map_workspace
|
|
assert "areaFeatureCount" in map_workspace
|
|
|
|
|
|
def test_map_workspace_density_css_contracts() -> None:
|
|
css = (ROOT / "frontend" / "src" / "styles" / "app.css").read_text(encoding="utf-8")
|
|
|
|
assert ".map-workspace-shell" in css
|
|
assert ".map-context-summary" in css
|
|
assert ".map-context-summary > div" in css
|
|
assert ".map-control-surface" in css
|
|
assert ".map-frame-surface" in css
|
|
assert ".map-inspection-surface" in css
|
|
assert ".map-workspace-shell .map-toolbar" in css
|
|
assert "grid-template-columns: repeat(auto-fit, minmax(11rem, 1fr));" in css
|
|
assert "background: linear-gradient(180deg, #ffffff, #f7fbf8);" in css
|
|
assert "border-left: 4px solid var(--accent);" in css
|
|
|
|
|
|
def test_map_workspace_mobile_controls_remain_compact() -> None:
|
|
css = (ROOT / "frontend" / "src" / "styles" / "app.css").read_text(encoding="utf-8")
|
|
|
|
assert ".map-workspace-shell .map-context-summary" in css
|
|
assert ".map-workspace-shell .map-toolbar" in css
|
|
assert ".map-workspace-shell .layer-provenance-rail" in css
|
|
assert "grid-template-columns: repeat(auto-fit, minmax(8.25rem, 1fr));" in css
|
|
assert "grid-template-columns: repeat(auto-fit, minmax(7.5rem, 1fr));" in css
|
|
assert ".map-control-surface," in css
|