JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
49 lines
2.2 KiB
Python
49 lines
2.2 KiB
Python
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_project_and_area_panels_expose_selected_summary_regions() -> None:
|
|
project_panel = (ROOT / "frontend" / "src" / "components" / "project" / "ProjectPanel.tsx").read_text(
|
|
encoding="utf-8"
|
|
)
|
|
area_panel = (ROOT / "frontend" / "src" / "components" / "project" / "AreaPanel.tsx").read_text(
|
|
encoding="utf-8"
|
|
)
|
|
|
|
assert "const selectedProject = projects.find" in project_panel
|
|
assert 'className="data-selection-summary data-selection-summary-project"' in project_panel
|
|
assert 'className="data-panel-form-block technical-management-block"' in project_panel
|
|
assert 'className="data-panel-list-block"' in project_panel
|
|
assert "const selectedArea = areas.find" in area_panel
|
|
assert 'className="data-selection-summary data-selection-summary-area"' in area_panel
|
|
assert 'className="data-panel-form-block"' in area_panel
|
|
assert 'className="data-panel-list-block area-catalog-disclosure"' in area_panel
|
|
|
|
|
|
def test_dataset_panel_separates_selected_upload_and_catalog_regions() -> None:
|
|
dataset_panel = read_feature("datasets")
|
|
|
|
assert "const selectedDataset = datasets.find" in dataset_panel
|
|
assert 'className="data-selection-summary data-selection-summary-dataset"' in dataset_panel
|
|
assert 'className="dataset-upload-block data-panel-form-block"' in dataset_panel
|
|
assert 'className="data-panel-list-block dataset-catalog-block"' in dataset_panel
|
|
assert 'className="data-section-label"' in dataset_panel
|
|
|
|
|
|
def test_data_workspace_density_css_contracts() -> None:
|
|
css = (ROOT / "frontend" / "src" / "styles" / "app.css").read_text(encoding="utf-8")
|
|
|
|
assert ".data-selection-summary" in css
|
|
assert ".data-selection-summary strong" in css
|
|
assert ".data-panel-form-block" in css
|
|
assert ".data-panel-list-block" in css
|
|
assert ".data-section-label" in css
|
|
assert "grid-template-columns: repeat(auto-fit, minmax(10rem, 1fr));" in css
|
|
assert "background: linear-gradient(180deg, #ffffff, #f7fbf8);" in css
|
|
assert "border-left: 4px solid var(--accent);" in css
|