JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
43 lines
1.6 KiB
Python
43 lines
1.6 KiB
Python
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_dataset_panel_surfaces_role_summary_and_badges() -> None:
|
|
dataset_panel = read_feature("datasets")
|
|
|
|
assert "roleSummaries" in dataset_panel
|
|
assert "dataset-role-summary-grid" in dataset_panel
|
|
assert "Geselecteerd" in dataset_panel
|
|
assert "Referentie" in dataset_panel
|
|
assert "Resultaat" in dataset_panel
|
|
assert "Eigen bron" in dataset_panel
|
|
assert "dataset-role-badge" in dataset_panel
|
|
assert "dataset-role-selected" in dataset_panel
|
|
assert "dataset-role-reference" in dataset_panel
|
|
assert "dataset-role-candidate" in dataset_panel
|
|
assert "dataset-role-source" in dataset_panel
|
|
|
|
|
|
def test_dataset_cards_expose_scan_friendly_source_and_crs_context() -> None:
|
|
dataset_panel = read_feature("datasets")
|
|
|
|
assert "dataset-card-kicker" in dataset_panel
|
|
assert "Bron: {dataset.source_name ?? dataset.source}" in dataset_panel
|
|
assert "Laag: {dataset.reference_layer_name}" in dataset_panel
|
|
assert "CRS: {dataset.crs ?? dataset.vector_summary?.crs ?? 'onbekend'}" in dataset_panel
|
|
assert "dataset-card-title" in dataset_panel
|
|
|
|
|
|
def test_dataset_catalog_density_styles_are_responsive() -> None:
|
|
css = (ROOT / "frontend" / "src" / "styles" / "app.css").read_text(encoding="utf-8")
|
|
|
|
assert ".dataset-role-summary-grid" in css
|
|
assert "repeat(auto-fit, minmax(8.5rem, 1fr))" in css
|
|
assert ".dataset-role-badge" in css
|
|
assert ".dataset-role-selected" in css
|
|
assert ".dataset-card-kicker" in css
|
|
assert ".dataset-card-title" in css
|