JensandClaude Opus 5
39c12822bc
MapWorkspace.tsx opened with ~590 lines of theme catalogue, dataset matching and label formatting above a 3.200-line component. None of it is React, all of it is independently testable, and both render paths read from it, so it belongs beside the pure helpers that already live in mapWorkspaceUtils. The contract tests that read MapWorkspace.tsx would have gone red for a move that changes no behaviour at all — 24 of them. That is the brittleness the frontend_contract helper exists to remove, so it gains read_map_workspace(): the workspace is one feature spread over several modules, and a contract belongs to the feature rather than to whichever file currently holds it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
74 lines
3.4 KiB
Python
74 lines
3.4 KiB
Python
from pathlib import Path
|
|
from tests.frontend_contract import assert_calls, assert_mentions, assert_wired, read_map_workspace
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def read(path: str) -> str:
|
|
return (ROOT / path).read_text(encoding="utf-8")
|
|
|
|
|
|
def test_flanders_workspace_exposes_governed_thematic_products_on_demand() -> None:
|
|
workspace = read_map_workspace()
|
|
product_hook = read("frontend/src/hooks/useOfficialMapProducts.ts")
|
|
selection_hook = read("frontend/src/hooks/useMapThemeSelectionInsights.ts")
|
|
api = read("frontend/src/services/api/datasets.ts")
|
|
|
|
assert "activeScopeProject?.name === FLANDERS_WORKSPACE_PROJECT_NAME" in workspace
|
|
assert "new Map<DataThemeId, OnDemandMapProduct>" in workspace
|
|
assert_wired(workspace, "space_occupation")
|
|
assert "setActiveThemeId(fallbackTheme.id)" in workspace
|
|
assert "return `referentiejaar ${observationYear}`" in workspace
|
|
assert "kind: 'thematic_raster'" in workspace
|
|
assert "productKey: onDemandProduct.productKey" in workspace
|
|
assert "datasetsApi.listThematicRasterProducts" in product_hook
|
|
assert "datasetsApi.acquireThematicRaster" in selection_hook
|
|
assert "datasetsApi.selectThematicRaster" in selection_hook
|
|
assert "datasetsApi.get(selectedProjectId, acquisitionJob.output_dataset_id)" in selection_hook
|
|
assert "/datasets/thematic-raster/acquire" in api
|
|
|
|
|
|
def test_selection_reads_and_bounded_acquires_all_relevant_themes() -> None:
|
|
workspace = read_map_workspace()
|
|
app = read("frontend/src/App.tsx")
|
|
selection_hook = read("frontend/src/hooks/useMapThemeSelectionInsights.ts")
|
|
|
|
# Selection reads the active theme; the loop form is incidental.
|
|
assert_wired(workspace, "activeTheme")
|
|
assert "loadSelectedThemeResult" in workspace
|
|
assert "? onDemandProductsForZones(resolvedZones)" in workspace
|
|
assert ".filter((product) => product.theme === activeThemeId)" not in workspace
|
|
assert "await loadThemeInsights(bbox, availableThemes, areaId)" in workspace
|
|
assert "!regionalPartitionedThemeActive && !onDemandThemeActive" in workspace
|
|
assert "onRefreshProjectData" in workspace
|
|
assert "selectedProjectId ? loadProjectData(selectedProjectId)" in app
|
|
assert "successful.some((item) => item.acquisition)" in selection_hook
|
|
assert "await onDatasetsChanged()" in selection_hook
|
|
assert "settleWithConcurrency(" in selection_hook
|
|
assert "queries," in selection_hook
|
|
assert "3," in selection_hook
|
|
|
|
|
|
def test_regional_on_demand_sources_require_a_bounded_drawn_selection() -> None:
|
|
workspace = read_map_workspace()
|
|
|
|
assert "regionalOnDemandThemeActive" in workspace
|
|
# Both regional source kinds need a bounded selection before acquiring.
|
|
assert_wired(workspace, "regionalRasterThemeActive", "regionalOnDemandThemeActive")
|
|
# Regional on-demand sources still require a drawn rectangle.
|
|
assert "Teken" in workspace and "rechthoek" in workspace
|
|
assert "begrensde" in workspace or "begrensd" in workspace
|
|
|
|
|
|
def test_frontend_does_not_contact_external_map_services_directly() -> None:
|
|
frontend_sources = "\n".join(
|
|
path.read_text(encoding="utf-8")
|
|
for path in (ROOT / "frontend/src").rglob("*")
|
|
if path.suffix in {".ts", ".tsx"}
|
|
)
|
|
|
|
assert "mercatornet.be" not in frontend_sources.casefold()
|
|
assert "geo.api.vlaanderen.be" not in frontend_sources.casefold()
|
|
assert "GetCoverage" not in frontend_sources
|