JensandClaude Opus 5
39c12822bc
MapWorkspace.tsx opened with ~590 lines of theme catalogue, dataset matching and label formatting above a 3.200-line component. None of it is React, all of it is independently testable, and both render paths read from it, so it belongs beside the pure helpers that already live in mapWorkspaceUtils. The contract tests that read MapWorkspace.tsx would have gone red for a move that changes no behaviour at all — 24 of them. That is the brittleness the frontend_contract helper exists to remove, so it gains read_map_workspace(): the workspace is one feature spread over several modules, and a contract belongs to the feature rather than to whichever file currently holds it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
61 lines
2.9 KiB
Python
61 lines
2.9 KiB
Python
from pathlib import Path
|
|
from tests.frontend_contract import assert_calls, assert_mentions, assert_wired, read_map_workspace
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_partitioned_raster_routes_are_canonical_and_documented() -> None:
|
|
routes = (ROOT / "backend/app/api/routes/datasets.py").read_text(encoding="utf-8")
|
|
contracts = (ROOT / "docs/API_CONTRACTS.md").read_text(encoding="utf-8")
|
|
|
|
assert '"/datasets/raster/terrain/select",' in routes
|
|
assert "response_model=Envelope[TerrainSelectionResponse]" in routes
|
|
assert '"/datasets/raster/flood-hazard/select",' in routes
|
|
assert "response_model=Envelope[FloodHazardSelectionResponse]" in routes
|
|
assert "/datasets/raster/terrain/select" in contracts
|
|
assert "/datasets/raster/flood-hazard/select" in contracts
|
|
assert "envelope(TerrainAnalysisService.analyze_partitions" in routes
|
|
assert "envelope(FloodHazardAnalysisService.analyze_partitions" in routes
|
|
|
|
|
|
def test_regional_map_uses_logical_partition_groups_and_exact_analysis() -> None:
|
|
app = (ROOT / "frontend/src/App.tsx").read_text(encoding="utf-8")
|
|
workspace = read_map_workspace()
|
|
hook = (ROOT / "frontend/src/hooks/useMapThemeSelectionInsights.ts").read_text(encoding="utf-8")
|
|
api = (ROOT / "frontend/src/services/api/datasets.ts").read_text(encoding="utf-8")
|
|
|
|
assert "regionalScopeSelected" in workspace
|
|
assert "rasterPartitionsForDataset" in workspace
|
|
assert "imageOverlays={activeImageOverlays}" in workspace
|
|
assert_mentions(workspace, "automatisch", "raster")
|
|
assert "selectTerrainPartitions" in hook
|
|
assert "selectFloodHazardPartitions" in hook
|
|
assert "/datasets/raster/terrain/select" in api
|
|
assert "/datasets/raster/flood-hazard/select" in api
|
|
assert "Rasterlaag actief" in app
|
|
assert "void analyzeSelection(bbox, areaIdForSelection(bbox))" in workspace
|
|
assert "areaIdForSelection(bbox)" in workspace
|
|
assert_wired(workspace, "selectedAreaBbox")
|
|
assert_calls(workspace, "analyzeSelection", first_argument="bbox")
|
|
assert "onDeriveMapSelectionDataset(bbox, areaIdForSelection(bbox))" in workspace
|
|
|
|
|
|
def test_maplibre_supports_multiple_persisted_raster_overlays() -> None:
|
|
map_source = (ROOT / "frontend/src/components/GeoMap.tsx").read_text(encoding="utf-8")
|
|
|
|
assert "imageOverlays?: MapImageOverlay[]" in map_source
|
|
assert "imageOverlayIdsRef" in map_source
|
|
assert "imageOverlays.forEach" in map_source
|
|
assert "bounded-raster-" in map_source
|
|
|
|
|
|
def test_regional_analysis_does_not_create_an_authoritative_mosaic() -> None:
|
|
service = (ROOT / "backend/app/services/raster_partition_analysis_service.py").read_text(encoding="utf-8")
|
|
storage = (ROOT / "docs/STORAGE_ARCHITECTURE.md").read_text(encoding="utf-8")
|
|
|
|
assert "from rasterio.merge import merge" in service
|
|
assert "DatasetService" not in service
|
|
assert "12-million-cell limit" in storage
|
|
assert "does not create another authoritative raster" in storage
|