JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
54 lines
1.8 KiB
Python
54 lines
1.8 KiB
Python
from pathlib import Path
|
|
|
|
from app.schemas.flood_hazard import FloodHazardAcquireRequest
|
|
from app.schemas.operations import VectorSelectionBBox
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def read(path: str) -> str:
|
|
return (ROOT / path).read_text(encoding="utf-8")
|
|
|
|
|
|
def test_official_map_catalog_hook_loads_all_governed_registries() -> None:
|
|
hook = read_feature("map_workspace")
|
|
|
|
assert "datasetsApi.listThematicRasterProducts" in hook
|
|
assert "datasetsApi.listDhmvProducts" in hook
|
|
assert "datasetsApi.listFloodHazardProducts" in hook
|
|
assert "datasetsApi.listGrbProducts" in hook
|
|
assert "Promise.all([" in hook
|
|
|
|
|
|
def test_map_selection_can_acquire_dhmv_and_flood_hazard_products() -> None:
|
|
selection_hook = read_feature("map_workspace")
|
|
workspace = read_feature("map_workspace")
|
|
|
|
for acquisition_kind in (
|
|
"'thematic_raster'",
|
|
"'dhmv'",
|
|
"'flood_hazard'",
|
|
"'grb'",
|
|
"'official_vector'",
|
|
"'bathymetry_profiles'",
|
|
):
|
|
assert acquisition_kind in selection_hook
|
|
assert "datasetsApi.acquireDhmv" in selection_hook
|
|
assert "datasetsApi.acquireFloodHazard" in selection_hook
|
|
assert "datasetsApi.acquireThematicRaster" in selection_hook
|
|
assert 'aria-label="Hoogtemodel"' in workspace
|
|
assert 'aria-label="Overstromingsscenario"' in workspace
|
|
assert "product.display_name" in workspace
|
|
assert "DTM meet het maaiveld; DSM bevat ook gebouwen en vegetatie." in workspace
|
|
assert "geen actuele waterstand" in workspace
|
|
|
|
|
|
def test_default_flood_hazard_product_exists_in_the_governed_registry() -> None:
|
|
request = FloodHazardAcquireRequest(
|
|
bbox=VectorSelectionBBox(min_x=5.0, min_y=51.0, max_x=5.01, max_y=51.01),
|
|
)
|
|
|
|
assert request.product_key == "pluviaal_current_t100"
|