JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
50 lines
2.0 KiB
Python
50 lines
2.0 KiB
Python
from pathlib import Path
|
|
|
|
import pytest
|
|
from pydantic import ValidationError
|
|
|
|
from app.schemas.operations import VectorSelectionBBox, VectorSelectionRequest
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_vector_selection_contract_keeps_an_explicit_bounded_limit() -> None:
|
|
bbox = VectorSelectionBBox(min_x=5.03, min_y=51.15, max_x=5.25, max_y=51.33)
|
|
|
|
request = VectorSelectionRequest(bbox=bbox, limit=1000)
|
|
|
|
assert request.limit == 1000
|
|
with pytest.raises(ValidationError):
|
|
VectorSelectionRequest(bbox=bbox, limit=1001)
|
|
|
|
|
|
def test_large_vector_delivery_uses_existing_postgis_bbox_contract() -> None:
|
|
config = (ROOT / "frontend" / "src" / "config" / "vectorDelivery.ts").read_text(encoding="utf-8")
|
|
viewport_hook = (ROOT / "frontend" / "src" / "hooks" / "useViewportVectorLayer.ts").read_text(encoding="utf-8")
|
|
dataset_hook = read_feature("datasets")
|
|
|
|
assert "VECTOR_VIEWPORT_FEATURE_THRESHOLD = 5_000" in config
|
|
assert "VECTOR_VIEWPORT_MIN_ZOOM = 14" in config
|
|
assert "VECTOR_VIEWPORT_FEATURE_LIMIT = 1_000" in config
|
|
assert "datasetsApi.selectVectorFeatures" in viewport_hook
|
|
assert "response.truncated" in viewport_hook
|
|
assert "requestSequence" in viewport_hook
|
|
assert "summary.feature_count ?? dataset.feature_count" in dataset_hook
|
|
assert "datasetsApi.getContent" in dataset_hook
|
|
|
|
|
|
def test_map_reports_viewport_and_does_not_refit_each_slice() -> None:
|
|
app = read_feature("shell")
|
|
geo_map = (ROOT / "frontend" / "src" / "components" / "GeoMap.tsx").read_text(encoding="utf-8")
|
|
workspace = read_feature("map_workspace")
|
|
|
|
assert "useViewportVectorLayer" in app
|
|
assert "fitMapDataOnChange={!viewportVectorLayerActive}" in app
|
|
assert "map.on('moveend', emitViewport)" in geo_map
|
|
assert "fitDataOnChange" in geo_map
|
|
assert "onViewportChange" in geo_map
|
|
assert "Zoom verder in" in (ROOT / "frontend" / "src" / "hooks" / "useViewportVectorLayer.ts").read_text(encoding="utf-8")
|
|
assert "viewport-vector-status" in workspace
|