JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
61 lines
2.6 KiB
Python
61 lines
2.6 KiB
Python
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_frontend_declares_national_scope_as_primary_operating_focus() -> None:
|
|
focus = (ROOT / "frontend" / "src" / "config" / "primaryFocus.ts").read_text(
|
|
encoding="utf-8"
|
|
)
|
|
project_hook = (ROOT / "frontend" / "src" / "hooks" / "useProjectWorkspace.ts").read_text(
|
|
encoding="utf-8"
|
|
)
|
|
map_source = (ROOT / "frontend" / "src" / "components" / "GeoMap.tsx").read_text(
|
|
encoding="utf-8"
|
|
)
|
|
navigation = read_feature("shell")
|
|
|
|
assert "NATIONAL_WORKSPACE_PROJECT_NAME = 'Belgium and North Sea Workbench'" in focus
|
|
assert "NATIONAL_WORKSPACE_REGION = 'Belgie en Belgische Noordzee'" in focus
|
|
assert "NATIONAL_MAP_CENTER" in focus
|
|
assert "return nationalProject.id" in project_hook
|
|
assert "hasMappedAnalysisContext(data)" in project_hook
|
|
assert "dataset.dataset_type === 'raster'" in project_hook
|
|
assert "dataset.dataset_type === 'vector' || dataset.dataset_type === 'geojson'" in project_hook
|
|
assert "PRIMARY_FOCUS_AREA_NAME" not in project_hook
|
|
assert "PRIMARY_FOCUS_AREA_GEOJSON" not in project_hook
|
|
assert "center: NATIONAL_MAP_CENTER" in map_source
|
|
assert "zoom: NATIONAL_MAP_ZOOM" in map_source
|
|
assert "GeoIntel" in navigation
|
|
assert "GeoIntelMark" in navigation
|
|
|
|
|
|
def test_operator_workflows_put_mol_first_and_name_future_projects() -> None:
|
|
samples = (ROOT / "scripts" / "prepare_operator_real_data_samples.py").read_text(
|
|
encoding="utf-8"
|
|
)
|
|
matrix = (ROOT / "scripts" / "run_detection_quality_matrix.sh").read_text(
|
|
encoding="utf-8"
|
|
)
|
|
multi_matrix = (
|
|
ROOT / "scripts" / "run_multi_sample_detection_quality_matrix.sh"
|
|
).read_text(encoding="utf-8")
|
|
|
|
assert samples.index('"mol": OperatorSample(') < samples.index('"geel": OperatorSample(')
|
|
assert 'QUALITY_SAMPLE_SLUG="${QUALITY_SAMPLE_SLUG:-}"' in matrix
|
|
assert "sample ${QUALITY_SAMPLE_SLUG}" in matrix
|
|
assert 'QUALITY_SAMPLE_SLUG="${sample_slug}"' in multi_matrix
|
|
|
|
|
|
def test_product_docs_record_national_scope_and_mol_regression_focus() -> None:
|
|
readme = (ROOT / "README.md").read_text(encoding="utf-8")
|
|
vision = (ROOT / "docs" / "PRODUCT_VISION.md").read_text(encoding="utf-8")
|
|
|
|
# The README is Dutch; assert the two claims it must make, not one phrasing.
|
|
assert "Belgische Noordzee" in readme
|
|
assert "Mol en de Kempen" in readme and "regressiegebieden" in readme
|
|
assert "Belgie en de Belgische Noordzee" in vision
|
|
assert "Mol en de Kempen blijven gouden regressiegebieden" in vision
|