JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
45 lines
1.7 KiB
Python
45 lines
1.7 KiB
Python
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_global_focus_visible_contracts_are_defined() -> None:
|
|
css = (ROOT / "frontend" / "src" / "styles" / "app.css").read_text(encoding="utf-8")
|
|
|
|
assert "--focus-ring" in css
|
|
assert "--focus-ring-soft" in css
|
|
assert "button:focus-visible" in css
|
|
assert ".nav-item:focus-visible" in css
|
|
assert ".command-chip:focus-visible" in css
|
|
assert ".inspector-tab:focus-visible" in css
|
|
assert ".dataset-action-button:focus-visible" in css
|
|
assert "outline: 3px solid var(--focus-ring);" in css
|
|
assert "outline-offset: 2px;" in css
|
|
|
|
|
|
def test_primary_navigation_has_keyboard_labels() -> None:
|
|
app = read_feature("shell")
|
|
navigation = read_feature("shell")
|
|
|
|
assert 'aria-label={`Open ${item.label}: ${item.description}`}' in navigation
|
|
assert "title={item.description}" in navigation
|
|
assert "aria-current={item.key === activeWorkspace ? 'page' : undefined}" in navigation
|
|
assert "label: 'Bronnen'" in app
|
|
assert "label: 'Kaart'" in app
|
|
assert "label: 'Kwaliteit'" in app
|
|
assert "label: 'Downloads'" in app
|
|
|
|
|
|
def test_inspector_tabs_are_bound_to_tab_panels() -> None:
|
|
inspector = read_feature("shell")
|
|
|
|
assert "const activeTabId = `inspector-tab-${activeTab}`" in inspector
|
|
assert "const activePanelId = `inspector-panel-${activeTab}`" in inspector
|
|
assert "aria-controls={`inspector-panel-${tab.key}`}" in inspector
|
|
assert "id={`inspector-tab-${tab.key}`}" in inspector
|
|
assert 'role="tabpanel"' in inspector
|
|
assert "id={activePanelId}" in inspector
|
|
assert "aria-labelledby={activeTabId}" in inspector
|