JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
46 lines
1.7 KiB
Python
46 lines
1.7 KiB
Python
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_quality_results_panel_exposes_selected_check_drilldown() -> None:
|
|
panel = read_feature("quality")
|
|
|
|
assert "selectedQualityCheckId" in panel
|
|
assert "selectedQualityCheck" in panel
|
|
assert "Details van het kaartbewijs" in panel
|
|
assert "Geselecteerde controle" in panel
|
|
assert "Te controleren laag" in panel
|
|
assert "Referentielaag" in panel
|
|
assert "Analyserun" in panel
|
|
assert "Taak" in panel
|
|
assert "Afgerond" in panel
|
|
assert "Laatste controle bekijken" in panel
|
|
assert "Controle bekijken" in panel
|
|
|
|
|
|
def test_quality_results_panel_surfaces_false_positive_negative_evidence() -> None:
|
|
panel = read_feature("quality")
|
|
|
|
assert "Onterecht gevonden" in panel
|
|
assert "Gemiste objecten" in panel
|
|
assert "Controle op de kaart" in panel
|
|
assert "metricByKey(selectedQualityCheck, 'false_positive_count')" in panel
|
|
assert "metricByKey(selectedQualityCheck, 'false_negative_count')" in panel
|
|
assert "selectedQualityCheck.parameters_json" in panel
|
|
assert "selectedQualityCheck.findings_json" in panel
|
|
assert "JSON.stringify" in panel
|
|
|
|
|
|
def test_quality_drilldown_styles_are_responsive() -> None:
|
|
css = (ROOT / "frontend" / "src" / "styles" / "app.css").read_text(encoding="utf-8")
|
|
|
|
assert ".quality-drilldown-surface" in css
|
|
assert ".quality-drilldown-grid" in css
|
|
assert ".quality-evidence-token-grid" in css
|
|
assert ".quality-evidence-map-handoff" in css
|
|
assert ".quality-provenance-pre" in css
|
|
assert "grid-template-columns: repeat(auto-fit, minmax(12rem, 1fr));" in css
|