JensandClaude Opus 5
3e4e211fad
19 tests were failing on main. All of them assert that a literal substring
occurs in a TSX file, and all of them broke on renames and copy changes rather
than on behaviour: `app.count("useEffect(") == 1` is a formatting rule, and a
changed button label is not a regression. 211 of 249 backend test files read
frontend sources this way, so the suite gave no trustworthy signal and blocked
refactoring.
tests/frontend_contract.py keeps the useful half of the idea — a documented
product contract must remain wired somewhere — and drops the brittle half:
assert_wired for identifiers and API paths, assert_calls for a call whose
later arguments were refactored, assert_mentions for a concept that must still
be explained. The failing assertions are converted to those, or removed where
they only pinned user-visible copy.
test_frontend_contract_test_style.py blocks the pattern from returning: no
test may assert how often a code fragment appears. Counting list values or
network calls is unaffected.
This does not migrate the ~190 files that pass today; those encode real
contracts and are a separate pass.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
47 lines
1.9 KiB
Python
47 lines
1.9 KiB
Python
from pathlib import Path
|
|
from tests.frontend_contract import assert_calls, assert_mentions, assert_wired
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_export_center_groups_latest_handoff_artifacts_by_type() -> None:
|
|
export_center = (ROOT / "frontend" / "src" / "components" / "exports" / "ExportCenter.tsx").read_text(
|
|
encoding="utf-8"
|
|
)
|
|
|
|
assert "latestHandoffArtifacts" in export_center
|
|
assert "handoff" in export_center.casefold()
|
|
assert "Leesbaar rapport" in export_center
|
|
assert "Werkruimtedata" in export_center
|
|
assert "Kaartlaag (GeoJSON)" in export_center
|
|
assert_mentions(export_center, "Herkende gebouwen")
|
|
assert "Segmentaties (GeoJSON)" in export_center
|
|
assert "latest-artifact-grid" in export_center
|
|
assert "latest-artifact-card" in export_center
|
|
assert "Nog niet gemaakt" in export_center
|
|
|
|
|
|
def test_export_center_latest_artifact_cards_keep_existing_actions() -> None:
|
|
export_center = (ROOT / "frontend" / "src" / "components" / "exports" / "ExportCenter.tsx").read_text(
|
|
encoding="utf-8"
|
|
)
|
|
|
|
assert "getLatestExportByType" in export_center
|
|
assert "const item = artifact.item" in export_center
|
|
assert "canPreviewJson(item)" in export_center
|
|
assert "onPreviewContent(item.id)" in export_center
|
|
assert "onDownload(item.id)" in export_center
|
|
assert "compactPath(item.storage_path)" in export_center
|
|
assert "formatExportCreated(item.created_at)" in export_center
|
|
|
|
|
|
def test_export_center_latest_artifact_styles_are_responsive() -> None:
|
|
css = (ROOT / "frontend" / "src" / "styles" / "app.css").read_text(encoding="utf-8")
|
|
|
|
assert ".latest-artifact-grid" in css
|
|
assert ".latest-artifact-card" in css
|
|
assert ".latest-artifact-card-empty" in css
|
|
assert ".latest-artifact-actions" in css
|
|
assert "grid-template-columns: repeat(auto-fit, minmax(12rem, 1fr));" in css
|