JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
33 lines
1.2 KiB
Python
33 lines
1.2 KiB
Python
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_map_empty_state_surfaces_ready_vector_dataset_actions() -> None:
|
|
map_workspace = read_feature("map_workspace")
|
|
|
|
assert "availableMapDatasets" in map_workspace
|
|
assert "onOpenDatasetInMap" in map_workspace
|
|
assert "map-empty-action-grid" in map_workspace
|
|
assert "Open een beschikbare vectorlaag" in map_workspace
|
|
assert "Open op kaart" in map_workspace
|
|
assert "Nog geen gebruiksklare vectorlagen beschikbaar" in map_workspace
|
|
|
|
|
|
def test_app_passes_available_vector_datasets_to_map_workspace() -> None:
|
|
app = read_feature("shell")
|
|
|
|
assert "availableMapDatasets" in app
|
|
assert "datasets.filter((dataset) => isVectorDatasetType(dataset.dataset_type) && dataset.status === 'ready')" in app
|
|
assert "availableMapDatasets={availableMapDatasets}" in app
|
|
assert "onOpenDatasetInMap={openDatasetInMap}" in app
|
|
|
|
|
|
def test_map_empty_action_grid_has_responsive_styles() -> None:
|
|
css = (ROOT / "frontend" / "src" / "styles" / "app.css").read_text(encoding="utf-8")
|
|
|
|
assert ".map-empty-action-grid" in css
|
|
assert "repeat(auto-fit, minmax(11rem, 1fr))" in css
|