JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
57 lines
2.0 KiB
Python
57 lines
2.0 KiB
Python
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_app_uses_export_and_quality_workflow_hooks() -> None:
|
|
app = (ROOT / "frontend" / "src" / "App.tsx").read_text(encoding="utf-8")
|
|
|
|
assert "useExportWorkflow" in app
|
|
assert "useQualityWorkflow" in app
|
|
assert "from './hooks/useExportWorkflow'" in app
|
|
assert "from './hooks/useQualityWorkflow'" in app
|
|
assert "exportsApi" not in app
|
|
assert "qaApi" not in app
|
|
|
|
|
|
def test_export_workflow_hook_owns_export_api_calls() -> None:
|
|
hook = read_feature("exports")
|
|
|
|
assert "exportsApi.listProjectExports" in hook
|
|
assert "exportsApi.exportGeojson" in hook
|
|
assert "exportsApi.exportProjectMetadata" in hook
|
|
assert "exportsApi.exportProjectReport" in hook
|
|
assert "exportsApi.getContent" in hook
|
|
assert "exportsApi.downloadUrl" in hook
|
|
assert "resetExportsForProject" in hook
|
|
|
|
|
|
def test_quality_workflow_hook_owns_quality_api_calls() -> None:
|
|
hook = read_feature("quality")
|
|
|
|
assert "qaApi.listQualityChecks" in hook
|
|
assert "qaApi.runQa" in hook
|
|
assert "runQaComparison" in hook
|
|
assert "loadQualityChecks" in hook
|
|
assert "setQaIouThreshold" in hook
|
|
|
|
|
|
def test_app_still_wires_quality_results_and_export_center() -> None:
|
|
app = (ROOT / "frontend" / "src" / "App.tsx").read_text(encoding="utf-8")
|
|
quality_panel = read_feature("quality")
|
|
|
|
assert "<QualityResultsPanel" in app
|
|
assert "onRefresh={() => loadQualityChecks()}" in app
|
|
assert "Kwaliteitsresultaten vernieuwen" in quality_panel
|
|
assert "onClick={onRefresh}" in quality_panel
|
|
assert "<ExportCenter" in app
|
|
assert "onExportDataset={exportSelectedDatasetGeoJson}" in app
|
|
assert "onExportDetectionRun={exportSelectedDetectionRunGeoJson}" in app
|
|
assert "onExportSegmentationRun={exportSelectedSegmentationRunGeoJson}" in app
|
|
assert "onPreviewContent={previewExportContent}" in app
|
|
assert "onDownload={downloadExportArtifact}" in app
|