JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
61 lines
2.8 KiB
Python
61 lines
2.8 KiB
Python
from pathlib import Path
|
|
from tests.frontend_contract import assert_calls, assert_mentions, assert_wired, read_map_workspace, read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_partitioned_raster_routes_are_canonical_and_documented() -> None:
|
|
routes = (ROOT / "backend/app/api/routes/datasets.py").read_text(encoding="utf-8")
|
|
contracts = (ROOT / "docs/API_CONTRACTS.md").read_text(encoding="utf-8")
|
|
|
|
assert '"/datasets/raster/terrain/select",' in routes
|
|
assert "response_model=Envelope[TerrainSelectionResponse]" in routes
|
|
assert '"/datasets/raster/flood-hazard/select",' in routes
|
|
assert "response_model=Envelope[FloodHazardSelectionResponse]" in routes
|
|
assert "/datasets/raster/terrain/select" in contracts
|
|
assert "/datasets/raster/flood-hazard/select" in contracts
|
|
assert "envelope(TerrainAnalysisService.analyze_partitions" in routes
|
|
assert "envelope(FloodHazardAnalysisService.analyze_partitions" in routes
|
|
|
|
|
|
def test_regional_map_uses_logical_partition_groups_and_exact_analysis() -> None:
|
|
app = read_feature("shell")
|
|
workspace = read_map_workspace()
|
|
hook = read_feature("map_workspace")
|
|
api = read_feature("datasets")
|
|
|
|
assert "regionalScopeSelected" in workspace
|
|
assert "rasterPartitionsForDataset" in workspace
|
|
assert "imageOverlays={activeImageOverlays}" in workspace
|
|
assert_mentions(workspace, "automatisch", "raster")
|
|
assert "selectTerrainPartitions" in hook
|
|
assert "selectFloodHazardPartitions" in hook
|
|
assert "/datasets/raster/terrain/select" in api
|
|
assert "/datasets/raster/flood-hazard/select" in api
|
|
assert "Rasterlaag actief" in app
|
|
assert "void analyzeSelection(bbox, areaIdForSelection(bbox))" in workspace
|
|
assert "areaIdForSelection(bbox)" in workspace
|
|
assert_wired(workspace, "selectedAreaBbox")
|
|
assert_calls(workspace, "analyzeSelection", first_argument="bbox")
|
|
assert "onDeriveMapSelectionDataset(bbox, areaIdForSelection(bbox))" in workspace
|
|
|
|
|
|
def test_maplibre_supports_multiple_persisted_raster_overlays() -> None:
|
|
map_source = (ROOT / "frontend/src/components/GeoMap.tsx").read_text(encoding="utf-8")
|
|
|
|
assert "imageOverlays?: MapImageOverlay[]" in map_source
|
|
assert "imageOverlayIdsRef" in map_source
|
|
assert "imageOverlays.forEach" in map_source
|
|
assert "bounded-raster-" in map_source
|
|
|
|
|
|
def test_regional_analysis_does_not_create_an_authoritative_mosaic() -> None:
|
|
service = (ROOT / "backend/app/services/raster_partition_analysis_service.py").read_text(encoding="utf-8")
|
|
storage = (ROOT / "docs/STORAGE_ARCHITECTURE.md").read_text(encoding="utf-8")
|
|
|
|
assert "from rasterio.merge import merge" in service
|
|
assert "DatasetService" not in service
|
|
assert "12-million-cell limit" in storage
|
|
assert "does not create another authoritative raster" in storage
|