JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
69 lines
2.4 KiB
Python
69 lines
2.4 KiB
Python
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_overview_exposes_end_to_end_workflow_guidance() -> None:
|
|
overview = read_feature("shell")
|
|
|
|
assert 'aria-label="Voortgang van de werkstroom"' in overview
|
|
assert 'className="workflow-guidance-panel"' in overview
|
|
assert 'className="workflow-guidance-steps"' in overview
|
|
assert "steps.map" in overview
|
|
assert "Werkruimte en gebied" in overview
|
|
assert "Databronnen" in overview
|
|
assert "Kaart" in overview
|
|
assert "Controle en analyse" in overview
|
|
assert "Downloads" in overview
|
|
|
|
|
|
def test_workflow_guidance_routes_to_existing_workspaces() -> None:
|
|
app = read_feature("shell")
|
|
overview = read_feature("shell")
|
|
|
|
assert "target: 'data'" in overview
|
|
assert "target: 'map'" in overview
|
|
assert "target: 'analysis'" in overview
|
|
assert "target: 'exports'" in overview
|
|
assert "onOpenWorkspace={openWorkflowGuidanceStep}" in app
|
|
assert "onClick={() => onOpenWorkspace(step.target)}" in overview
|
|
assert "setActiveWorkspace(target)" in app
|
|
|
|
|
|
def test_workflow_guidance_has_responsive_contracts() -> None:
|
|
css = (ROOT / "frontend" / "src" / "styles" / "app.css").read_text(encoding="utf-8")
|
|
|
|
assert ".workflow-guidance-panel" in css
|
|
assert ".workflow-guidance-steps" in css
|
|
assert ".workflow-guidance-step" in css
|
|
assert ".workflow-guidance-step-active" in css
|
|
assert ".workflow-step-status" in css
|
|
assert "grid-template-columns: repeat(auto-fit, minmax(8rem, 1fr));" in css
|
|
|
|
|
|
def test_workflow_guidance_complete_state_and_map_copy_are_precise() -> None:
|
|
overview = read_feature("shell")
|
|
|
|
assert "workflowComplete" in overview
|
|
assert "Klaar om te delen" in overview
|
|
assert "objecten op de kaart" in overview
|
|
assert "selectedAreaHasGeometry" in overview
|
|
assert "Werkgebied ingeladen" in overview
|
|
|
|
|
|
def test_workflow_guidance_map_and_export_steps_reuse_dataset_context() -> None:
|
|
app = read_feature("shell")
|
|
overview = read_feature("shell")
|
|
|
|
assert "openWorkflowGuidanceStep" in app
|
|
assert "target === 'map'" in app
|
|
assert "openDatasetInMap(availableMapDatasets[0])" in app
|
|
assert "target === 'exports'" in app
|
|
assert "openDatasetExport(availableMapDatasets[0])" in app
|
|
assert "onOpenWorkspace={openWorkflowGuidanceStep}" in app
|
|
assert "onClick={() => onOpenWorkspace(step.target)}" in overview
|