JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
48 lines
1.7 KiB
Python
48 lines
1.7 KiB
Python
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_app_uses_dataset_presentational_components() -> None:
|
|
app = (ROOT / "frontend" / "src" / "App.tsx").read_text(encoding="utf-8")
|
|
inspector = read_feature("shell")
|
|
|
|
assert "from './components/datasets/DatasetPanel'" in app
|
|
assert "from './components/inspector/WorkbenchInspector'" in app
|
|
assert "<DatasetPanel" in app
|
|
assert "<WorkbenchInspector" in app
|
|
assert "from '../datasets/DatasetDetailPanel'" in inspector
|
|
assert "<DatasetDetailPanel {...datasetDetailProps} />" in inspector
|
|
assert "<form onSubmit={uploadDataset}" not in app
|
|
assert "<h3>Rasterbewerkingen</h3>" not in app
|
|
assert "<h3>Vectorbewerkingen</h3>" not in app
|
|
|
|
|
|
def test_dataset_panel_owns_upload_and_list_markup() -> None:
|
|
panel = read_feature("datasets")
|
|
|
|
assert "Eigen bronbestand toevoegen" in panel
|
|
assert "Metadata vernieuwen" in panel
|
|
assert "Details en acties" in panel
|
|
assert "onLoadDatasetDetails" in panel
|
|
assert "onRefreshMetadata" in panel
|
|
|
|
|
|
def test_dataset_detail_panel_composes_raster_and_vector_controls() -> None:
|
|
detail_panel = read_feature("datasets")
|
|
raster_controls = read_feature("datasets")
|
|
vector_controls = read_feature("datasets")
|
|
|
|
assert "<RasterControls" in detail_panel
|
|
assert "<VectorControls" in detail_panel
|
|
assert "Technische verwerking" in detail_panel
|
|
assert "Rasterbewerkingen" in raster_controls
|
|
assert "NDVI berekenen" in raster_controls
|
|
assert "Beeldtegels maken" in raster_controls
|
|
assert "Vectorbewerkingen" in vector_controls
|
|
assert "Overlap berekenen" in vector_controls
|