JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
47 lines
1.5 KiB
Python
47 lines
1.5 KiB
Python
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_workbench_shell_has_skip_link_and_main_focus_target() -> None:
|
|
app = read_feature("shell")
|
|
navigation = read_feature("shell")
|
|
|
|
assert 'className="skip-link"' in app
|
|
assert 'href="#workspace-main"' in app
|
|
assert '<nav aria-label="Hoofdonderdelen">' in navigation
|
|
assert 'id="workspace-main"' in app
|
|
assert "tabIndex={-1}" in app
|
|
|
|
|
|
def test_mobile_shell_density_contracts_are_defined() -> None:
|
|
css = (ROOT / "frontend" / "src" / "styles" / "app.css").read_text(encoding="utf-8")
|
|
atlas = (ROOT / "frontend" / "src" / "styles" / "atlas-workbench.css").read_text(
|
|
encoding="utf-8"
|
|
)
|
|
|
|
assert ".skip-link" in css
|
|
assert ".skip-link:focus-visible" in css
|
|
assert "scroll-margin-top: 8.5rem;" in css
|
|
assert "@media (max-width: 920px)" in atlas
|
|
assert "overflow-x: auto;" in atlas
|
|
assert "flex: 0 0 4.4rem;" in atlas
|
|
assert "white-space: nowrap;" in atlas
|
|
assert ".context-bar,\n .quick-action-grid,\n .workspace-nav-cluster" not in css
|
|
|
|
|
|
def test_small_screen_navigation_keeps_labels_readable() -> None:
|
|
css = (ROOT / "frontend" / "src" / "styles" / "atlas-workbench.css").read_text(
|
|
encoding="utf-8"
|
|
)
|
|
|
|
assert "@media (max-width: 560px)" in css
|
|
assert ".workbench-sidebar .nav-item" in css
|
|
assert "min-width: 4.4rem;" in css
|
|
assert ".nav-item-icon" in css
|
|
assert "text-overflow: ellipsis;" in css
|