JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
48 lines
1.7 KiB
Python
48 lines
1.7 KiB
Python
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_app_uses_task_based_workbench_shell() -> None:
|
|
app = read_feature("shell")
|
|
navigation = read_feature("shell")
|
|
|
|
assert "type WorkspaceKey" in app
|
|
assert "workspaceNavItems" in app
|
|
assert "<WorkbenchNavigation" in app
|
|
assert 'data-testid={`workspace-nav-${item.key}`}' in navigation
|
|
assert 'className="workbench-layout"' in app
|
|
assert 'className="workbench-sidebar"' in navigation
|
|
assert "'workbench-main workbench-main-map' : 'workbench-main'" in app
|
|
assert 'className="workbench-inspector"' in app
|
|
assert "activeWorkspace === 'data'" in app
|
|
assert "activeWorkspace === 'map'" in app
|
|
assert "activeWorkspace === 'analysis'" in app
|
|
assert "activeWorkspace === 'ai'" in app
|
|
assert "activeWorkspace === 'exports'" in app
|
|
assert "activeWorkspace === 'system'" in app
|
|
|
|
|
|
def test_workbench_shell_css_provides_navigation_main_and_inspector_regions() -> None:
|
|
css = (ROOT / "frontend" / "src" / "styles" / "app.css").read_text(encoding="utf-8")
|
|
atlas = (ROOT / "frontend" / "src" / "styles" / "atlas-workbench.css").read_text(
|
|
encoding="utf-8"
|
|
)
|
|
|
|
assert ".workbench-topbar" in css
|
|
assert ".context-bar" in css
|
|
assert ".workbench-layout" in css
|
|
assert ".workbench-sidebar" in css
|
|
assert ".nav-item-active" in css
|
|
assert ".workbench-main" in css
|
|
assert ".workbench-inspector" in css
|
|
assert ".workspace-grid-data" in css
|
|
assert ".workspace-grid-ai" in css
|
|
assert ".workbench-stage" in atlas
|
|
assert ".context-health" in atlas
|
|
assert ".nav-item-icon" in atlas
|