JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
33 lines
1.3 KiB
Python
33 lines
1.3 KiB
Python
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_map_selection_qa_shortcut_uses_existing_qa_workflow_contract() -> None:
|
|
hook_path = ROOT / "frontend" / "src" / "hooks" / "useMapSelectionQa.ts"
|
|
app = (ROOT / "frontend" / "src" / "App.tsx").read_text(encoding="utf-8")
|
|
map_workspace = read_feature("map_workspace")
|
|
|
|
assert hook_path.exists()
|
|
hook = hook_path.read_text(encoding="utf-8")
|
|
assert "qaApi.runQa" in hook
|
|
assert "loadQualityChecks" in hook
|
|
assert "candidateDataset = latestSelectionDataset" in hook
|
|
assert "candidate_dataset_id: candidateDataset.id" in hook
|
|
assert "reference_dataset_id: selectedMapQaReferenceDatasetId" in hook
|
|
assert "setMapQaResult" in hook
|
|
assert "useMapSelectionQa" in app
|
|
assert "mapQaReferenceDatasets={referenceDatasets}" in app
|
|
assert "onRunMapSelectionQa={runMapSelectionQa}" in app
|
|
assert "Bewaarde laag controleren" in map_workspace
|
|
assert "mapSelectionQaError" in map_workspace
|
|
assert "mapSelectionQaResult" in map_workspace
|
|
|
|
|
|
def test_app_keeps_qa_api_calls_out_of_orchestration() -> None:
|
|
app = (ROOT / "frontend" / "src" / "App.tsx").read_text(encoding="utf-8")
|
|
|
|
assert "qaApi" not in app
|
|
assert "from './services/api'" not in app
|