JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
38 lines
1.4 KiB
Python
38 lines
1.4 KiB
Python
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_geomap_exposes_v1_layer_controls_and_feature_inspection_contract() -> None:
|
|
geomap = (ROOT / "frontend" / "src" / "components" / "GeoMap.tsx").read_text(encoding="utf-8")
|
|
|
|
assert "visible?: boolean" in geomap
|
|
assert "opacity?: number" in geomap
|
|
assert "onFeatureSelect?: (feature: GeoJSON.Feature | null) => void" in geomap
|
|
assert "queryRenderedFeatures" in geomap
|
|
assert "mapStyleReady" in geomap
|
|
assert "map.on('load'" in geomap
|
|
assert "if (!map || !mapStyleReady)" in geomap
|
|
assert "map.isStyleLoaded()" not in geomap
|
|
assert "setLayoutProperty('dataset-fill', 'visibility'" in geomap
|
|
assert "setPaintProperty('dataset-fill', 'fill-opacity', opacity)" in geomap
|
|
|
|
|
|
def test_app_wires_map_workbench_component() -> None:
|
|
app = read_feature("shell")
|
|
component = read_feature("map_workspace")
|
|
|
|
assert "mapLayerVisible" in app
|
|
assert "mapLayerOpacity" in app
|
|
assert "selectedMapFeature" in app
|
|
assert "<MapWorkspace" in app
|
|
assert "onSelectMapFeature={setSelectedMapFeature}" in app
|
|
assert "Actieve kaartlaag" in component
|
|
assert "Dekking van de kaartlaag" in component
|
|
assert "Objectinspectie" in component
|
|
assert "onFeatureSelect={onSelectMapFeature}" in component
|