JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
41 lines
1.4 KiB
Python
41 lines
1.4 KiB
Python
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_quality_panel_promotes_core_metrics_before_raw_metric_list() -> None:
|
|
quality_panel = read_feature("quality")
|
|
|
|
assert "CORE_METRIC_ORDER" in quality_panel
|
|
assert "precision" in quality_panel
|
|
assert "recall" in quality_panel
|
|
assert "f1" in quality_panel
|
|
assert "mean_iou" in quality_panel
|
|
assert "false_positive_count" in quality_panel
|
|
assert "false_negative_count" in quality_panel
|
|
assert "qualityMetricValue" in quality_panel
|
|
assert "qualityMetricLabel" in quality_panel
|
|
|
|
|
|
def test_quality_panel_renders_metric_evidence_cards_and_raw_metrics() -> None:
|
|
quality_panel = read_feature("quality")
|
|
|
|
assert "quality-metric-grid" in quality_panel
|
|
assert "quality-metric-card" in quality_panel
|
|
assert "quality-metric-card-critical" in quality_panel
|
|
assert "Gemeten kwaliteit" in quality_panel
|
|
assert "Alle meetwaarden" in quality_panel
|
|
assert "check.metrics.map" in quality_panel
|
|
|
|
|
|
def test_quality_metric_styles_are_dense_and_responsive() -> None:
|
|
css = (ROOT / "frontend" / "src" / "styles" / "app.css").read_text(encoding="utf-8")
|
|
|
|
assert ".quality-metric-grid" in css
|
|
assert "repeat(auto-fit, minmax(7.5rem, 1fr))" in css
|
|
assert ".quality-metric-card" in css
|
|
assert ".quality-metric-card-critical" in css
|
|
assert ".quality-metric-card strong" in css
|