JensandClaude Opus 5
3e4e211fad
19 tests were failing on main. All of them assert that a literal substring
occurs in a TSX file, and all of them broke on renames and copy changes rather
than on behaviour: `app.count("useEffect(") == 1` is a formatting rule, and a
changed button label is not a regression. 211 of 249 backend test files read
frontend sources this way, so the suite gave no trustworthy signal and blocked
refactoring.
tests/frontend_contract.py keeps the useful half of the idea — a documented
product contract must remain wired somewhere — and drops the brittle half:
assert_wired for identifiers and API paths, assert_calls for a call whose
later arguments were refactored, assert_mentions for a concept that must still
be explained. The failing assertions are converted to those, or removed where
they only pinned user-visible copy.
test_frontend_contract_test_style.py blocks the pattern from returning: no
test may assert how often a code fragment appears. Counting list values or
network calls is unaffected.
This does not migrate the ~190 files that pass today; those encode real
contracts and are a separate pass.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
61 lines
3.0 KiB
Python
61 lines
3.0 KiB
Python
from pathlib import Path
|
|
from tests.frontend_contract import assert_calls, assert_mentions, assert_wired
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_partitioned_raster_routes_are_canonical_and_documented() -> None:
|
|
routes = (ROOT / "backend/app/api/routes/datasets.py").read_text(encoding="utf-8")
|
|
contracts = (ROOT / "docs/API_CONTRACTS.md").read_text(encoding="utf-8")
|
|
|
|
assert '"/datasets/raster/terrain/select",' in routes
|
|
assert "response_model=Envelope[TerrainSelectionResponse]" in routes
|
|
assert '"/datasets/raster/flood-hazard/select",' in routes
|
|
assert "response_model=Envelope[FloodHazardSelectionResponse]" in routes
|
|
assert "/datasets/raster/terrain/select" in contracts
|
|
assert "/datasets/raster/flood-hazard/select" in contracts
|
|
assert "envelope(TerrainAnalysisService.analyze_partitions" in routes
|
|
assert "envelope(FloodHazardAnalysisService.analyze_partitions" in routes
|
|
|
|
|
|
def test_regional_map_uses_logical_partition_groups_and_exact_analysis() -> None:
|
|
app = (ROOT / "frontend/src/App.tsx").read_text(encoding="utf-8")
|
|
workspace = (ROOT / "frontend/src/components/map/MapWorkspace.tsx").read_text(encoding="utf-8")
|
|
hook = (ROOT / "frontend/src/hooks/useMapThemeSelectionInsights.ts").read_text(encoding="utf-8")
|
|
api = (ROOT / "frontend/src/services/api/datasets.ts").read_text(encoding="utf-8")
|
|
|
|
assert "regionalScopeSelected" in workspace
|
|
assert "rasterPartitionsForDataset" in workspace
|
|
assert "imageOverlays={activeImageOverlays}" in workspace
|
|
assert_mentions(workspace, "automatisch", "raster")
|
|
assert "selectTerrainPartitions" in hook
|
|
assert "selectFloodHazardPartitions" in hook
|
|
assert "/datasets/raster/terrain/select" in api
|
|
assert "/datasets/raster/flood-hazard/select" in api
|
|
assert "Rasterlaag actief" in app
|
|
assert "void analyzeSelection(bbox, areaIdForSelection(bbox))" in workspace
|
|
assert "areaIdForSelection(bbox)" in workspace
|
|
assert_wired(workspace, "selectedAreaBbox")
|
|
assert_calls(workspace, "analyzeSelection", first_argument="bbox")
|
|
assert "onDeriveMapSelectionDataset(bbox, areaIdForSelection(bbox))" in workspace
|
|
|
|
|
|
def test_maplibre_supports_multiple_persisted_raster_overlays() -> None:
|
|
map_source = (ROOT / "frontend/src/components/GeoMap.tsx").read_text(encoding="utf-8")
|
|
|
|
assert "imageOverlays?: MapImageOverlay[]" in map_source
|
|
assert "imageOverlayIdsRef" in map_source
|
|
assert "imageOverlays.forEach" in map_source
|
|
assert "bounded-raster-" in map_source
|
|
|
|
|
|
def test_regional_analysis_does_not_create_an_authoritative_mosaic() -> None:
|
|
service = (ROOT / "backend/app/services/raster_partition_analysis_service.py").read_text(encoding="utf-8")
|
|
storage = (ROOT / "docs/STORAGE_ARCHITECTURE.md").read_text(encoding="utf-8")
|
|
|
|
assert "from rasterio.merge import merge" in service
|
|
assert "DatasetService" not in service
|
|
assert "12-million-cell limit" in storage
|
|
assert "does not create another authoritative raster" in storage
|