JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
62 lines
2.7 KiB
Python
62 lines
2.7 KiB
Python
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_workbench_components_expose_stable_interaction_test_ids() -> None:
|
|
project_panel = (ROOT / "frontend" / "src" / "components" / "project" / "ProjectPanel.tsx").read_text(
|
|
encoding="utf-8"
|
|
)
|
|
area_panel = (ROOT / "frontend" / "src" / "components" / "project" / "AreaPanel.tsx").read_text(
|
|
encoding="utf-8"
|
|
)
|
|
map_workspace = read_feature("map_workspace")
|
|
dataset_panel = read_feature("datasets")
|
|
quality_panel = read_feature("quality")
|
|
export_center = read_feature("exports")
|
|
|
|
assert 'data-testid="project-panel"' in project_panel
|
|
assert 'data-testid={`project-select-${project.id}`}' in project_panel
|
|
assert 'data-testid="load-demo-workflow"' in project_panel
|
|
assert 'data-testid="area-panel"' in area_panel
|
|
assert 'data-testid={`area-show-${area.id}`}' in area_panel
|
|
assert 'data-testid="map-workspace"' in map_workspace
|
|
assert 'data-testid="map-area-select"' in map_workspace
|
|
assert 'data-testid="map-area-visible"' in map_workspace
|
|
assert 'data-testid="map-area-opacity"' in map_workspace
|
|
assert 'data-testid="map-layer-visible"' in map_workspace
|
|
assert 'data-testid="map-layer-opacity"' in map_workspace
|
|
assert 'data-testid="dataset-panel"' in dataset_panel
|
|
assert 'data-testid={`dataset-select-${dataset.id}`}' in dataset_panel
|
|
assert 'data-testid="quality-results-panel"' in quality_panel
|
|
assert 'data-testid="refresh-quality-results"' in quality_panel
|
|
assert 'data-testid="export-center"' in export_center
|
|
assert 'data-testid="refresh-exports"' in export_center
|
|
assert 'data-testid="export-project-metadata"' in export_center
|
|
|
|
|
|
def test_readiness_gate_checks_workbench_interaction_smoke_script_syntax() -> None:
|
|
readiness = (ROOT / "scripts" / "run_readiness_check.sh").read_text(encoding="utf-8")
|
|
|
|
assert "bash -n scripts/verify_workbench_interactions.sh" in readiness
|
|
|
|
|
|
def test_workbench_interaction_script_verifies_core_control_backing_state() -> None:
|
|
script = (ROOT / "scripts" / "verify_workbench_interactions.sh").read_text(encoding="utf-8")
|
|
|
|
assert "/api/v1/demo/workflow" in script
|
|
assert "/api/v1/projects" in script
|
|
assert "/areas" in script
|
|
assert "/datasets" in script
|
|
assert "/quality-checks" in script
|
|
assert "/api/v1/exports/metadata" in script
|
|
assert "/api/v1/exports/projects/" in script
|
|
assert "GeoIntel Demo - Building QA" in script
|
|
assert "Demo AOI - Geel buildings" in script
|
|
assert "candidate dataset" in script
|
|
assert "reference dataset" in script
|