JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
51 lines
1.9 KiB
Python
51 lines
1.9 KiB
Python
from __future__ import annotations
|
|
|
|
import json
|
|
from pathlib import Path
|
|
from tests.frontend_contract import read_map_workspace, read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_rc9_ux_audit_is_wired_into_frontend_and_readiness() -> None:
|
|
package = json.loads((ROOT / "frontend" / "package.json").read_text(encoding="utf-8"))
|
|
readiness = (ROOT / "scripts" / "run_readiness_check.sh").read_text(encoding="utf-8")
|
|
wrapper = ROOT / "scripts" / "run_rc9_ux_audit.sh"
|
|
|
|
assert package["scripts"]["test:e2e:ux"] == "node e2e/uxAudit.mjs"
|
|
assert '"${NODE_BIN}" --check frontend/e2e/uxAudit.mjs' in readiness
|
|
assert "bash -n scripts/run_rc9_ux_audit.sh" in readiness
|
|
assert wrapper.is_file()
|
|
|
|
|
|
def test_rc9_loading_and_accessibility_states_are_explicit() -> None:
|
|
app = read_feature("shell")
|
|
map_workspace = read_map_workspace()
|
|
geo_map = (ROOT / "frontend" / "src" / "components" / "GeoMap.tsx").read_text(
|
|
encoding="utf-8"
|
|
)
|
|
|
|
assert "workspaceDataLoading" in app
|
|
assert 'role="status" aria-live="polite"' in app
|
|
assert "Databronnen worden gecontroleerd" in map_workspace
|
|
# Copy changes; the requirement is that source availability is stated.
|
|
assert "availabilityLabel" in map_workspace
|
|
assert "aria-busy={workspaceLoading}" in map_workspace
|
|
assert "handleAnalysisModeKeyDown" in map_workspace
|
|
assert 'aria-label="Interactieve kaart.' in geo_map
|
|
|
|
|
|
def test_rc9_performance_budgets_are_documented_and_visible() -> None:
|
|
budget = (
|
|
ROOT / "frontend" / "src" / "lib" / "performanceBudget.ts"
|
|
).read_text(encoding="utf-8")
|
|
docs = (ROOT / "docs" / "UX_PERFORMANCE_BUDGETS.md").read_text(encoding="utf-8")
|
|
map_workspace = read_map_workspace()
|
|
|
|
assert "COVERAGE_RESPONSE_BUDGET_MS = 4_000" in budget
|
|
assert "MAP_ANALYSIS_BUDGET_MS = 15_000" in budget
|
|
assert "4 seconds" in docs
|
|
assert "15 seconds" in docs
|
|
assert "overschrijdt het releasebudget" in map_workspace
|