JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
50 lines
1.8 KiB
Python
50 lines
1.8 KiB
Python
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_quality_panel_accepts_dataset_context_without_fetching() -> None:
|
|
quality_panel = (
|
|
ROOT / "frontend" / "src" / "components" / "quality" / "QualityResultsPanel.tsx"
|
|
).read_text(encoding="utf-8")
|
|
|
|
assert "DatasetCreateResponse" in quality_panel
|
|
assert "candidateDatasets" in quality_panel
|
|
assert "referenceDatasets" in quality_panel
|
|
assert "datasetNameById" in quality_panel
|
|
assert "fetch(" not in quality_panel
|
|
assert "api" not in quality_panel.lower()
|
|
|
|
|
|
def test_quality_panel_surfaces_candidate_reference_handoff_summary() -> None:
|
|
quality_panel = (
|
|
ROOT / "frontend" / "src" / "components" / "quality" / "QualityResultsPanel.tsx"
|
|
).read_text(encoding="utf-8")
|
|
|
|
assert "quality-handoff-grid" in quality_panel
|
|
assert "Te controleren lagen" in quality_panel
|
|
assert "Referentielagen" in quality_panel
|
|
assert "Laatste vergelijking" in quality_panel
|
|
assert "Te controleren:" in quality_panel
|
|
assert "referentie:" in quality_panel
|
|
assert "quality-dataset-name" in quality_panel
|
|
|
|
|
|
def test_app_passes_quality_dataset_context() -> None:
|
|
app = read_feature("shell")
|
|
|
|
assert "availableVectorDatasets.filter((item) => item.dataset_role !== 'reference')" in app
|
|
assert "candidateDatasets={candidateDatasets}" in app
|
|
assert "referenceDatasets={referenceDatasets}" in app
|
|
|
|
|
|
def test_quality_handoff_styles_are_responsive() -> None:
|
|
css = (ROOT / "frontend" / "src" / "styles" / "app.css").read_text(encoding="utf-8")
|
|
|
|
assert ".quality-handoff-grid" in css
|
|
assert "repeat(auto-fit, minmax(11rem, 1fr))" in css
|
|
assert ".quality-dataset-name" in css
|
|
assert ".quality-check-dataset-link" in css
|