JensandClaude Opus 5
6572e4ad5f
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
45 lines
1.7 KiB
Python
45 lines
1.7 KiB
Python
from pathlib import Path
|
|
from tests.frontend_contract import read_feature
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[2]
|
|
|
|
|
|
def test_app_wires_tabbed_workbench_inspector() -> None:
|
|
app = read_feature("shell")
|
|
|
|
assert "from './components/inspector/WorkbenchInspector'" in app
|
|
assert "<WorkbenchInspector" in app
|
|
assert "selectedProject={selectedProject}" in app
|
|
assert "selectedArea={selectedArea}" in app
|
|
assert "qualityChecks={qualityChecks}" in app
|
|
assert "latestExport={latestExport}" in app
|
|
assert "detectionRuns={detectionRuns}" in app
|
|
assert "segmentationRuns={segmentationRuns}" in app
|
|
assert "datasetDetailProps={{" in app
|
|
|
|
|
|
def test_workbench_inspector_exposes_context_dataset_quality_and_ai_tabs() -> None:
|
|
inspector = (
|
|
ROOT / "frontend" / "src" / "components" / "inspector" / "WorkbenchInspector.tsx"
|
|
).read_text(encoding="utf-8")
|
|
|
|
assert "type InspectorTab = 'context' | 'dataset' | 'quality' | 'ai'" in inspector
|
|
assert 'data-testid="workbench-inspector-panel"' in inspector
|
|
assert "data-testid={`inspector-tab-${tab.key}`}" in inspector
|
|
assert "<DatasetDetailPanel {...datasetDetailProps} />" in inspector
|
|
assert "Laatste kwaliteitscontrole" in inspector
|
|
assert "Laatste download" in inspector
|
|
assert "Gebouwdetectie" in inspector
|
|
assert "Segmentatie" in inspector
|
|
assert "fetch(" not in inspector
|
|
|
|
|
|
def test_dataset_detail_props_remain_exported_for_inspector_reuse() -> None:
|
|
dataset_panel = read_feature("datasets")
|
|
|
|
assert "export interface DatasetDetailPanelProps" in dataset_panel
|
|
assert 'className="dataset-detail-panel"' in dataset_panel
|
|
assert "onRunRasterInspect" in dataset_panel
|
|
assert "onRunVectorIntersect" in dataset_panel
|