4 Commits

Include renames

Author	SHA1	Message	Date
JensandClaude Opus 5	6572e4ad5f	scope frontend contracts to the feature, not to one file ... 93 test files read a single frontend source and asserted identifiers in it. The MapWorkspace split showed what that costs: 24 tests went red for a move that changed no behaviour at all. A contract belongs to the feature — a container, its hooks, its domain layer — not to whichever file currently holds it. 232 read sites now resolve through read_feature(). The distinction that makes this safe is direction: a *positive* contract ("this is wired") may widen, because the identifier must still exist somewhere in the feature; a *negative* one ("this component performs no transport") is a statement about one file, and widening it would quietly weaken the check. The 73 single-file reads that remain are exactly those, and a guard now enforces the rule for new tests. Verified rather than assumed: of the 732 migrated positive assertions, 644 still match exactly one module — as specific as before — and the other 86 already spanned a container and its hook by nature. Two apparent misses are an artefact of the checking regex reading an escaped newline literally. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-22 22:05:43 +02:00
JensandClaude Opus 5	39c12822bc	extract the map workspace's domain layer out of the component ... MapWorkspace.tsx opened with ~590 lines of theme catalogue, dataset matching and label formatting above a 3.200-line component. None of it is React, all of it is independently testable, and both render paths read from it, so it belongs beside the pure helpers that already live in mapWorkspaceUtils. The contract tests that read MapWorkspace.tsx would have gone red for a move that changes no behaviour at all — 24 of them. That is the brittleness the frontend_contract helper exists to remove, so it gains read_map_workspace(): the workspace is one feature spread over several modules, and a contract belongs to the feature rather than to whichever file currently holds it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-22 18:49:06 +02:00
JensandClaude Opus 5	3e4e211fad	test frontend wiring instead of frontend formatting ... 19 tests were failing on main. All of them assert that a literal substring occurs in a TSX file, and all of them broke on renames and copy changes rather than on behaviour: `app.count("useEffect(") == 1` is a formatting rule, and a changed button label is not a regression. 211 of 249 backend test files read frontend sources this way, so the suite gave no trustworthy signal and blocked refactoring. tests/frontend_contract.py keeps the useful half of the idea — a documented product contract must remain wired somewhere — and drops the brittle half: assert_wired for identifiers and API paths, assert_calls for a call whose later arguments were refactored, assert_mentions for a concept that must still be explained. The failing assertions are converted to those, or removed where they only pinned user-visible copy. test_frontend_contract_test_style.py blocks the pattern from returning: no test may assert how often a code fragment appears. Counting list values or network calls is unaffected. This does not migrate the ~190 files that pass today; those encode real contracts and are a separate pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-22 14:34:13 +02:00
Codex	9b0239747d	Harden RC9 UX and performance states	2026-07-18 06:37:54 +02:00