consume only artifacts the runtime produced
tile_manifest_path arrives in the detection and segmentation request and was read straight off disk, and a manifest entry may name an absolute tile path. That makes an API field an unbounded reference to the host filesystem, and it contradicts the rule the persistence model rests on: only a governed, runtime-produced artifact may be consumed, and a file outside the storage root is not one. Both the manifest and every tile it names now resolve under STORAGE_ROOT. Resolution happens before the comparison, so ".." cannot climb out and a sibling that merely shares a name prefix does not pass. GEOINTEL_ALLOW_EXTERNAL_ARTIFACT_PATHS opts out for provisioning workflows that stage tiles before ingest. The check honours the Settings the caller is operating under rather than the process-wide ones, because every analysis path already threads its own. The affected tests write manifests into tmp_path, so they now declare tmp_path as the storage root — which is what a deployment does, and makes the fixtures more honest than they were. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -186,3 +186,8 @@ GEOINTEL_AOI_WORKER_POLL_SECONDS=2
|
||||
# /detection/run-async, so tiled GPU inference never blocks an HTTP request.
|
||||
GEOINTEL_ANALYSIS_WORKER_ENABLED=false
|
||||
GEOINTEL_ANALYSIS_WORKER_POLL_SECONDS=2
|
||||
# Analysis consumes only artifacts under STORAGE_ROOT: a tile manifest path
|
||||
# arrives in the request and a manifest entry may name an absolute tile
|
||||
# path, so without this an API field is an unbounded filesystem reference.
|
||||
# Provisioning workflows that stage tiles elsewhere before ingest can opt out.
|
||||
GEOINTEL_ALLOW_EXTERNAL_ARTIFACT_PATHS=false
|
||||
|
||||
Reference in New Issue
Block a user