Add tabbed workbench inspector
GeoIntel CI / docs-smoke (push) Has been cancelled
GeoIntel CI / contract-smoke (push) Has been cancelled

This commit is contained in:
Codex
2026-06-17 21:23:04 +02:00
parent 36821fe099
commit bb1890b40f
10 changed files with 461 additions and 73 deletions
@@ -52,19 +52,20 @@ def test_app_still_wires_dataset_ui_callbacks() -> None:
assert "onUploadDataset={uploadDataset}" in app
assert "onLoadDatasetDetails={loadDatasetDetails}" in app
assert "onRefreshMetadata={refreshMetadata}" in app
assert "<DatasetDetailPanel" in app
assert "onRunRasterInspect={runRasterInspect}" in app
assert "onRunRasterPreview={runRasterPreview}" in app
assert "onRunRasterStats={runRasterStats}" in app
assert "onRunRasterReproject={runRasterReproject}" in app
assert "onRunRasterClip={runRasterClip}" in app
assert "onRunRasterTile={runRasterTile}" in app
assert "onRunRasterNdvi={runRasterNdvi}" in app
assert "onRunRasterNdwi={runRasterNdwi}" in app
assert "onRunRasterNdbi={runRasterNdbi}" in app
assert "onRunVectorClip={runVectorClip}" in app
assert "onRunVectorBuffer={runVectorBuffer}" in app
assert "onRunVectorIntersect={() => runVectorIntersect(availableVectorTargets)}" in app
assert "<WorkbenchInspector" in app
assert "datasetDetailProps={{" in app
assert "onRunRasterInspect: runRasterInspect" in app
assert "onRunRasterPreview: runRasterPreview" in app
assert "onRunRasterStats: runRasterStats" in app
assert "onRunRasterReproject: runRasterReproject" in app
assert "onRunRasterClip: runRasterClip" in app
assert "onRunRasterTile: runRasterTile" in app
assert "onRunRasterNdvi: runRasterNdvi" in app
assert "onRunRasterNdwi: runRasterNdwi" in app
assert "onRunRasterNdbi: runRasterNdbi" in app
assert "onRunVectorClip: runVectorClip" in app
assert "onRunVectorBuffer: runVectorBuffer" in app
assert "onRunVectorIntersect: () => runVectorIntersect(availableVectorTargets)" in app
assert '<form className="dataset-upload-form" onSubmit={onUploadDataset}' in dataset_panel
assert "onClick={() => onLoadDatasetDetails(selectedProjectId ?? '', dataset)}" in dataset_panel
assert "onClick={() => onRefreshMetadata(dataset.id)}" in dataset_panel
@@ -8,11 +8,16 @@ ROOT = Path(__file__).resolve().parents[2]
def test_app_uses_dataset_presentational_components() -> None:
app = (ROOT / "frontend" / "src" / "App.tsx").read_text(encoding="utf-8")
inspector = (
ROOT / "frontend" / "src" / "components" / "inspector" / "WorkbenchInspector.tsx"
).read_text(encoding="utf-8")
assert "from './components/datasets/DatasetPanel'" in app
assert "from './components/datasets/DatasetDetailPanel'" in app
assert "from './components/inspector/WorkbenchInspector'" in app
assert "<DatasetPanel" in app
assert "<DatasetDetailPanel" in app
assert "<WorkbenchInspector" in app
assert "from '../datasets/DatasetDetailPanel'" in inspector
assert "<DatasetDetailPanel {...datasetDetailProps} />" in inspector
assert "<form onSubmit={uploadDataset}" not in app
assert "<h3>Raster operations</h3>" not in app
assert "<h3>Vector operations</h3>" not in app
@@ -0,0 +1,45 @@
from pathlib import Path
ROOT = Path(__file__).resolve().parents[2]
def test_app_wires_tabbed_workbench_inspector() -> None:
app = (ROOT / "frontend" / "src" / "App.tsx").read_text(encoding="utf-8")
assert "from './components/inspector/WorkbenchInspector'" in app
assert "<WorkbenchInspector" in app
assert "selectedProject={selectedProject}" in app
assert "selectedArea={selectedArea}" in app
assert "qualityChecks={qualityChecks}" in app
assert "latestExport={latestExport}" in app
assert "detectionRuns={detectionRuns}" in app
assert "segmentationRuns={segmentationRuns}" in app
assert "datasetDetailProps={{" in app
def test_workbench_inspector_exposes_context_dataset_quality_and_ai_tabs() -> None:
inspector = (
ROOT / "frontend" / "src" / "components" / "inspector" / "WorkbenchInspector.tsx"
).read_text(encoding="utf-8")
assert "type InspectorTab = 'context' | 'dataset' | 'quality' | 'ai'" in inspector
assert 'data-testid="workbench-inspector-panel"' in inspector
assert "data-testid={`inspector-tab-${tab.key}`}" in inspector
assert "<DatasetDetailPanel {...datasetDetailProps} />" in inspector
assert "Latest QA/QC" in inspector
assert "Latest export" in inspector
assert "Detection run" in inspector
assert "Segmentation run" in inspector
assert "fetch(" not in inspector
def test_dataset_detail_props_remain_exported_for_inspector_reuse() -> None:
dataset_panel = (
ROOT / "frontend" / "src" / "components" / "datasets" / "DatasetDetailPanel.tsx"
).read_text(encoding="utf-8")
assert "export interface DatasetDetailPanelProps" in dataset_panel
assert 'className="dataset-detail-panel"' in dataset_panel
assert "onRunRasterInspect" in dataset_panel
assert "onRunVectorIntersect" in dataset_panel