collapse five duplicate overlay blocks into one tested builder

MapWorkspace held five near-identical useMemo blocks deciding which raster
image the map draws under the active theme — terrain, flood depth, thematic
raster, WALOUS land cover and bathymetry. Each filtered partitions by source
name, read bbox_epsg4326 and assembled the same overlay shape, so the parts
that genuinely differ per theme were buried in the repetition.

One builder makes the rule testable and leaves only the source, the label and
the opacity varying. A raster whose bounds are unusable is now skipped rather
than drawn from a partial bbox: an overlay in the wrong place is worse than no
overlay.

The legend asked "are these thematic or WALOUS overlays" by inspecting two of
the five lists. That is a property of the source, so it says so directly.

Two contract tests needed fixing rather than repointing. One asserted
`"api" not in source.lower()`, which the new hook name useMapImageOverlays
matches inside "useM-api-mageOverlays" — as would rapid, capital or therapy.
The contract is that this component talks to no API client, so it now says
that.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Jens
2026-08-22 18:56:21 +02:00
co-authored by Claude Opus 5
parent 39c12822bc
commit 9c29577b82
7 changed files with 507 additions and 101 deletions
@@ -1,5 +1,6 @@
from __future__ import annotations
import re
from pathlib import Path
@@ -58,4 +59,7 @@ def test_map_workspace_owns_map_controls_and_feature_inspector_markup() -> None:
assert "Objectinspectie" in map_workspace
assert "onFeatureSelect={onSelectMapFeature}" in map_workspace
assert "fetch(" not in map_workspace
assert "api" not in map_workspace.lower()
# The component owns markup and interaction, never transport. A bare "api"
# substring also matches useMapImageOverlays, so name what is forbidden.
assert "services/api" not in map_workspace
assert not re.search(r"\w*[Aa]pi\.(get|post|put|delete)\(", map_workspace)