scope frontend contracts to the feature, not to one file
93 test files read a single frontend source and asserted identifiers in it. The
MapWorkspace split showed what that costs: 24 tests went red for a move that
changed no behaviour at all. A contract belongs to the feature — a container,
its hooks, its domain layer — not to whichever file currently holds it.
232 read sites now resolve through read_feature(). The distinction that makes
this safe is direction: a *positive* contract ("this is wired") may widen,
because the identifier must still exist somewhere in the feature; a *negative*
one ("this component performs no transport") is a statement about one file, and
widening it would quietly weaken the check. The 73 single-file reads that
remain are exactly those, and a guard now enforces the rule for new tests.
Verified rather than assumed: of the 732 migrated positive assertions, 644 still
match exactly one module — as specific as before — and the other 86 already
spanned a container and its hook by nature. Two apparent misses are an artefact
of the checking regex reading an escaped newline literally.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,13 +1,14 @@
|
||||
from __future__ import annotations
|
||||
|
||||
from pathlib import Path
|
||||
from tests.frontend_contract import read_feature
|
||||
|
||||
|
||||
ROOT = Path(__file__).resolve().parents[2]
|
||||
|
||||
|
||||
def test_overview_exposes_end_to_end_workflow_guidance() -> None:
|
||||
overview = (ROOT / "frontend" / "src" / "components" / "overview" / "OverviewWorkspace.tsx").read_text(encoding="utf-8")
|
||||
overview = read_feature("shell")
|
||||
|
||||
assert 'aria-label="Voortgang van de werkstroom"' in overview
|
||||
assert 'className="workflow-guidance-panel"' in overview
|
||||
@@ -21,8 +22,8 @@ def test_overview_exposes_end_to_end_workflow_guidance() -> None:
|
||||
|
||||
|
||||
def test_workflow_guidance_routes_to_existing_workspaces() -> None:
|
||||
app = (ROOT / "frontend" / "src" / "App.tsx").read_text(encoding="utf-8")
|
||||
overview = (ROOT / "frontend" / "src" / "components" / "overview" / "OverviewWorkspace.tsx").read_text(encoding="utf-8")
|
||||
app = read_feature("shell")
|
||||
overview = read_feature("shell")
|
||||
|
||||
assert "target: 'data'" in overview
|
||||
assert "target: 'map'" in overview
|
||||
@@ -45,7 +46,7 @@ def test_workflow_guidance_has_responsive_contracts() -> None:
|
||||
|
||||
|
||||
def test_workflow_guidance_complete_state_and_map_copy_are_precise() -> None:
|
||||
overview = (ROOT / "frontend" / "src" / "components" / "overview" / "OverviewWorkspace.tsx").read_text(encoding="utf-8")
|
||||
overview = read_feature("shell")
|
||||
|
||||
assert "workflowComplete" in overview
|
||||
assert "Klaar om te delen" in overview
|
||||
@@ -55,8 +56,8 @@ def test_workflow_guidance_complete_state_and_map_copy_are_precise() -> None:
|
||||
|
||||
|
||||
def test_workflow_guidance_map_and_export_steps_reuse_dataset_context() -> None:
|
||||
app = (ROOT / "frontend" / "src" / "App.tsx").read_text(encoding="utf-8")
|
||||
overview = (ROOT / "frontend" / "src" / "components" / "overview" / "OverviewWorkspace.tsx").read_text(encoding="utf-8")
|
||||
app = read_feature("shell")
|
||||
overview = read_feature("shell")
|
||||
|
||||
assert "openWorkflowGuidanceStep" in app
|
||||
assert "target === 'map'" in app
|
||||
|
||||
Reference in New Issue
Block a user