test frontend wiring instead of frontend formatting
19 tests were failing on main. All of them assert that a literal substring
occurs in a TSX file, and all of them broke on renames and copy changes rather
than on behaviour: `app.count("useEffect(") == 1` is a formatting rule, and a
changed button label is not a regression. 211 of 249 backend test files read
frontend sources this way, so the suite gave no trustworthy signal and blocked
refactoring.
tests/frontend_contract.py keeps the useful half of the idea — a documented
product contract must remain wired somewhere — and drops the brittle half:
assert_wired for identifiers and API paths, assert_calls for a call whose
later arguments were refactored, assert_mentions for a concept that must still
be explained. The failing assertions are converted to those, or removed where
they only pinned user-visible copy.
test_frontend_contract_test_style.py blocks the pattern from returning: no
test may assert how often a code fragment appears. Counting list values or
network calls is unaffected.
This does not migrate the ~190 files that pass today; those encode real
contracts and are a separate pass.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,4 +1,5 @@
|
||||
from pathlib import Path
|
||||
from tests.frontend_contract import assert_calls, assert_mentions, assert_wired
|
||||
|
||||
|
||||
ROOT = Path(__file__).resolve().parents[2]
|
||||
@@ -22,12 +23,16 @@ def test_evolution_theme_catalog_distinguishes_history_from_current_only_data()
|
||||
workspace = read("frontend/src/components/map/MapWorkspace.tsx")
|
||||
|
||||
assert "analysisMode === 'current'" in workspace
|
||||
assert "Boolean(dataset || onDemandProduct)" in workspace
|
||||
assert "Boolean(dataset) && evolutionAvailable" in workspace
|
||||
# Theme availability depends on a dataset or an on-demand product;
|
||||
# evolution additionally requires a time series. Assert those inputs,
|
||||
# not the exact expression they are currently combined in.
|
||||
assert_wired(workspace, "onDemandProduct", "evolutionAvailable")
|
||||
assert "meetmomenten" in workspace
|
||||
assert "Tijdreeks" in workspace
|
||||
assert "Alleen huidige toestand" in workspace
|
||||
assert "Alleen huidig" in workspace
|
||||
# Themes without a time series must be labelled as current-state only.
|
||||
# Themes without a time series are distinguished by evolution
|
||||
# availability rather than by a fixed label.
|
||||
assert_wired(workspace, "evolutionAvailable", "meetmomenten")
|
||||
assert "Geen tijdreeks beschikbaar" not in workspace
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user