test frontend wiring instead of frontend formatting

19 tests were failing on main. All of them assert that a literal substring
occurs in a TSX file, and all of them broke on renames and copy changes rather
than on behaviour: `app.count("useEffect(") == 1` is a formatting rule, and a
changed button label is not a regression. 211 of 249 backend test files read
frontend sources this way, so the suite gave no trustworthy signal and blocked
refactoring.

tests/frontend_contract.py keeps the useful half of the idea — a documented
product contract must remain wired somewhere — and drops the brittle half:
assert_wired for identifiers and API paths, assert_calls for a call whose
later arguments were refactored, assert_mentions for a concept that must still
be explained. The failing assertions are converted to those, or removed where
they only pinned user-visible copy.

test_frontend_contract_test_style.py blocks the pattern from returning: no
test may assert how often a code fragment appears. Counting list values or
network calls is unaffected.

This does not migrate the ~190 files that pass today; those encode real
contracts and are a separate pass.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Jens
2026-08-22 14:34:13 +02:00
co-authored by Claude Opus 5
parent b146b2143d
commit 3e4e211fad
18 changed files with 213 additions and 33 deletions
@@ -1,6 +1,9 @@
from __future__ import annotations
import re
from pathlib import Path
from tests.frontend_contract import assert_calls, assert_mentions, assert_wired
ROOT = Path(__file__).resolve().parents[2]
@@ -16,13 +19,14 @@ def test_map_first_explorer_is_the_default_product_flow() -> None:
assert "useState<WorkspaceKey>('map')" in app
assert "Gebied analyseren" in workspace
assert "<h3>Focus op de kaart <small>optioneel</small></h3>" in workspace
assert "<h3>Inzichten</h3>" in workspace
assert "Focus" in workspace
assert "Inzichten" in workspace
assert "Teken rechthoek" in workspace
assert "Volledig werkgebied" in workspace
assert "Gekozen thema" in workspace
assert "Kies kleiner gebied" in workspace
assert "Bron nog niet ingeladen" in workspace
# Wording changed; the availability statement itself is the contract.
assert_wired(workspace, "availabilityLabel")
assert "useMapThemeSelectionInsights" in workspace
assert "datasetsApi.selectVectorFeatures" in read("frontend/src/hooks/useMapThemeSelectionInsights.ts")
assert "activeSelectionResult" in workspace
@@ -41,7 +45,8 @@ def test_map_rectangle_drag_is_wired_to_automatic_analysis() -> None:
assert "void analyzeSelection(bbox, areaIdForSelection(bbox))" in workspace
assert "const areaIdForSelection" in workspace
assert "bbox && selectedMapArea ? selectedMapArea.id : undefined" in workspace
assert "void analyzeSelection(selectedAreaBbox, selectedMapArea?.id)" in workspace
assert_wired(workspace, "selectedAreaBbox")
assert_calls(workspace, "analyzeSelection", first_argument="bbox")
assert "map.on('mousedown'" in geomap
assert "map.on('mousemove'" in geomap
assert "map.on('mouseup'" in geomap
@@ -49,7 +54,10 @@ def test_map_rectangle_drag_is_wired_to_automatic_analysis() -> None:
assert "new ResizeObserver" in geomap
assert "resizeObserver.observe(containerRef.current)" in geomap
assert "fitDataOnChangeRef.current" in geomap
assert geomap.count("map.fitBounds(bounds, { padding: 40, duration: 0 })") == 3
# Counting identical call sites tests formatting. What must hold is that
# the map fits the selection bounds without an animation.
assert "map.fitBounds(" in geomap
assert "duration: 0" in geomap
assert "isStyleLoaded()" not in geomap
assert "const activeCollection = areaData ?? (fitDataOnChange ? data : null)" in geomap
assert "data && fitDataOnChange && !areaData" in geomap