Extract dataset presentational components
GeoIntel CI / docs-smoke (push) Has been cancelled
GeoIntel CI / contract-smoke (push) Has been cancelled

This commit is contained in:
Codex
2026-06-17 04:04:20 +02:00
parent 57e9d44e85
commit 1cbb356220
11 changed files with 888 additions and 385 deletions
@@ -41,19 +41,32 @@ def test_dataset_workflow_hook_owns_dataset_api_calls() -> None:
def test_app_still_wires_dataset_ui_callbacks() -> None:
app = (ROOT / "frontend" / "src" / "App.tsx").read_text(encoding="utf-8")
dataset_panel = (ROOT / "frontend" / "src" / "components" / "datasets" / "DatasetPanel.tsx").read_text(
encoding="utf-8"
)
detail_panel = (ROOT / "frontend" / "src" / "components" / "datasets" / "DatasetDetailPanel.tsx").read_text(
encoding="utf-8"
)
assert "<form onSubmit={uploadDataset}" in app
assert "onClick={() => loadDatasetDetails(selectedProjectId ?? '', dataset)}" in app
assert "onClick={() => refreshMetadata(dataset.id)}" in app
assert "onClick={runRasterInspect}" in app
assert "onClick={runRasterPreview}" in app
assert "onClick={runRasterStats}" in app
assert "onClick={runRasterReproject}" in app
assert "onClick={runRasterClip}" in app
assert "onClick={runRasterTile}" in app
assert "onClick={runRasterNdvi}" in app
assert "onClick={runRasterNdwi}" in app
assert "onClick={runRasterNdbi}" in app
assert "onClick={runVectorClip}" in app
assert "onClick={runVectorBuffer}" in app
assert "onClick={() => runVectorIntersect(availableVectorTargets)}" in app
assert "<DatasetPanel" in app
assert "onUploadDataset={uploadDataset}" in app
assert "onLoadDatasetDetails={loadDatasetDetails}" in app
assert "onRefreshMetadata={refreshMetadata}" in app
assert "<DatasetDetailPanel" in app
assert "onRunRasterInspect={runRasterInspect}" in app
assert "onRunRasterPreview={runRasterPreview}" in app
assert "onRunRasterStats={runRasterStats}" in app
assert "onRunRasterReproject={runRasterReproject}" in app
assert "onRunRasterClip={runRasterClip}" in app
assert "onRunRasterTile={runRasterTile}" in app
assert "onRunRasterNdvi={runRasterNdvi}" in app
assert "onRunRasterNdwi={runRasterNdwi}" in app
assert "onRunRasterNdbi={runRasterNdbi}" in app
assert "onRunVectorClip={runVectorClip}" in app
assert "onRunVectorBuffer={runVectorBuffer}" in app
assert "onRunVectorIntersect={() => runVectorIntersect(availableVectorTargets)}" in app
assert "<form onSubmit={onUploadDataset}" in dataset_panel
assert "onClick={() => onLoadDatasetDetails(selectedProjectId ?? '', dataset)}" in dataset_panel
assert "onClick={() => onRefreshMetadata(dataset.id)}" in dataset_panel
assert "onRunRasterInspect={onRunRasterInspect}" in detail_panel
assert "onRunVectorIntersect={onRunVectorIntersect}" in detail_panel
@@ -0,0 +1,49 @@
from __future__ import annotations
from pathlib import Path
ROOT = Path(__file__).resolve().parents[2]
def test_app_uses_dataset_presentational_components() -> None:
app = (ROOT / "frontend" / "src" / "App.tsx").read_text(encoding="utf-8")
assert "from './components/datasets/DatasetPanel'" in app
assert "from './components/datasets/DatasetDetailPanel'" in app
assert "<DatasetPanel" in app
assert "<DatasetDetailPanel" in app
assert "<form onSubmit={uploadDataset}" not in app
assert "<h3>Raster operations</h3>" not in app
assert "<h3>Vector operations</h3>" not in app
def test_dataset_panel_owns_upload_and_list_markup() -> None:
panel = (ROOT / "frontend" / "src" / "components" / "datasets" / "DatasetPanel.tsx").read_text(encoding="utf-8")
assert "Upload dataset" in panel
assert "Refresh metadata" in panel
assert "Select / details" in panel
assert "onLoadDatasetDetails" in panel
assert "onRefreshMetadata" in panel
def test_dataset_detail_panel_composes_raster_and_vector_controls() -> None:
detail_panel = (ROOT / "frontend" / "src" / "components" / "datasets" / "DatasetDetailPanel.tsx").read_text(
encoding="utf-8"
)
raster_controls = (ROOT / "frontend" / "src" / "components" / "datasets" / "RasterControls.tsx").read_text(
encoding="utf-8"
)
vector_controls = (ROOT / "frontend" / "src" / "components" / "datasets" / "VectorControls.tsx").read_text(
encoding="utf-8"
)
assert "<RasterControls" in detail_panel
assert "<VectorControls" in detail_panel
assert "Jobs" in detail_panel
assert "Raster operations" in raster_controls
assert "Compute NDVI" in raster_controls
assert "Generate tiles" in raster_controls
assert "Vector operations" in vector_controls
assert "Run intersect" in vector_controls