fix: retain WALOUS edition warnings
This commit is contained in:
@@ -327,9 +327,10 @@ class TemporalAnalysisService:
|
||||
warnings = [
|
||||
"WALOUS-evolutie vergelijkt celgebaseerde landbedekkingsoppervlakten; individuele objectwijzigingen zijn niet beschikbaar.",
|
||||
]
|
||||
limitation = str(later_summary.get("warning") or earlier_summary.get("warning") or "").strip()
|
||||
if limitation:
|
||||
warnings.append(limitation)
|
||||
for summary in (earlier_summary, later_summary):
|
||||
limitation = str(summary.get("warning") or "").strip()
|
||||
if limitation and limitation not in warnings:
|
||||
warnings.append(limitation)
|
||||
return TemporalComparisonResponse(
|
||||
temporal_series_key=str(earlier.temporal_series_key),
|
||||
earlier=TemporalDatasetRef(
|
||||
@@ -497,7 +498,6 @@ class TemporalAnalysisService:
|
||||
earlier_full_dataset_area: bool = False,
|
||||
later_full_dataset_area: bool = False,
|
||||
) -> tuple[TemporalObjectChanges, dict[str, Any], list[str]]:
|
||||
earlier_config = earlier.source_metadata if isinstance(earlier.source_metadata, dict) else {}
|
||||
later_config = later.source_metadata if isinstance(later.source_metadata, dict) else {}
|
||||
earlier_identity = TemporalAnalysisService._identity_contract(earlier)
|
||||
later_identity = TemporalAnalysisService._identity_contract(later)
|
||||
|
||||
@@ -499,7 +499,11 @@ def test_walous_temporal_comparison_reuses_persisted_raster_metrics(
|
||||
}
|
||||
],
|
||||
},
|
||||
"limitation_message": "Cell-based estimate.",
|
||||
"limitation_message": (
|
||||
"2018 crosswalk and methodology limitation."
|
||||
if dataset_id == earlier.id
|
||||
else "2023 edition accuracy limitation."
|
||||
),
|
||||
}
|
||||
|
||||
monkeypatch.setattr(WalousLandCoverService, "analyze", analyze)
|
||||
@@ -523,6 +527,8 @@ def test_walous_temporal_comparison_reuses_persisted_raster_metrics(
|
||||
assert result.metric.later_value == 5.5
|
||||
assert result.metric.absolute_change == 1.5
|
||||
assert result.object_changes.available is False
|
||||
assert "2018 crosswalk and methodology limitation." in result.warnings
|
||||
assert "2023 edition accuracy limitation." in result.warnings
|
||||
|
||||
|
||||
def test_walous_api_routes_use_canonical_envelopes(monkeypatch) -> None:
|
||||
|
||||
Reference in New Issue
Block a user