feat: professionalize platform release 0.3.13

tests/e2e/test_vr114_browser_and_accessibility.py

@@ -9,7 +9,7 @@ from bs4 import BeautifulSoup
 from django.urls import reverse
 from django.utils import timezone
 
-from apps.jobs.models import Application, Feedback, ScoreRun
+from apps.jobs.models import ScoreRun
 
 try:
     from playwright.sync_api import sync_playwright
@@ -85,7 +85,7 @@ def _run_html_accessibility_probe(client, user, profile, job) -> None:
     response = client.get(reverse("dashboard:today"))
     assert response.status_code == 200
     _assert_basic_html_accessibility(response.content, page_name="dashboard")
-    assert "Zoek door vacatures" in response.content.decode("utf-8")
+    assert "Zoek vacatures" in response.content.decode("utf-8")
 
     response = client.get(reverse("jobs:list"), {"q": job.original_title})
     assert response.status_code == 200
@@ -133,17 +133,28 @@ def _run_html_accessibility_probe(client, user, profile, job) -> None:
 def _assert_playwright_accessibility(page, *, expected_h1: str) -> None:
     page.wait_for_load_state("networkidle")
     assert page.get_by_role("heading", level=1).count() == 1
-    assert expected_h1 in page.get_by_role("heading", level=1).all_text_contents()
+    headings = page.get_by_role("heading", level=1).all_text_contents()
+    assert any(expected_h1 in heading for heading in headings)
 
     page.keyboard.press("Tab")
     focused_tag = page.evaluate("document.activeElement.tagName.toLowerCase()")
     assert focused_tag != "body"
-    outline_style = page.evaluate("getComputedStyle(document.activeElement).outlineStyle")
-    assert outline_style != "none"
+    focus_indicator = page.evaluate(
+        """() => {
+            const style = getComputedStyle(document.activeElement);
+            return {outline: style.outlineStyle, shadow: style.boxShadow};
+        }"""
+    )
+    assert focus_indicator["outline"] != "none" or focus_indicator["shadow"] != "none"
+
+    viewport_width = page.evaluate("window.innerWidth")
+    document_width = page.evaluate("document.documentElement.scrollWidth")
+    assert document_width <= viewport_width + 1
 
 
 def _take_failure_screenshot(page, tmp_path: Path, viewport_name: str) -> None:
-    directory = tmp_path / "artifacts"
+    del tmp_path
+    directory = Path(__file__).resolve().parents[2] / "artifacts" / "browser-tests"
     directory.mkdir(parents=True, exist_ok=True)
     page.screenshot(path=str(directory / f"vr114_e2e_failure_{viewport_name}.png"), full_page=True)
 
@@ -159,14 +170,19 @@ def test_vr114_html_a11y_probe(client, user, profile, job):
 @pytest.mark.parametrize(
     "viewport",
     [
-        {"name": "desktop", "width": 1366, "height": 900},
-        {"name": "mobile-360", "width": 360, "height": 780},
+        {"name": "mobile-390", "width": 390, "height": 844},
+        {"name": "tablet-768", "width": 768, "height": 1024},
+        {"name": "laptop-1280", "width": 1280, "height": 800},
+        {"name": "desktop-1920", "width": 1920, "height": 1080},
+        {"name": "wide-2560", "width": 2560, "height": 1440},
+        {"name": "ultrawide-3440", "width": 3440, "height": 1200},
     ],
 )
 def test_vr114_browser_flow(viewport, live_server, client, tmp_path, user, profile, job):
     _seed_dashboard_score(profile=profile, job=job)
 
     if sync_playwright is None:
+        pytest.fail("Playwright is verplicht voor de E2E- en accessibilitygate.")
         _run_html_accessibility_probe(client, user, profile, job)
         pytest.skip("Playwright niet geïnstalleerd. Vult alleen de HTML/a11y-probe in.")
 
@@ -183,6 +199,7 @@ def test_vr114_browser_flow(viewport, live_server, client, tmp_path, user, profi
         try:
             browser = playwright.chromium.launch(headless=True)
         except Exception as exc:  # pragma: no cover - env-dependent
+            pytest.fail(f"Playwright Chromium is verplicht maar niet beschikbaar: {exc}")
             # De afzonderlijke HTML/a11y-probe is altijd uitgevoerd. Buiten de
             # Playwright-context opnieuw databasewerk doen kan Django als async zien.
             pytest.skip(f"Playwright-browser niet beschikbaar: {exc}")
@@ -192,52 +209,58 @@ def test_vr114_browser_flow(viewport, live_server, client, tmp_path, user, profi
             reduced_motion="reduce",
         )
         page = context.new_page()
+        console_errors: list[str] = []
+        page_errors: list[str] = []
+        page.on(
+            "console",
+            lambda message: console_errors.append(message.text)
+            if message.type == "error"
+            else None,
+        )
+        page.on("pageerror", lambda error: page_errors.append(str(error)))
 
         try:
             # Login (e-mailadres + wachtwoord, Stitch-ontwerp).
             page.goto(login_url)
             _assert_playwright_accessibility(page, expected_h1="Inloggen")
             page.get_by_label("E-mailadres").fill(user.email)
-            page.get_by_label("Wachtwoord").fill("correct-horse-battery-staple")
+            page.get_by_role("textbox", name="Wachtwoord", exact=True).fill(
+                "correct-horse-battery-staple"
+            )
             page.get_by_role("button", name="Inloggen").click()
             page.wait_for_url(dashboard_url)
             _assert_playwright_accessibility(page, expected_h1="Goedemorgen")
 
             # Dashboard -> filter -> detail.
-            page.get_by_role("link", name="Vacatures").click()
-            page.get_by_role("textbox", name="Zoeken").fill(job.original_title)
-            page.get_by_role("button", name="Filters toepassen").click()
+            page.goto(jobs_url)
+            page.get_by_label("Zoeken", exact=True).fill(job.original_title)
+            page.get_by_role("button", name="Filter", exact=True).click()
             assert page.url.startswith(jobs_url)
-            page.get_by_role("link", name=job.original_title).first.click()
+            page.get_by_role("link", name="Volledige analyse").click()
             page.wait_for_url(detail_url)
             _assert_playwright_accessibility(page, expected_h1=job.original_title)
 
             # Vier feedbackacties.
             page.get_by_role("button", name="Interessant").click()
-            page.wait_for_selector(".message.success")
+            page.wait_for_selector(".toast.success")
             page.get_by_role("button", name="Bewaren").click()
-            page.wait_for_selector(".message.success")
-            page.get_by_label("Reden (optioneel)").select_option("Te ver")
+            page.wait_for_selector(".toast.success")
             page.get_by_role("button", name="Verbergen").click()
-            page.wait_for_selector(".message.success")
-            page.get_by_role("button", name="Gesolliciteerd").click()
-            page.wait_for_selector(".message.success")
+            page.wait_for_selector(".toast.success")
+            page.get_by_role("button", name="Dossier starten").click()
+            page.wait_for_selector(".toast.success")
 
             # Profiel aanpassen.
-            page.get_by_role("link", name="Zoekprofiel").click()
-            page.wait_for_url(profile_list_url)
-            page.get_by_role("link", name="Profiel bewerken").click()
+            page.goto(profile_list_url)
+            page.get_by_role("link", name="Radar configureren").click()
             page.get_by_label("Infrastructure engineer").check()
             page.get_by_label("System engineer").check()
             page.get_by_role("button", name="Instellingen opslaan").click()
             page.wait_for_url(profile_list_url)
 
             # Sollicitatie dossier openen en bijwerken.
-            application = Application.objects.filter(user=user, job=job).first()
-            assert application is not None
-            page.get_by_role("link", name="Sollicitaties").click()
-            page.wait_for_url(applications_url)
-            page.goto(f"{base}{reverse('jobs:application-edit', kwargs={'pk': application.pk})}")
+            page.goto(applications_url)
+            page.get_by_role("link", name="Open dossier").click()
             page.locator("select[name='status']").select_option("interview")
             page.locator("input[name='contact_name']").fill("Sofie Janssens")
             page.locator("input[name='contact_email']").fill("sofia@example.invalid")
@@ -249,8 +272,7 @@ def test_vr114_browser_flow(viewport, live_server, client, tmp_path, user, profi
             page.wait_for_url(applications_url)
 
             # Handmatige import via plaktekst.
-            page.get_by_role("link", name="Bronnen").click()
-            page.wait_for_url(sources_url)
+            page.goto(sources_url)
             page.locator(".import-disclosure > summary").click()
             page.locator("textarea[name='pasted_text']").fill(
                 "Vacaturetitel: Infrastructure Engineer\nWerkgever: Example IT\nLocatie: Hasselt"
@@ -264,9 +286,10 @@ def test_vr114_browser_flow(viewport, live_server, client, tmp_path, user, profi
             page.keyboard.press("Tab")
             page.keyboard.press("Tab")
             page.keyboard.press("Tab")
-            _assert_playwright_accessibility(page, expected_h1="Bronnen")
+            _assert_playwright_accessibility(page, expected_h1="Scan-endpoints")
+            assert console_errors == []
+            assert page_errors == []
 
-            assert Feedback.objects.filter(user=user, job=job).count() >= 4
         except Exception:
             _take_failure_screenshot(page, tmp_path, viewport["name"])
             raise