"""v1.6.3 ntfy incident notifications.""" from __future__ import annotations from datetime import UTC, datetime, timedelta from pathlib import Path import httpx import pytest from fastapi.testclient import TestClient from app import alerts as alerts_module from app import auth from app import main as main_module from app.alerts import AlertManager, AlertSettingsUpdate from app.discovery import DiscoveryManager from app.discovery_store import DiscoveryStore from app.models import Criticality, IncidentRecord, IncidentStatus from app.store import Store @pytest.fixture() def sent(monkeypatch: pytest.MonkeyPatch) -> list[httpx.Request]: requests: list[httpx.Request] = [] def handler(request: httpx.Request) -> httpx.Response: requests.append(request) return httpx.Response(200, json={"id": "x"}) real_client = httpx.Client def fake_client(*args, **kwargs): kwargs["transport"] = httpx.MockTransport(handler) return real_client(*args, **kwargs) monkeypatch.setattr(alerts_module.httpx, "Client", fake_client) return requests def _incident( store: Store, *, status: IncidentStatus = IncidentStatus.OPEN, severity: Criticality = Criticality.HIGH, detected: datetime, ) -> IncidentRecord: record = IncidentRecord( id="inc-1", status=status, root_service_id="svc", root_service_name="Payments", started_at=detected, detected_at=detected, resolved_at=detected + timedelta(minutes=5) if status == IncidentStatus.RESOLVED else None, title="Payments is down", root_cause_reason="Service is down and no configured dependency is also down", affected_service_ids=["a", "b"], severity=severity, latest_update_at=detected, ) store.upsert_incident(record) return record def _manager(tmp_path: Path, **settings) -> AlertManager: manager = AlertManager(Store(str(tmp_path / "servicemap.db"))) manager.update(AlertSettingsUpdate(enabled=True, ntfy_topic="sm-alerts", public_url="http://sm.lan:1253", **settings)) return manager def test_opened_after_delay_once_then_resolved(tmp_path: Path, sent: list[httpx.Request]) -> None: manager = _manager(tmp_path, delay_seconds=60) detected = datetime.now(UTC) _incident(manager.store, detected=detected) # Within the delay: a short flap stays quiet. assert manager.run_cycle(detected + timedelta(seconds=30)) == 0 assert manager.run_cycle(detected + timedelta(seconds=61)) == 1 # Never twice. assert manager.run_cycle(detected + timedelta(seconds=120)) == 0 request = sent[0] assert str(request.url) == "https://ntfy.sh/sm-alerts" assert request.headers["Title"] == "Uitgevallen: Payments is down" assert request.headers["Priority"] == "urgent" assert request.headers["Click"].startswith("http://sm.lan:1253/#/incidents?incident=inc-1") assert "2 afhankelijke service(s) geraakt" in request.content.decode() _incident(manager.store, status=IncidentStatus.RESOLVED, detected=detected) assert manager.run_cycle(detected + timedelta(minutes=6)) == 1 assert sent[-1].headers["Title"] == "Opgelost: Payments is down" assert manager.run_cycle(detected + timedelta(minutes=7)) == 0 def test_severity_threshold_reminders_and_disabled(tmp_path: Path, sent: list[httpx.Request]) -> None: manager = _manager(tmp_path, delay_seconds=0, min_severity=Criticality.CRITICAL, reminder_minutes=10) detected = datetime.now(UTC) _incident(manager.store, severity=Criticality.HIGH, detected=detected) assert manager.run_cycle(detected + timedelta(minutes=30)) == 0 # below threshold _incident(manager.store, severity=Criticality.CRITICAL, detected=detected) assert manager.run_cycle(detected + timedelta(seconds=1)) == 1 # opened assert manager.run_cycle(detected + timedelta(minutes=10, seconds=1)) == 1 # reminder 1 assert manager.run_cycle(detected + timedelta(minutes=12)) == 0 assert sent[-1].headers["Title"].startswith("Nog steeds uitgevallen") manager.update(AlertSettingsUpdate(enabled=False, ntfy_topic="sm-alerts")) assert manager.run_cycle(detected + timedelta(minutes=50)) == 0 def test_settings_validation_and_secret_token(tmp_path: Path) -> None: manager = AlertManager(Store(str(tmp_path / "servicemap.db"))) with pytest.raises(ValueError, match="topic"): manager.update(AlertSettingsUpdate(enabled=True, ntfy_topic="")) with pytest.raises(ValueError): AlertSettingsUpdate(ntfy_topic="bad topic!") with pytest.raises(ValueError): AlertSettingsUpdate(ntfy_server="file:///etc/passwd") view = manager.update(AlertSettingsUpdate(ntfy_topic="t", ntfy_token="secret-value")) assert view.ntfy_token_set and "secret-value" not in view.model_dump_json() # None keeps the token, "" removes it. assert manager.update(AlertSettingsUpdate(ntfy_topic="t")).ntfy_token_set assert not manager.update(AlertSettingsUpdate(ntfy_topic="t", ntfy_token="")).ntfy_token_set def test_settings_routes_need_the_token_even_to_read( tmp_path: Path, monkeypatch: pytest.MonkeyPatch, sent: list[httpx.Request] ) -> None: main_module.store = Store(str(tmp_path / "servicemap.db")) main_module.discovery_store = DiscoveryStore(main_module.store) main_module.discovery_manager = DiscoveryManager(main_module.store, main_module.discovery_store) monkeypatch.setenv("SERVICEMAP_DB", str(tmp_path / "servicemap.db")) monkeypatch.setenv("SERVICEMAP_AUTH_MODE", "token") monkeypatch.delenv("SERVICEMAP_ADMIN_TOKEN_FILE", raising=False) auth.reset_token_cache() client = TestClient(main_module.app) try: assert client.get("/api/v1/settings/alerts").status_code == 401 assert client.get("/api/v1/services").status_code == 200 # ordinary reads stay open token = auth.admin_token() headers = {"Authorization": f"Bearer {token}"} saved = client.put( "/api/v1/settings/alerts", json={"enabled": True, "ntfy_topic": "sm-test", "ntfy_token": "tk-123"}, headers=headers, ) assert saved.status_code == 200 and saved.json()["ntfy_token_set"] is True assert "tk-123" not in client.get("/api/v1/settings/alerts", headers=headers).text result = client.post("/api/v1/settings/alerts/test", headers=headers).json() assert result["ok"] is True assert sent[-1].headers["Authorization"] == "Bearer tk-123" finally: auth.reset_token_cache()