"""v1.6.3 guards against silent data corruption.""" from __future__ import annotations import sqlite3 from datetime import UTC, datetime from pathlib import Path from app.discovery import DiscoveryManager from app.discovery_store import DiscoveryStore from app.models import ( EdgeMutationRequest, IncidentRecord, IncidentStatus, ServiceCreate, ServiceKind, ) from app.store import Store def _service(store: Store, name: str): return store.create_service(ServiceCreate(name=name, kind=ServiceKind.HTTP, url=f"https://{name.lower()}.test")) def test_deleting_a_service_removes_it_from_open_incidents_as_a_json_element(tmp_path: Path) -> None: store = Store(str(tmp_path / "servicemap.db")) root = _service(store, "Root") first = _service(store, "First") second = _service(store, "Second") now = datetime.now(UTC) store.upsert_incident( IncidentRecord( id="inc-1", status=IncidentStatus.OPEN, root_service_id=root.id, root_service_name=root.name, started_at=now, detected_at=now, title="Root is down", root_cause_reason="test", affected_service_ids=[first.id, second.id], latest_update_at=now, ) ) assert store.delete_service(first.id) incident = next(item for item in store.list_incidents(active_only=True) if item.id == "inc-1") # Previously a textual replace() left an empty-string element behind. assert incident.affected_service_ids == [second.id] def test_repeating_a_manual_edge_does_not_create_duplicate_evidence(tmp_path: Path) -> None: store = Store(str(tmp_path / "servicemap.db")) discovery = DiscoveryStore(store) manager = DiscoveryManager(store, discovery) api = _service(store, "API") database = _service(store, "Database") request = EdgeMutationRequest(source_service_id=api.id, target_service_id=database.id) first = manager.apply_edge(request) second = manager.apply_edge(request) assert first.id == second.id with sqlite3.connect(store.path) as db: count = db.execute( "SELECT COUNT(*) FROM relation_evidence WHERE source_service_id=? AND target_service_id=? AND evidence_type='manual'", (api.id, database.id), ).fetchone()[0] assert count == 1