"""v1.6.3 security baseline: admin token for writes, origin/host checks, limits.""" from __future__ import annotations from pathlib import Path import pytest from fastapi.testclient import TestClient from starlette.requests import Request from app import auth from app import main as main_module from app.config_io import parse_document from app.discovery import DiscoveryManager from app.discovery_store import DiscoveryStore from app.store import Store SERVICE = {"name": "API", "kind": "http", "url": "https://api.test"} @pytest.fixture() def client(tmp_path: Path, monkeypatch: pytest.MonkeyPatch) -> TestClient: main_module.store = Store(str(tmp_path / "servicemap.db")) main_module.discovery_store = DiscoveryStore(main_module.store) main_module.discovery_manager = DiscoveryManager(main_module.store, main_module.discovery_store) monkeypatch.setenv("SERVICEMAP_DB", str(tmp_path / "servicemap.db")) monkeypatch.delenv("SERVICEMAP_ADMIN_TOKEN_FILE", raising=False) monkeypatch.delenv("SERVICEMAP_ALLOWED_HOSTS", raising=False) auth.reset_token_cache() yield TestClient(main_module.app) auth.reset_token_cache() def test_token_mode_keeps_reads_open_and_requires_the_token_for_writes( client: TestClient, tmp_path: Path, monkeypatch: pytest.MonkeyPatch ) -> None: monkeypatch.setenv("SERVICEMAP_AUTH_MODE", "token") assert client.get("/api/v1/services").status_code == 200 assert client.get("/api/v1/topology/semantic").status_code == 200 refused = client.post("/api/v1/services", json=SERVICE) assert refused.status_code == 401 assert refused.headers["www-authenticate"] == "Bearer" assert client.post( "/api/v1/services", json=SERVICE, headers={"Authorization": "Bearer wrong-token-value-123456789"} ).status_code == 401 token_file = tmp_path / "admin-token" assert token_file.exists() # generated on first use, next to the database token = token_file.read_text(encoding="utf-8").strip() assert len(token) >= 24 headers = {"Authorization": f"Bearer {token}"} assert client.post("/api/v1/services", json=SERVICE, headers=headers).status_code == 201 assert client.post("/api/v1/auth/verify", headers=headers).json() == {"ok": True} assert client.get("/api/v1/meta").json()["write_auth"] == "admin_token" # The token is stable across reads and never regenerated over a file. auth.reset_token_cache() assert auth.admin_token() == token def test_too_short_admin_token_file_refuses_writes( client: TestClient, tmp_path: Path, monkeypatch: pytest.MonkeyPatch ) -> None: monkeypatch.setenv("SERVICEMAP_AUTH_MODE", "token") short = tmp_path / "short-token" short.write_text("too-short\n", encoding="utf-8") monkeypatch.setenv("SERVICEMAP_ADMIN_TOKEN_FILE", str(short)) response = client.post("/api/v1/services", json=SERVICE, headers={"Authorization": "Bearer too-short"}) assert response.status_code == 503 def test_cross_site_mutations_are_refused_even_without_authentication(client: TestClient) -> None: # disabled mode: no token, but a browser on another site cannot write. assert client.post( "/api/v1/services", json=SERVICE, headers={"Origin": "https://evil.example"} ).status_code == 403 assert client.post( "/api/v1/maintenance/prune", headers={"Sec-Fetch-Site": "cross-site"} ).status_code == 403 assert client.post("/api/v1/services", json=SERVICE, headers={"Origin": "null"}).status_code == 403 # Same origin and header-less clients (curl, integrations) still work. assert client.post( "/api/v1/services", json=SERVICE, headers={"Origin": "http://testserver"} ).status_code == 201 assert client.post( "/api/v1/services", json={**SERVICE, "name": "Worker"} ).status_code == 201 # Behind nginx/NPM the Host may lose the port while Origin keeps it, or # the public name arrives as X-Forwarded-Host. assert client.post( "/api/v1/services", json={**SERVICE, "name": "Proxied"}, headers={"Host": "192.0.2.10", "Origin": "http://192.0.2.10:1253"}, ).status_code == 201 assert client.post( "/api/v1/services", json={**SERVICE, "name": "Forwarded"}, headers={"Host": "backend:8000", "X-Forwarded-Host": "servicemap.lan", "Origin": "https://servicemap.lan"}, ).status_code == 201 assert client.post( "/api/v1/services", json={**SERVICE, "name": "Spoofed"}, headers={"Host": "192.0.2.10:1253", "Origin": "http://192.0.2.11:1253"}, ).status_code == 403 # Reads are not affected by the Origin rule. assert client.get("/api/v1/services", headers={"Origin": "https://evil.example"}).status_code == 200 def test_optional_host_allowlist_blocks_rebinding_but_keeps_loopback( client: TestClient, monkeypatch: pytest.MonkeyPatch ) -> None: monkeypatch.setenv("SERVICEMAP_ALLOWED_HOSTS", "servicemap.lan,192.0.2.10") assert client.get("/api/v1/services", headers={"Host": "attacker.example"}).status_code == 400 assert client.get("/api/v1/services", headers={"Host": "192.0.2.10:1253"}).status_code == 200 assert client.get("/health", headers={"Host": "127.0.0.1:8000"}).status_code == 200 def test_security_headers_body_limit_and_yaml_aliases(client: TestClient) -> None: response = client.get("/health") assert response.headers["x-content-type-options"] == "nosniff" assert response.headers["x-frame-options"] == "DENY" assert "frame-ancestors 'none'" in response.headers["content-security-policy"] oversized = client.post( "/api/v1/config/import", content=b"x", headers={"Content-Length": str(5 * 1024 * 1024), "Content-Type": "application/json"}, ) assert oversized.status_code == 413 bomb = "a: &a [x, x]\nb: &b [*a, *a]\nc: [*b, *b]\n" with pytest.raises(ValueError, match="anchors of -aliassen"): parse_document(bomb, "yaml") def _request(method: str, path: str) -> Request: return Request({"type": "http", "method": method, "path": path, "headers": [], "query_string": b""}) def test_oidc_role_requirements_cover_export_and_demo() -> None: assert auth.required_role(_request("GET", "/api/v1/services")) == "viewer" assert auth.required_role(_request("GET", "/api/v1/config")) == "admin" assert auth.required_role(_request("POST", "/api/v1/demo")) == "admin" assert auth.required_role(_request("POST", "/api/v1/demo/reset")) == "admin" assert auth.required_role(_request("PUT", "/api/v1/services/x")) == "operator" def test_cache_headers_keep_the_ui_current_after_a_deploy(client: TestClient) -> None: # index.html (served by the SPA fallback / static mount) must revalidate. response = client.get("/", follow_redirects=True) if response.status_code == 200: assert response.headers.get("cache-control") == "no-cache" api = client.get("/api/v1/services") assert "immutable" not in api.headers.get("cache-control", "")