NuklearRabbit
ddc3a98e4b
Fixes a real honesty bug in Knowledge.tsx (body copy named "RAGcore" while the active provider is the demo one) and a second real bug discovered while fixing it: the brief's suggested Dutch questions would silently return "insufficient evidence" against the English-only demo knowledge base -- verified empirically and fixed by keeping suggested questions in English. The return flow now pre-fills the odometer-regression scenario's suspicious reading instead of asking a visitor to invent one, and links to automation/audit after committing. Data-quality issues get a shared plain-language "what's wrong / why it matters" explainer per rule type, a post-resolution confirmation with audit/vehicle links, and a "demo scenario's only" list filter. Also fixes a real async race where the odometer pre-fill could clobber text a visitor had already started typing.
78 lines
3.8 KiB
TypeScript
78 lines
3.8 KiB
TypeScript
import { expect, test, type APIRequestContext } from "@playwright/test";
|
|
|
|
async function resetDemoData(request: APIRequestContext) {
|
|
const login = await request.post("/api/v1/demo/login", { data: { role: "operations_manager" } });
|
|
expect(login.ok()).toBeTruthy();
|
|
const reset = await request.post("/api/v1/demo/reset");
|
|
expect(reset.ok()).toBeTruthy();
|
|
}
|
|
|
|
test.describe.configure({ mode: "serial" });
|
|
|
|
test("return flow pre-fills the suspicious odometer reading and explains why", async ({ page, request }) => {
|
|
await resetDemoData(request);
|
|
await page.goto("/login");
|
|
await page.getByRole("button", { name: "Verken als Operations Manager" }).click();
|
|
await expect(page).toHaveURL(/\/dashboard$/);
|
|
await page.goto("/bookings/BK-DEMO-RETURN");
|
|
|
|
await expect(page.getByText("Demonstratiescenario: afwijkende kilometerstand")).toBeVisible();
|
|
const odometerInput = page.getByLabel("End odometer (km)");
|
|
await expect(odometerInput).not.toHaveValue("");
|
|
const prefilled = Number(await odometerInput.inputValue());
|
|
expect(prefilled).toBeGreaterThan(0);
|
|
|
|
await page.getByRole("button", { name: "Review return" }).click();
|
|
await expect(page.getByText(/below.*canonical reading/)).toBeVisible();
|
|
await page.getByRole("button", { name: "Confirm return" }).click();
|
|
await expect(page.getByRole("heading", { name: "Return registered" })).toBeVisible();
|
|
await expect(page.getByRole("link", { name: "View automation status" })).toBeVisible();
|
|
await expect(page.getByRole("link", { name: "View audit trail" })).toBeVisible();
|
|
});
|
|
|
|
test("data quality issue detail explains what's wrong and why it matters", async ({ page }) => {
|
|
await page.goto("/login");
|
|
await page.getByRole("button", { name: "Verken als Operations Manager" }).click();
|
|
await expect(page).toHaveURL(/\/dashboard$/);
|
|
await page.goto("/data-quality/DQ-DEMO-DUPLICATE");
|
|
|
|
await expect(page.getByText("What's wrong")).toBeVisible();
|
|
await expect(page.getByText("Why it matters")).toBeVisible();
|
|
await expect(page.getByText(/likely the same person/)).toBeVisible();
|
|
});
|
|
|
|
test("data quality list can filter to demo scenarios only", async ({ page }) => {
|
|
await page.goto("/login");
|
|
await page.getByRole("button", { name: "Verken als Operations Manager" }).click();
|
|
await expect(page).toHaveURL(/\/dashboard$/);
|
|
await page.goto("/data-quality");
|
|
|
|
await expect(page.locator(".data-table tbody tr").first()).toBeVisible();
|
|
const allRows = await page.locator(".data-table tbody tr").count();
|
|
await page.getByRole("checkbox", { name: "Demo scenario's only" }).check();
|
|
const filteredRows = await page.locator(".data-table tbody tr").count();
|
|
expect(filteredRows).toBeGreaterThan(0);
|
|
expect(filteredRows).toBeLessThanOrEqual(allRows);
|
|
const refs = await page.locator(".data-table tbody tr th a").allTextContents();
|
|
for (const ref of refs) {
|
|
expect(ref.startsWith("DQ-DEMO-")).toBeTruthy();
|
|
}
|
|
});
|
|
|
|
test("knowledge page suggested question returns a grounded, honestly-labelled answer", async ({ page }) => {
|
|
await page.goto("/login");
|
|
await page.getByRole("button", { name: "Verken als Operations Manager" }).click();
|
|
await expect(page).toHaveURL(/\/dashboard$/);
|
|
await page.goto("/knowledge");
|
|
|
|
// The status badge and retrieval-flow diagram must name the actual active provider
|
|
// honestly, not the not-yet-connected "RAGcore" -- the honest disclosure note below is
|
|
// allowed to mention RAGcore by name when explaining it isn't live yet.
|
|
await expect(page.locator(".knowledge-status strong")).toHaveText("Demo knowledge base");
|
|
await expect(page.locator(".retrieval-flow")).toContainText("Demo knowledge base");
|
|
await expect(page.locator(".knowledge-status")).not.toContainText("RAGcore");
|
|
|
|
await page.getByRole("button", { name: "Who reviews an unusual odometer reading?" }).click();
|
|
await expect(page.getByText("Grounded in cited procedures")).toBeVisible();
|
|
});
|