M39: harden application and acceptance gates

frontend/src/pages/DataQuality.tsx

@@ -51,12 +51,13 @@ export function DataQuality() {
       if (value === null || value === "" || value === false) next.delete(key);
       else next.set(key, String(value));
     });
-    setSearchParams(next);
+    setSearchParams(next, { replace: true });
   }
 
   const load = useCallback(() => {
     if (user?.role !== "operations_manager") return;
-    setIssues(null);
+    // Keep the current rows visible while a filter change refetches (stale-while-revalidate);
+    // the initial load still shows the loading state because `issues` starts as null.
     setError(null);
     const params = new URLSearchParams();
     if (status) params.set("status", status);
@@ -64,13 +65,14 @@ export function DataQuality() {
     if (severity) params.set("severity", severity);
     if (assignee) params.set("assigned_to_ref", assignee);
     if (overdueOnly) params.set("overdue", "true");
+    if (demoScenariosOnly) params.set("demo_only", "true");
     params.set("page", String(page));
     params.set("page_size", "25");
     api
       .get<Page<DataQualityIssue>>(`/api/v1/data-quality/issues?${params.toString()}`)
       .then(setIssues)
       .catch(() => setError(t("list.unavailable")));
-  }, [status, ruleType, severity, assignee, overdueOnly, page, user, t]);
+  }, [status, ruleType, severity, assignee, overdueOnly, demoScenariosOnly, page, user, t]);
 
   useEffect(() => {
     load();
@@ -145,6 +147,8 @@ export function DataQuality() {
   }
 
   const scanTotal = scanResult ? Object.values(scanResult.created).reduce((a, b) => a + b, 0) : 0;
+  // The demo-scenario filter is applied server-side (so it spans all pages); the client-side
+  // guard only bridges the moment between toggling the box and the filtered page arriving.
   const visibleIssues = issues
     ? demoScenariosOnly
       ? issues.items.filter((i) => i.public_ref.startsWith("DQ-DEMO-"))
@@ -311,7 +315,7 @@ export function DataQuality() {
               </tr>
             ))}
           </tbody>
-        </table>{issues && !demoScenariosOnly && <Pagination page={issues.page} totalPages={issues.total_pages} onPageChange={(nextPage) => updateFilters({ page: nextPage })} />}</div>
+        </table>{issues && <Pagination page={issues.page} totalPages={issues.total_pages} onPageChange={(nextPage) => updateFilters({ page: nextPage })} />}</div>
       )}
     </div>
   );