M54: harden operations and demo resilience

frontend/e2e/demo.spec.ts

@@ -1,4 +1,10 @@
 import { expect, test, type APIRequestContext } from "@playwright/test";
+import type {
+  AuditEvent,
+  AutomationRun,
+  DataQualityIssueDetail,
+  RegisterReturnResult,
+} from "../src/api/types";
 
 async function resetDemoData(request: APIRequestContext) {
   const login = await request.post("/api/v1/demo/login", {
@@ -12,6 +18,8 @@ async function resetDemoData(request: APIRequestContext) {
 test.describe.configure({ mode: "serial" });
 
 test("five-minute demo script end to end", async ({ page, request }) => {
+  const proof: { returned?: RegisterReturnResult } = {};
+
   // Reset via a throwaway API session so the UI test starts from the deterministic seed
   // regardless of what earlier test runs mutated (S1 return, S2 merge, etc.).
   await resetDemoData(request);
@@ -50,14 +58,66 @@ test("five-minute demo script end to end", async ({ page, request }) => {
     await page.getByLabel("Brandstofniveau (%)").fill("55");
     await page.getByRole("button", { name: "Retour nakijken" }).click();
     await expect(page.getByRole("heading", { name: "Retourimpact nakijken" })).toBeVisible();
+
+    const returnResponsePromise = page.waitForResponse(
+      (response) =>
+        response.request().method() === "POST" &&
+        response.url().endsWith("/api/v1/bookings/BK-DEMO-RETURN/return"),
+    );
     await page.getByRole("button", { name: "Retour bevestigen" }).click();
+    const returnResponse = await returnResponsePromise;
+    expect(returnResponse.status()).toBe(201);
+    proof.returned = (await returnResponse.json()) as RegisterReturnResult;
 
     await expect(page.getByRole("heading", { name: "Retour geregistreerd" })).toBeVisible();
   });
 
-  await test.step("5. verify quality issue and queued automation event", async () => {
-    await expect(page.getByText(/DQ-RET-|Geen aangemaakt/)).toBeVisible();
+  await test.step("5. verify the persisted quality issue, outbox event and audit trace", async () => {
+    const returned = proof.returned;
+    if (!returned) throw new Error("The return API response was not captured");
+
+    expect(returned.odometer_regression).toBe(true);
+    expect(returned.quality_issue_ref).toMatch(/^DQ-RET-/);
+    const qualityIssueRef = returned.quality_issue_ref;
+    if (!qualityIssueRef) throw new Error("The regression return did not create a quality issue");
+
+    await expect(page.getByRole("link", { name: qualityIssueRef })).toBeVisible();
     await expect(page.getByText(/Klaargezet voor verwerking \(/)).toBeVisible();
+
+    // Use the page-bound request context: the throwaway reset session above is
+    // deliberately invalidated by reset, while this context shares the manager login
+    // cookie established in step 1.
+    const issueResponse = await page.request.get(`/api/v1/data-quality/issues/${qualityIssueRef}`);
+    expect(issueResponse.ok()).toBeTruthy();
+    const issue = (await issueResponse.json()) as DataQualityIssueDetail;
+    expect(issue.public_ref).toBe(qualityIssueRef);
+    expect(issue.rule_type).toBe("odometer_regression");
+    expect(issue.status).toBe("open");
+    expect(issue.entity_ref).toBe(returned.vehicle_ref);
+
+    const workflowsResponse = await page.request.get("/api/v1/workflows");
+    expect(workflowsResponse.ok()).toBeTruthy();
+    const workflows = (await workflowsResponse.json()) as AutomationRun[];
+    const workflow = workflows.find((run) => run.event_id === returned.workflow_event_id);
+    expect(workflow).toBeDefined();
+    expect(workflow).toMatchObject({
+      event_type: "vehicle.returned.v1",
+      aggregate_ref: returned.booking_ref,
+    });
+
+    const auditResponse = await page.request.get(
+      `/api/v1/audit?correlation_id=${encodeURIComponent(returned.correlation_id)}`,
+    );
+    expect(auditResponse.ok()).toBeTruthy();
+    const trace = (await auditResponse.json()) as AuditEvent[];
+    expect(trace.map((event) => event.action)).toEqual(
+      expect.arrayContaining([
+        "data_quality_issue_created",
+        "return_registered",
+        "vehicle_status_changed",
+      ]),
+    );
+    expect(trace.every((event) => event.correlation_id === returned.correlation_id)).toBe(true);
   });
 
   await test.step("6. resolve the duplicate customer scenario (S2)", async () => {