M54: harden operations and demo resilience

backend/app/services/returns.py

@@ -4,7 +4,7 @@ import hashlib
 import json
 import uuid
 from dataclasses import dataclass
-from datetime import UTC, datetime, timedelta
+from datetime import UTC, datetime
 
 from sqlalchemy import select
 from sqlalchemy.exc import IntegrityError
@@ -12,13 +12,13 @@ from sqlalchemy.orm import Session
 
 from app.core.errors import AppError
 from app.models.booking import Booking
-from app.models.data_quality import DataQualityIssue
 from app.models.idempotency import IdempotencyRecord
 from app.models.inspection import Inspection
 from app.models.outbox import OutboxEvent
 from app.models.vehicle import Vehicle
 from app.schemas import CurrentUser, RegisterReturnRequest
 from app.services.audit import record_audit_event
+from app.services.data_quality import open_odometer_regression_issue
 
 
 def _new_inspection_ref() -> str:
@@ -261,28 +261,21 @@ def register_vehicle_return(
 
     quality_issue_ref: str | None = None
     if evaluation.odometer_regression:
-        issue = DataQualityIssue(
-            public_ref=f"DQ-RET-{str(inspection.public_ref).split('-')[-1]}",
-            rule_type="odometer_regression",
-            entity_type="vehicle",
-            entity_id=vehicle.id,
-            severity="medium",
-            status="open",
-            evidence_json={
-                "summary": (
-                    f"Return submitted {body.end_odometer_km} km, below canonical "
-                    f"{evaluation.canonical_odometer_km} km."
-                ),
-                "entity_ref": vehicle.public_ref,
-                "related_refs": [booking.public_ref, inspection.public_ref],
-            },
-            proposed_action_json={},
+        issue = open_odometer_regression_issue(
+            db,
+            vehicle=vehicle,
+            reading_ref=inspection.public_ref,
+            reading_km=body.end_odometer_km,
+            canonical_km=evaluation.canonical_odometer_km,
+            source_type="return",
+            related_refs=[booking.public_ref, inspection.public_ref],
+            correctable_booking_refs=[booking.public_ref],
             detected_at=now,
-            due_at=now + timedelta(days=1),
+            public_ref=f"DQ-RET-{str(inspection.public_ref).split('-')[-1]}",
+            actor_label=actor.display_name,
+            correlation_id=correlation_id,
         )
-        db.add(issue)
-        db.flush()
-        quality_issue_ref = issue.public_ref
+        quality_issue_ref = issue.public_ref if issue is not None else None
 
     resulting_status = evaluation.resulting_vehicle_status
     vehicle.odometer_km = evaluation.resulting_odometer_km