fix: make packaged updater handshake Windows-safe

README.md

@@ -4,7 +4,7 @@
 
 ForgeFlow is een Windows-desktopapp voor wie Git, Gitea en eigen Docker- of Unraid-servers gebruikt. Je ziet in één werkruimte wat lokaal gewijzigd is, wat op Gitea staat en welke exacte commit op de server draait. ForgeFlow begeleidt je daarna veilig door review, commit, push, deployment en verificatie.
 
-> Huidige release: **0.10.3** · [download de laatste Windows-release](https://gitea.itworx.tech/Jens/ForgeFlow/releases/latest)
+> Huidige release: **0.10.4** · [download de laatste Windows-release](https://gitea.itworx.tech/Jens/ForgeFlow/releases/latest)
 
 ![ForgeFlow release-overzicht](docs/screenshots/overview.png)
 

SOURCE_MANIFEST.txt

@@ -1,4 +1,4 @@
-ForgeFlow 0.10.3 source manifest
+ForgeFlow 0.10.4 source manifest
 SHA-256                                                          BYTES  PATH
 (The manifest excludes itself, dependencies and generated release artifacts.)
 cedceb71eb846d99c7c4019031833c1c7f93b84a1c6073aec7d2435dc744ca3d           703  .gitea/workflows/quality.yml
@@ -36,6 +36,7 @@ f79908fb3dad98c38030c6e6be7c79a1999e0478ed9c2496923891954438daa1          4581
 0eb44bda2209a5979a6ac693ac4cd4d235c0015031e54b9e895990f37bf60054          1433  docs/RELEASE_NOTES_0.10.1.md
 8d713471a437a8a55b00d7e1dd95290680862107bc4e586cf27d727f6274e46c           577  docs/RELEASE_NOTES_0.10.2.md
 0942fb2c4a4f972296423b5232687f7389e2c6417a9d48a3244beef9dec907b9          1164  docs/RELEASE_NOTES_0.10.3.md
+8f4a0fe6dc250ae210cc2fc1c57c46091822ae6c2a58caa76e0091f255f9f30d           775  docs/RELEASE_NOTES_0.10.4.md
 a0c00ff76acd1682bb5e0e8dcf6589c9480da436c9c6d30780a1ed58b4dad94f          1770  docs/RELEASE_NOTES_0.2.0.md
 5773ead01aa4c522c556295553787482d01b1f5242f053b2c61f120c4de4fa76          5963  docs/RELEASE_NOTES_0.3.0.md
 d46de73cf6c4cd5c2ba3f455a7a2af2e0d64ee9d94a97fd1a0bfb44e35c1624a          1093  docs/RELEASE_NOTES_0.3.1.md
@@ -97,19 +98,19 @@ c230b931abf2293d2d44b7a69b94c35f1142c093cc46b88739a0de5cbd6d1896          1532
 4a561ead5ba7cdfaf4efce91842a4308c5f2a77980205879d83835efb8a579db          1067  LICENSE
 1f0f388df4397e548887bbc7579fd3c864581b86469c01703201ece7a6cbf931         13667  main.cjs
 91a984a89dd57a084b9a2331763cacdb061582fb590f13df379d92c1a77a2ee1           352  OVERLAY-INSTRUCTIONS.md
-672410b1af3900733c067cf29ecaffb96a33500ccbd597bebe999e0c06b161e0        179806  package-lock.json
+58e26cc15df56efc6413b7c45a3dda0997a86758616da9c2479ef859091d475f        179806  package-lock.json
-70d4bafa0f9633bfdef297bb2599c90ff224cf10b69134ad74c77ee574ce49ce          5436  package.json
+5b51588b7ef64f3a94ecad5fb5e5df4b26640614fdf5d69851875741a17e0c72          5474  package.json
 2a597a5704c576783b8a72407fbc377fa7506b36a4596ea7f7bce126e394f837          1326  playwright.config.mjs
 69318fdf054be7aa2fe86ead9847da9da65745d8d5de548c8346f3ba0afc4892         12175  preload.cjs
 abe5dd6fd68f2970cd19ef134094907c67219061d8fe9a1a08324c78de4ad437           484  PUBLISH-AND-ENABLE-UPDATE.cmd
 f018383f755352ca448e2ebb1e19b1dba412a3eb793d61e64b02953e300754fd         10538  Publish-ForgeFlow-Release.ps1
 688fff7d2c989adb97ebb7fae38962656b70304a0aa5d27433c56adf7f136de0          4196  Publish-Missing-Binary-Release.ps1
-9e95c2fe6bca120bd2f7502afe9cf9d6a2aa0ee128261cccc955dd9b94ade833         10313  README.md
+ae6ee934ace29cf16106b40ea669578b4d4f754dae0c06e162820a1d66d9ff0d         10313  README.md
 1fa7bf646321e07e40d98f4a7529d5f748c600edd5283f62ee13574b4e97280f         14329  reports/architecture-audit.json
 c1ff18f1367691332b189bb7589843a5e0bbde4817e3dd29df4ade7ea71dbd52          1114  reports/architecture-audit.md
 509c7bcff5280349bd9f45ed6151f70372bad7010a9ea582c13e2ccab91fe0cd          6272  scripts/acceptance.mjs
-00d57bda5af8c8eda294b72d18b318f024a307b81b0d9205a0821f5240151e31          3814  scripts/apply-binary-update.ps1
+8fe616851e6a089a59fd134905465019c33d26f6408ebd0613fff587b6c589e0          4400  scripts/apply-binary-update.ps1
-f8359a69d20deb2dfe10042d1bec7b12a95e76e58e36bc5f265f073c3111d056         10287  scripts/apply-source-update.ps1
+706b49e001837c91134044d3af132d58fb14955245bc1d5c36b413eb65867002         10486  scripts/apply-source-update.ps1
 02e924227f6cad3777fd06660230c85df590d8ce95e134194a4d18970a240b88          4145  scripts/architecture-audit.mjs
 4490bed84761f76e1fd87ee3117fe53e82e60b7760329c97d68772d6d820ebae          8521  scripts/audit-installed-deployments.cjs
 6d46dd6826069d842f20f9f22a99042257db936cdea0bee8d294d2d7ea290126          3893  scripts/doctor.mjs
@@ -120,7 +121,7 @@ b83d443f5724ac15393567f3a688aed8315fbe3e5966832c864a9466e0669464          8102
 c76507857292c5713e1c699cf02e24b80265da39af2cecd148034bdb874adbb6          5246  scripts/test-authenticode-chain.ps1
 4393f7dc5f417e6d601a68238f4e26791799a3634acec228fe4d79deaee85eb5          3109  scripts/validate-installed-connections.cjs
 e6127e1e62f39c70ddb1abf72f4d7e7b8e3f19ff1f219e1a3660353c2e0cdfac          2411  scripts/verify-release-signatures.mjs
-c1763bad24b747051ad18d911ba9c7176882663e3b6ce9921a2f8b1aae056bd7         18156  scripts/verify.mjs
+f32f00dc6740019578e811d9fa1b8c38592394475005a5a98360f94fdac7b81d         18500  scripts/verify.mjs
 0b9f03ba3c67ff7cdb2916a902ad8ce25e81a7c90b210e4ae52d2ad029efabf3          2353  scripts/write-release-checksums.mjs
 619515f524cb89960370ffcbd3fafd3c0e178b95f69c5868b1dd44777f23ec1e          2081  setup-windows.ps1
 dd613d04b366f2cd071a1685a414016a5fb008082ed1b4cb8b24b79c100f640a          2412  src/main/audit-service.cjs
@@ -175,7 +176,7 @@ eef2f269ba4fbb76bf66ad328d481b461255d0acb753b30878dd4d4eaac57dc6          6924
 a84da5aecbb16ce7983dba1f6d6aab1bf47b2e9a87c2933fa1afb8123f7ef7d6          1497  src/renderer/index.html
 06180d9656dd254edfb6949c397f8e313954fc560ddcb22b3a35fce3c3e35655         21350  src/renderer/mock-bridge.js
 9fa522dad0088e2981c4ca5c392e93d6c92e04ff23fd1083d9040a3aa52d2b55         28101  src/renderer/mock-deployment-bridge.js
-948369ce1bfbc31becc95996feabccd6ae90c6297217f04149b78bd323d279f7         20032  src/renderer/mock-repository-bridge.js
+123518a4cfd47b7e510ffab9102a2fd82edc93754aaabd7bc0259d51dfce5d63         20032  src/renderer/mock-repository-bridge.js
 94fa265c2fe9ca8d644f0ce9b620b6f85d9b25dca5802c4e9195b66dcbe80120          6522  src/renderer/operations.js
 6776e0adb690b8f36274bfc5b31e3140054893c46ba64621c4f56a0d91b52fc2         78323  src/renderer/styles.css
 1703e64533b7e2717b27c5776296c7dd76331e6f97e8005aea9fd688f1aee3ae         94834  src/renderer/views.js
@@ -224,7 +225,7 @@ e631e9ca49a5bac7075860aac2ff4d377a32a78377b70e06ecf833f0f192fd5f         11552
 0d1bc4d623ce299337736c577ec61c8ffd6974ebe20335b72838d10eae35ecb1          7993  tests/ssh-service.test.mjs
 8a6a8477eb94b85ccef18cddd2640afb0d1eafa679c96bc7de20428d5d69e1be          1794  tests/tool-invocation.test.mjs
 4182b61e395aff310b9a964c973a43c3566df0b44c454054c3abdd9459e86e3b         49134  tests/unraid-deployment.test.mjs
-edec1007826bff6b5457fca603d8c816a9e1eedb3ce398269f151144ae3d2197         19764  tests/update-service.test.mjs
+074031cac5018aa74c2bb57ecaf114521d69da707aa6170dda65983690bb1691         21487  tests/update-service.test.mjs
 9cea5c1d5ba3e0972a0b5c7236cf1f7c5616373e0a39ea4a492ecebf70452e40           948  tests/validation.test.mjs
 7ef4d4b9f5f3e6979293b29d571ce0e39f83197f3cade2d999a9cea7bacdd84d          1781  tests/zip-writer.test.mjs
 8f36b542736f2933bad8b9464ad7fa37b68196009c81cf702ce3b677cd637dea           767  UPDATE_FROM_0.3.2.md

docs/RELEASE_NOTES_0.10.4.md

@@ -0,0 +1,9 @@
+# ForgeFlow 0.10.4
+
+## Permanent packaged updater handshake repair
+
+- Binary and source update helpers now use a Windows PowerShell 5.1-compatible atomic status replacement with a real temporary backup path.
+- A deterministic overwrite fallback preserves lifecycle reporting on filesystems that do not implement atomic replacement.
+- The binary helper exposes a side-effect-free handshake-only verification mode exercised by the real Windows PowerShell executable during tests.
+- existing installations with the defective helper require this one-time installer upgrade; every subsequent packaged update uses the repaired helper automatically.
+- Startup failures retain request-scoped status and helper-log evidence instead of collapsing into an unexplained exit-code message.

package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "forgeflow",
-  "version": "0.10.3",
+  "version": "0.10.4",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "forgeflow",
-      "version": "0.10.3",
+      "version": "0.10.4",
       "dependencies": {
         "ssh2": "1.17.0"
       },

package.json

@@ -1,6 +1,6 @@
 {
   "name": "forgeflow",
-  "version": "0.10.3",
+  "version": "0.10.4",
   "private": true,
   "description": "Desktop release cockpit for local Git, Gitea Actions and controlled exact-commit deployments.",
   "main": "main.cjs",
@@ -108,6 +108,7 @@
       "docs/RELEASE_NOTES_0.10.1.md",
       "docs/RELEASE_NOTES_0.10.2.md",
       "docs/RELEASE_NOTES_0.10.3.md",
+      "docs/RELEASE_NOTES_0.10.4.md",
       "docs/CURRENT_STATE.md",
       "docs/MUTATION_MODEL.md",
       "docs/RELEASING.md",

scripts/apply-binary-update.ps1

@@ -7,7 +7,8 @@ param(
   [Parameter(Mandatory = $true)][int]$ParentPid,
   [Parameter(Mandatory = $true)][string]$LogPath,
   [Parameter(Mandatory = $true)][string]$StatusPath,
-  [Parameter(Mandatory = $true)][string]$UpdateId
+  [Parameter(Mandatory = $true)][string]$UpdateId,
+  [switch]$HandshakeOnly
 )
 
 $ErrorActionPreference = "Stop"
@@ -27,12 +28,26 @@ function Write-UpdateState {
     updatedAt = [DateTime]::UtcNow.ToString("o")
   }
   if ($State -in @("success", "failed", "rolled-back")) { $payload.completedAt = [DateTime]::UtcNow.ToString("o") }
+  $directory = Split-Path -Parent $StatusPath
+  if ($directory) { New-Item -ItemType Directory -Force -Path $directory | Out-Null }
   $temporary = "$StatusPath.$PID.tmp"
-  $payload | ConvertTo-Json -Depth 4 | Set-Content -LiteralPath $temporary -Encoding UTF8
+  $backup = "$StatusPath.$PID.bak"
-  if (Test-Path -LiteralPath $StatusPath) { [IO.File]::Replace($temporary, $StatusPath, $null) }
+  $json = $payload | ConvertTo-Json -Depth 4
-  else { Move-Item -LiteralPath $temporary -Destination $StatusPath }
+  $utf8NoBom = New-Object System.Text.UTF8Encoding($false)
+  [IO.File]::WriteAllText($temporary, $json, $utf8NoBom)
+  try {
+    if ([IO.File]::Exists($StatusPath)) {
+      [IO.File]::Replace($temporary, $StatusPath, $backup)
+      [IO.File]::Delete($backup)
+    } else {
+      [IO.File]::Move($temporary, $StatusPath)
+    }
+  } catch {
+    [IO.File]::Copy($temporary, $StatusPath, $true)
+    [IO.File]::Delete($temporary)
+    if ([IO.File]::Exists($backup)) { [IO.File]::Delete($backup) }
+  }
 }
-
 function Write-Log([string]$Message) {
   "{0} {1}" -f [DateTime]::UtcNow.ToString("o"), $Message | Add-Content -LiteralPath $LogPath -Encoding UTF8
 }
@@ -40,6 +55,10 @@ function Write-Log([string]$Message) {
 try {
   Write-UpdateState -State "started" -Message "Binary updater owns the update request."
   Write-Log "Validating ForgeFlow $ExpectedVersion binary update."
+  if ($HandshakeOnly) {
+    Write-Log "Handshake-only verification completed successfully."
+    exit 0
+  }
   $actualSha256 = (Get-FileHash -LiteralPath $BinaryPath -Algorithm SHA256).Hash.ToLowerInvariant()
   if ($actualSha256 -ne $ExpectedSha256.ToLowerInvariant()) { throw "Binary update SHA-256 verification failed." }
   if (-not (Test-Path -LiteralPath $CurrentExecutable -PathType Leaf)) { throw "Current ForgeFlow executable was not found." }

scripts/apply-source-update.ps1

@@ -54,15 +54,20 @@ function Write-UpdateState {
     if ([System.IO.File]::Exists($StatusPath)) {
       # Windows PowerShell 5.1 does not reliably let Move-Item -Force replace
       # an existing file. File.Replace is atomic on the local NTFS volume.
-      [System.IO.File]::Replace($temporary, $StatusPath, $null)
+      $backup = "$StatusPath.$PID.bak"
+      [System.IO.File]::Replace($temporary, $StatusPath, $backup)
     } else {
       [System.IO.File]::Move($temporary, $StatusPath)
     }
   } catch {
     # Some filesystems do not implement File.Replace. Copy with overwrite is
     # the deterministic fallback; the temporary file is removed afterwards.
-    [System.IO.File]::Copy($temporary, $StatusPath, $true)
+    if ([System.IO.File]::Exists($temporary)) {
-    [System.IO.File]::Delete($temporary)
+      [System.IO.File]::Copy($temporary, $StatusPath, $true)
+      [System.IO.File]::Delete($temporary)
+    }
+  } finally {
+    if ([System.IO.File]::Exists($backup)) { [System.IO.File]::Delete($backup) }
   }
 }
 

scripts/verify.mjs

@@ -83,6 +83,7 @@ const required = [
   "docs/RELEASE_NOTES_0.10.1.md",
   "docs/RELEASE_NOTES_0.10.2.md",
   "docs/RELEASE_NOTES_0.10.3.md",
+  "docs/RELEASE_NOTES_0.10.4.md",
   "docs/UPDATING.md",
   "docs/DIAGNOSTICS.md",
   "docs/DEPLOYMENT_SETUP.md",
@@ -121,9 +122,9 @@ for (const file of required) await access(path.join(root, file));
 const packageJson = JSON.parse(
   await readFile(path.join(root, "package.json"), "utf8"),
 );
-if (packageJson.version !== "0.10.3")
+if (packageJson.version !== "0.10.4")
   throw new Error(
-    `Expected package version 0.10.3, got ${packageJson.version}.`,
+    `Expected package version 0.10.4, got ${packageJson.version}.`,
   );
 const sourceManifest = await readFile(
   path.join(root, "SOURCE_MANIFEST.txt"),
@@ -449,6 +450,10 @@ const release0103 = await readFile(path.join(root, "docs/RELEASE_NOTES_0.10.3.md
 for (const phrase of ["concurrently", "debounce", "animation frame", "Git Validator", "stale or forged"]) {
   if (!release0103.includes(phrase)) throw new Error(`0.10.3 release notes are missing: ${phrase}`);
 }
+const release0104 = await readFile(path.join(root, "docs/RELEASE_NOTES_0.10.4.md"), "utf8");
+for (const phrase of ["Windows PowerShell 5.1", "atomic status", "handshake-only", "existing installations"]) {
+  if (!release0104.includes(phrase)) throw new Error(`0.10.4 release notes are missing: ${phrase}`);
+}
 const configSource = await readFile(path.join(root, "src/main/config-store.cjs"), "utf8");
 for (const mode of ["server-git", "push-bundle", "monitor-only"]) {
   if (!configSource.includes(mode)) throw new Error(`Deployment configuration is missing mode: ${mode}`);

src/renderer/mock-repository-bridge.js

@@ -5,7 +5,7 @@ function createMockRepositoryBridge(context) {
       await wait(80);
       snapshot();
       return {
-        appVersion: "0.10.3-demo",
+        appVersion: "0.10.4-demo",
         platform: "win32",
         state: clone(state),
         git: { available: true, version: "git version 2.47.3" },

tests/update-service.test.mjs

@@ -6,7 +6,11 @@ import path from "node:path";
 import { createRequire } from "node:module";
 import { EventEmitter } from "node:events";
 import { createHash } from "node:crypto";
+import { execFile } from "node:child_process";
+import { promisify } from "node:util";
+import { fileURLToPath } from "node:url";
 const require = createRequire(import.meta.url);
+const execFileAsync = promisify(execFile);
 const {
   UpdateService,
   waitForUpdaterStarted,
@@ -318,7 +322,7 @@ test("PowerShell helper replaces an existing launching status with a Windows-saf
   );
   assert.match(
     script,
-    /System\.IO\.File\]::Replace\(\$temporary, \$StatusPath, \$null\)/,
+    /System\.IO\.File\]::Replace\(\$temporary, \$StatusPath, \$backup\)/,
   );
   assert.match(
     script,
@@ -332,6 +336,28 @@ test("PowerShell helper replaces an existing launching status with a Windows-saf
   assert.match(script, /Handshake-only verification completed successfully/);
 });
 
+test("binary helper confirms startup through real Windows PowerShell", { skip: process.platform !== "win32" }, async () => {
+  const temp = await mkdtemp(path.join(os.tmpdir(), "forgeflow-binary-handshake-"));
+  const statusPath = path.join(temp, "status.json");
+  const logPath = path.join(temp, "helper.log");
+  await writeFile(statusPath, JSON.stringify({ state: "launching", updateId: "binary-handshake" }));
+  const powershell = path.join(process.env.SystemRoot || process.env.WINDIR, "System32", "WindowsPowerShell", "v1.0", "powershell.exe");
+  const scriptPath = fileURLToPath(new URL("../scripts/apply-binary-update.ps1", import.meta.url));
+  const { stdout, stderr } = await execFileAsync(powershell, [
+    "-NoLogo", "-NoProfile", "-NonInteractive", "-ExecutionPolicy", "Bypass", "-File", scriptPath,
+    "-BinaryPath", path.join(temp, "unused.exe"), "-ExpectedSha256", "0".repeat(64),
+    "-ExpectedVersion", "9.9.9", "-CurrentExecutable", path.join(temp, "unused-current.exe"),
+    "-Portable", "False", "-ParentPid", "999999", "-LogPath", logPath,
+    "-StatusPath", statusPath, "-UpdateId", "binary-handshake", "-HandshakeOnly"
+  ], { windowsHide: true });
+  assert.equal(stdout, "");
+  assert.equal(stderr, "");
+  const status = JSON.parse(await readFile(statusPath, "utf8"));
+  assert.equal(status.updateId, "binary-handshake");
+  assert.equal(status.state, "started");
+  assert.match(await readFile(logPath, "utf8"), /Handshake-only verification completed successfully/);
+  await rm(temp, { recursive: true, force: true });
+});
 test("early helper exit reports the helper log instead of only an exit code", async () => {
   const temp = await mkdtemp(
     path.join(os.tmpdir(), "forgeflow-update-log-tail-"),