views.js sat at the project's 750-line limit, so the diff cap in the previous
commit pushed it over and every further change would have meant shaving
comments elsewhere. That is the file asking for decomposition, which is what the
architecture audit says to do.
Diff rendering is self-contained: the line cap, the line classifier and the
change-map illustration depend on nothing in views.js beyond ui and escapeHtml.
They now live in src/renderer/diff-view.js and are registered in index.html and
in the three renderer file lists that scan the bridge surface, so anything added
there is covered by the existing contract tests.
views.js drops from 755 to 714 lines and no source file exceeds 750 again. The
nested ternary that classified a diff line became a named function with guard
clauses on the way.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Two failure modes that only show up under conditions the tests never reached.
renderDiff built one span per diff line with no bound. A regenerated lock file
is an ordinary change: 50,000 lines produce 4 MB of markup and 50,000 elements
that then have to be parsed and laid out inside the full shell replacement, and
200,000 lines produce 16 MB. The rendered view now stops at 2,000 lines and says
how many were left out; ui.diff keeps the whole change, so Copy diff, the editor
and hunk staging are unaffected. The line scan also runs once now instead of
three times.
withClient registered the connection error handler with once(). A connection
that fails and then emits a second error while it is being torn down - a reset
during client.end() is the ordinary case - leaves that event unhandled, and an
unhandled 'error' on an EventEmitter reaches the uncaughtException handler,
which calls app.exit(1). The handler stays attached and ignores anything after
the first failure.
Both are covered by tests that were confirmed to fail without the fix, together
with the SSH paths that had none: host key mismatch reporting, the trusted
fingerprint requirement for exec and upload, and remote upload path validation.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Three handlers referenced a dependency they were never given, which made them
throw a ReferenceError as soon as they ran:
- deployment:preflight for Gitea Actions profiles (`preflight` was passed to
registerOperationsIpc but not to registerDeploymentIpc)
- Unraid write-access repair (`safeRelativeRemoteFile` was missing from
createUnraidAccessMethods)
- a dead reference of the same name in unraid-state-methods
no-undef and no-unused-vars were disabled for every file, which is why none of
these were caught. Both are now enabled for src/main and src/shared, where the
dependency graph is explicit. The renderer keeps them off because its functions
are deliberately cross-script globals.
Performance:
- git.status() spawned three processes (rev-parse, status, remote get-url) per
call. A directory holding its own .git is by definition the work tree root, so
rev-parse is unnecessary, and the remote URL is cached against the mtime of
.git/config, including the failure for a repository without that remote.
- git status runs with --no-optional-locks so a read no longer rewrites the
index. That stops it fighting a concurrent Git command for the index lock, and
is what makes filesystem watching viable at all.
- One commit issued four `git status` reads; callers that already hold the
status now pass it on, leaving two.
- The repository monitor is event driven. A watched repository is read on
filesystem activity, with a 30s safety net for watchers that stop delivering
and a 1s floor so a busy tree cannot drive a read per event. Repositories that
cannot be watched keep using the interval. Idle cost for one repository over
35s: 24 git processes before, 3 after.
- Resolving one repository by name no longer refreshes the whole workspace.
- Concurrent configuration saves share a single write of the latest state.
- Repository discovery follows directory junctions again. The filter that
skipped them made the realpath cycle guard dead code, and hid any project
folder reached through a junction.
Renderer:
- render() replaced the whole shell on every poll, discarding focus, caret and
scroll position while the user was typing. Those are preserved now, and an
unchanged render leaves the DOM alone entirely.
- The four sections that enhanceRenderedUi() injected after render moved into
the views, so the rendered markup is the single source of truth.
- The monitor no longer keeps a repository paused forever when it is unlinked
mid-mutation, scheduleAutoRefresh honours its delay argument, the demo bridges
no longer block startup, and #app is no longer an aria-live region announcing
the entire UI on every render.
IPC channel plumbing moved to src/main/ipc/channel.cjs, replacing a module-level
mutable diagnostics singleton with an argument.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
NuklearRabbit